From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145516460113920 X-Received: by 10.28.175.144 with SMTP id y138mr425403wme.4.1504167814896; Thu, 31 Aug 2017 01:23:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.8.90 with SMTP id g26ls579608ljd.18.gmail; Thu, 31 Aug 2017 01:23:34 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5OCVaYGJCRkHsV2eUY5w87YBLdDFFh124G+J8OTpl6D7KFRPvMlidXFOFUuok6KbW1rhaR X-Received: by 10.46.25.88 with SMTP id p85mr402697lje.0.1504167814412; Thu, 31 Aug 2017 01:23:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504167814; cv=none; d=google.com; s=arc-20160816; b=a5UDvejUAZ1e1BH4aLH62ZT28DliNZhA9LiEiYRgykrs/ZliHxqyO8nnfnC1vNx7s7 doe1BbQSIuuIjOT/mKlsgjJ8KHzxn1UX5lNDxje58Aux749f5FmsH5G30F+ox1Pk36AA pIGlgfDklaekmv+WZpAloy/UbzQjGj5llDRM5bWprTNxDZpMlrf8mA/kuizIMm0kbcHC JJnBDlipXZZSAtcc4w+DcSgrQcUcm9ylceBtnU7z0oeOQH1w8bmJij5NVJmfPgz7X6F1 0gwU8XKb1eBDvsLiYH2wzs569HxfGBFEoNDpDNkcUjMROMTKZsHXlJYK4V+xZtJlMgbO Ribg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=3CiOVbur87QhvO0T+ikv4QKSijOuVe/gCka3TFXjAOQ=; b=a3caAtOKy4nFri6r/7LKCiL03Ok3UmjHwL4DP0qrUBzb+lphxIoMs7GLqrJ8+fO9PN 3Vh5CDJ6q0mC56kSBFtUV8C8bweHeWSDfFkDWl000q5kbJDxzIdm43Tlt3kNmeQ9JVEf n/U4MDqY3p1LOlMpAURZwtbT387jV/22jbIsgxv/s9pDoc88Zwi4shb66Ip66NKE3Otg QrtMLbMhIc3PG/ZR9m4PrwcoSqPe9vG6liJS/GCkaA7mkKiBqRFH+/IO4fEFQLuAtqAX ADhb6lUb8qbPKcjzLeIHdr+Ghh7xm2RB6tiKbYs82iczmBYlXobkObWxKZav/nIZnoSO yClA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id k201si245311wmg.9.2017.08.31.01.23.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Aug 2017 01:23:34 -0700 (PDT) Received-SPF: neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id v7V8NL5v006353 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Aug 2017 10:23:21 +0200 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id v7V8NLJH006570; Thu, 31 Aug 2017 10:23:22 +0200 Subject: Re: [PATCH 3/6] meta/dpkg: rename to dpkg-debian and add comment To: "[ext] Henning Schild" , isar-users@googlegroups.com Cc: Alexander Smirnov , Christian Storm , Claudius Heine References: <9e4ec5fd512461f19aebdda5420544bc91fadb17.1504119538.git.henning.schild@siemens.com> From: Claudius Heine Message-ID: <3af83622-7b52-1828-a875-00b778417389@siemens.com> Date: Thu, 31 Aug 2017 10:23:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <9e4ec5fd512461f19aebdda5420544bc91fadb17.1504119538.git.henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: lIg9Gd5Z47gK Hi, On 08/30/2017 09:03 PM, [ext] Henning Schild wrote: > Issues: > In order to have multiple classes that create debian packages we need to > come up with different names for them. > > Change: > Give the class a name that is supposed to reflect that this class should > be used if you have sources and a /debian directory for them. Also add a > small comment to the header to make that more clear. > Update the one user in the Isar repository as well. > > Impact: > This patch does not change the behaviour of Isar. It addresses the > issue. However, all forks of Isar will have to update all recipes that > inherited the class. > > Signed-off-by: Henning Schild > --- > meta-isar/recipes-app/hello/hello.bb | 2 +- > meta/classes/{dpkg.bbclass => dpkg-debian.bbclass} | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > rename meta/classes/{dpkg.bbclass => dpkg-debian.bbclass} (84%) I am not 100% behind the new 'dpkg-debian' name, because its redundant. One might think: "Of course a dpkg is for debian, because dpkg stands for debian package." I know that you are referencing the /debian directory with the '-debian' prefix, but I think this is not intuitive. Here are some other/better/worse suggestions: - dpkg-src-dir Its a directory that contains prepared debian package source files. - dpkg-src Simpler but then we should later expand this to support all source package formats from debian [1] in a custom unpack routine (if bitbake does not support all these different source package formats already) [1] https://people.debian.org/~hertzog/dpkg-source.html#lbAH Cheers, Claudius > > diff --git a/meta-isar/recipes-app/hello/hello.bb b/meta-isar/recipes-app/hello/hello.bb > index 56424fb..30cf8a8 100644 > --- a/meta-isar/recipes-app/hello/hello.bb > +++ b/meta-isar/recipes-app/hello/hello.bb > @@ -15,4 +15,4 @@ SRCREV = "ad7065ecc4840cc436bfcdac427386dbba4ea719" > > SRC_DIR = "git" > > -inherit dpkg > +inherit dpkg-debian > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg-debian.bbclass > similarity index 84% > rename from meta/classes/dpkg.bbclass > rename to meta/classes/dpkg-debian.bbclass > index 0b8c7c4..7466254 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg-debian.bbclass > @@ -1,5 +1,9 @@ > # This software is a part of ISAR. > # Copyright (C) 2015-2016 ilbers GmbH > +# > +# This class allows you to build debian packages from sources. > +# These sources need to be enabled for that, they need to have the > +# debian/ folder. > > # Add dependency from buildchroot creation > DEPENDS += "buildchroot" > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de