public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Gylstorff Quirin <quirin.gylstorff@siemens.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	Anton Mikanovich <amikan@ilbers.de>,
	isar-users@googlegroups.com
Subject: Re: [PATCH 2/2] Revert "scripts/ci_build.sh: Set avocado-framework version to 96.0"
Date: Wed, 13 Jul 2022 15:12:34 +0200	[thread overview]
Message-ID: <3b0d59b8-9e04-365d-9b04-f9081c50aad9@siemens.com> (raw)
In-Reply-To: <bb0e0fa4-87fa-892e-c66d-8ac4770e9b0d@siemens.com>



On 7/13/22 07:19, Jan Kiszka wrote:
> On 12.07.22 19:32, Anton Mikanovich wrote:
>> No more Avocado version limit needed after switching to nrunner.
>>
>> This reverts commit 9aec8ba92912c682f7732b015f1919c5308f40a2.
>> ---
>>   scripts/ci_build.sh | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
>> index fa7208c..debb386 100755
>> --- a/scripts/ci_build.sh
>> +++ b/scripts/ci_build.sh
>> @@ -21,7 +21,7 @@ if ! command -v avocado > /dev/null; then
>>       rm -rf /tmp/avocado_venv
>>       virtualenv --python python3 /tmp/avocado_venv
>>       source /tmp/avocado_venv/bin/activate
>> -    pip install avocado-framework==96.0
>> +    pip install avocado-framework
>>   fi
>>   
>>   # Get Avocado build tests path
> 
> Bad idea as you can't predict future API changes of Avocado.
> 

We should use a defined version for the avocado framework. This 
simplifies the testing for new developers.

As alternative we can use a requirements.txt.

Quirin
> Jan
> 


  reply	other threads:[~2022-07-13 13:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 17:32 [PATCH 0/2] Adopt CI to Avocado 97.0 Anton Mikanovich
2022-07-12 17:32 ` [PATCH 1/2] CI: switch to the new runner Anton Mikanovich
2022-07-13 11:20   ` Henning Schild
2022-07-13 12:08     ` Anton Mikanovich
2022-07-12 17:32 ` [PATCH 2/2] Revert "scripts/ci_build.sh: Set avocado-framework version to 96.0" Anton Mikanovich
2022-07-13  5:19   ` Jan Kiszka
2022-07-13 13:12     ` Gylstorff Quirin [this message]
2022-07-13 13:21       ` Anton Mikanovich
2022-07-14  9:19         ` Jan Kiszka
2022-07-14 12:50           ` Henning Schild
2022-07-20  5:52 ` [PATCH 0/2] Adopt CI to Avocado 97.0 Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b0d59b8-9e04-365d-9b04-f9081c50aad9@siemens.com \
    --to=quirin.gylstorff@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox