Re: [PATCH 0/4 v5] Isar apt deployment

[Alexander Smirnov <asmirnov@ilbers.de>]

[-- Attachment #1: Type: text/plain, Size: 4102 bytes --]



On 10/18/2017 08:10 PM, Alexander Smirnov wrote:
> On 10/18/2017 04:44 PM, Henning Schild wrote:
>> On Wed, 18 Oct 2017 14:06:53 +0300
>> Alexander Smirnov <asmirnov@ilbers.de> wrote:
>>
>>> Hi,
>>>
>>>> i just tried it and the task do_cache_config was not executed before
>>>> the first do_populate.
>>>
>>> Could you please specify more details:
>>>
>>>    - Build command
>>
>> Well i am using layering, and so is Claudius. So the command wont help
>> you much. It should basically boil down to
>>
>> bitbake multiconfig:qemuamd64-stretch:isar-image-base
>>
>>>    - Commit ID
>>
>> f33e48bd07039032e3
>>
>> I am guessing you can not reproduce the issue, we should find out why.
>> But since Claudius confirmend that he can not use these patches either,
>> and there are still some open points, i think you should remove those
>> patches from next.
>>
> 
> At first, as I understand you use private layering. So if something 
> doesn't work in your custom environment, without details and analysis 
> it's not the case to reset 'next' branch.
> 
> Before perform any merge, apart from my local builds, the reference 
> build on CI machine is also passed. So the upstream Isar does support 
> the claimed features.
> 
> If I'm not able to reproduce your issue and there is no information 
> about problem, then I'm not able to fix it. So if you need assistance in 
> resolving the issue, please provide more details. If the problem will be 
> found, the fix should be sent.

Please try the patch attached.

> 
> Regarding new open points appeared after v5, they contain several 
> proposals what to try, but they doesn't influence on apt feature.
> 
> I'll try the things you proposed with multiconfig and if they work, I'll 
> send updates for current apt implementation. But working feature in 
> upstream should not be blocked.
> > Alex
> 
>> Henning
>>
>>> Alex
>>>
>>>>
>>>> I would suggest the following changes:
>>>> - create one task in dpkg-base.bbclass that does the following
>>>>    - config and init reprepro if no other recipe did that before
>>>>    - add package
>>>>    - use bitkages task[lockfiles] to deal with races between recipes,
>>>>      put distro into lockfile-name so we have one lock per distro
>>>> - drop do_populate
>>>> - call the new task instead of, or in do_deploy_deb
>>>>
>>>> Henning
>>>>
>>>> Am Thu, 5 Oct 2017 13:08:03 +0300
>>>> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
>>>>> Hi all,
>>>>>
>>>>> this series switch Isar internal binary package processing to apt
>>>>> repository. It performs this following:
>>>>>
>>>>> 1. Create repositories 'tmp/deploy/apt' for all architectures
>>>>> requested by multiconfig.
>>>>>
>>>>> 2. Generate reprepro database.
>>>>>
>>>>> 3. Put all the newly built packages to apt repository.
>>>>>
>>>>> 4. Pass this Isar repository to image multistrap.
>>>>>
>>>>> Documentation will be updated after agreement on this
>>>>> implementation.
>>>>>
>>>>> Changes since v4:
>>>>>    - Drop meta-isar-bin layer.
>>>>>
>>>>> With best regards,
>>>>> Alex
>>>>>
>>>>> Alexander Smirnov (4):
>>>>>     apt: Generate configs for apt
>>>>>     apt: Generate Isar reprepro database
>>>>>     apt: Populate Isar apt
>>>>>     apt: Install packages via multistrap
>>>>>
>>>>>    meta-isar/conf/layer.conf                          | 13 ++++-
>>>>>    meta-isar/conf/local.conf.sample                   |  4 ++
>>>>>    .../recipes-core/images/files/distributions.in     |  3 +
>>>>>    .../recipes-core/images/files/multistrap.conf.in   |  9 ++-
>>>>>    meta-isar/recipes-core/images/isar-image-base.bb   |  6 +-
>>>>>    meta/classes/ext4-img.bbclass                      |  2 +-
>>>>>    meta/classes/image.bbclass                         | 65
>>>>> +++++++++++++++++++--- 7 files changed, 88 insertions(+), 14
>>>>> deletions(-) create mode 100644
>>>>> meta-isar/recipes-core/images/files/distributions.in
>>>
>>
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov

[-- Attachment #2: apt_fix.patch --]
[-- Type: text/x-patch, Size: 355 bytes --]

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 2284655..42386a6 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -54,7 +54,7 @@ do_cache_config() {
     fi
 }
 
-addtask cache_config before do_fetch
+addtask cache_config before do_populate
 
 do_populate[stamp-extra-info] = "${DISTRO}-${MACHINE}"