From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6827348902787678208 X-Received: by 2002:a05:6512:321b:: with SMTP id d27mr4998398lfe.58.1589616039772; Sat, 16 May 2020 01:00:39 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:86cf:: with SMTP id n15ls739717ljj.11.gmail; Sat, 16 May 2020 01:00:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrhkkUNLcTV7TUrXke2br+UT5uXrssyKqajS454AIp48jUTQWgMb0C4IT0x1VuIm3HRS8p X-Received: by 2002:a2e:88d8:: with SMTP id a24mr4640106ljk.224.1589616038958; Sat, 16 May 2020 01:00:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589616038; cv=none; d=google.com; s=arc-20160816; b=TYFcJTz6vLaSdo92tSY3pDJzXxNQDtctcECRUw8tZ/zZtMn4MRz6NlpioSSA99IeUB e+wdRJtbW+oa3+rlFkZGh+Z+FzZ8iOJfytGC3EXbYHkOISnw0mXQKkvGWqjQWIE9XWGf 1tatQ+Qa1dOi3gn0095jH0royNc4Mu45r6BpEZYDKwwL/SXm8jnBxuJgMGJXBD1TVPgZ WvgieUtjjQBFDwlb4RSyW77VFnc6z+TI4/a3RmSvjx3ji1ZN2wxZ7Nu4J+uWpNZjrumC iikzpp6nD+amueNVAmxuQPVMRfhL2ykAazBFFVpWLbqeCT0FNuvsMwuV1M9mVuCAxvtx N3BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:mime-version:user-agent :date:message-id:to:subject:from:dkim-signature; bh=06awx3VBMopqRUnXb+bIdRtSLUfCoaUqM7u/fx7/Kb8=; b=k9UjLQ46gblCWdhitvjmdJiYbSmXgdnFp+Mn+YLPCBMGTCSHtsY5xbd4PajQ+d1bWq mohAXgYiyHdTecDyWTxL7kLqoAgFLvgaMDV5/1nOqSdiFIU0c3lUEyKBJ1qKwKHuQWT0 mYXE61eCk9kWTuk7BTBxoqg82CkZxFe28tq+kB3QVskUhylf6bpqfYr3UAKx8F8M3tou PGhSBZPf0BxXuR8DcuPTHIdouM+Wd82k6EAdzSVFPOLV2aWmlcB/lKcS/N24F5vV+Tbs pD4SmbunvTcB4LbTQqwcDdaO5PrL6NeCZzHGuaAUN3cfQK5RzwP2olknUoCKgCxOL0CI B3DA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=kmm2XP0F; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.14 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.15.14]) by gmr-mx.google.com with ESMTPS id c144si245444lfg.5.2020.05.16.01.00.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 May 2020 01:00:38 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.14 as permitted sender) client-ip=212.227.15.14; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=kmm2XP0F; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.14 as permitted sender) smtp.mailfrom=jan.kiszka@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1589616038; bh=4YwzYFXrOfa6splaSk5jzhHGT0fULUwVB5u2eLLnEOA=; h=X-UI-Sender-Class:From:Subject:To:Date; b=kmm2XP0FsjzJoXuYX7SpWouGG1J8mdJqn5b3VmfOyYn3VyFqmhMqZKFvc6B2YUzDi yphjvocSfyqEx+s9QDOmgNE44DNTTGHIId/g0itQyKeQa0jnd3B4cP9w0NAdFwacOp EvswFfrd2U89eywbXooROH3huZPfrkEMzD2Yukuo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.53.180]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LfiZ8-1ikaku14JO-00pPmW for ; Sat, 16 May 2020 10:00:38 +0200 From: Jan Kiszka Subject: [PATCH] devshell: Use different termination test to avoid warnings To: isar-users Message-ID: <3b659fd0-15bb-d74c-8460-ffd67651401f@web.de> Date: Sat, 16 May 2020 10:00:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:/lt3ulosRrqOrCb0qYAvQTGGMXorrbpPXP/C+yAa1Ij+YoO9VDg uQ2c3NWubAjUZuA0cP2sQuVU/esxj09ZChIc4/XFmuduoFSyBQdtc58OXxO9o5eijP7SJUc mgotMgBKepxj+jZ2Flu8fGZxxPTHhfZGEj5lqBj93q25csrA/+S16+auosKo7QbeYEzgVsO CwNF/g7DTkWrw1mI6S3xw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:kdYFRpfwNxE=:h2fmPUdxF/FCIoOTMUucwP g2U4Iht3WIpjKzPFxWSaUyk7lH3hWtNEWvQQOcILaKCqzUDk322flQtdOfSuo76GT8psmNVa8 9iZLYWcCaK5lgPdxCGnTAZ6Q/N4JvRd8vxA1lUek/WFmn6o7yHasMbpwp0Rk09Sk1+Inr+DFI C763EczaDZOzozTGzdCkMESt97xRfewiJ39y3bSdExfj6q4YQ1MD1bpb4B+TL6tHWTjWB6E+o No1l6p4mnoiQ6SLzMzobZ1OQRDWcZjc6V616JQbN40WiytLbzptBJ6Dr86cFE0YThPDO82mv6 1yYpIAe8cfcke6gfwMLHOkIn0DZP9Hm6HjJLodACAx+eSV7aITiGX1rPfasVutlzVjhziFzTr 5qukeDDXXB+GthkOLm56j5aXQ8zGA5WG+ov3xXu8zdHFp5MDIriPZgxyPj0Gr38EhVDxsn43A ByHBDQ7/n2j9PePBWQy2/f/unGLLYOwBnyNehrwniqAEZMftHdizMY2Z9W8pCde1x5/vISdyF XzushNDXM5MY4lWPxlHVXHEFfpLE+fGwktRreZmDH/1PT1RhFWw0swzGwb8Cjm2TvHY97wulc qgikZU3bqYokI/6LQN4HGDbRPIMj9Zot3Q3FKqdZ+c419YJj9Sjf3hwKSeKMZnzEEUmcH6EEJ n+60rl4tLTDi0r0j9bneG3gBSafLV5ZDsTNe052lqsvAhr9OhuZjHQ0AAfC6aIEoRTZxDAM+i nwtKfS++ZOKyIwtBb5ibgRdKn1Rwr2Zrht/bXpz3VKJmwX3qZYmD8/ze6C6A4SgkPfTwSswj8 cS3O23gI+X71Qy/2cvqnA7bDqUeSuPgMz9H2F1h/wGZeUYBXBAY1bXgRFN7VkXQGiAYCOPp0d 81paSuI7uAkypARg2VVhQiB4H1axFnCWe+53fuftc8Yry43MgAXCglEKNdmQAf28kDnrM3sBX gsWwyzJUigUDt5KSYZ2gqqasnFbkyltp8Ymg7Lw5zrPNd4SR9ca686eCLaWhsrsCqz8hQowsc hfECW28iQi/GUGlrZLYv0QWTYCH7qfU/8bSG9CM68SkGw6oaqp6l6J/KXtEah2R6fSQOqyYjB o5znEOoFnHXp89W1rgCuiNeAdbefE5xxLapQGOWGEgswewTVSiDQ5GG79j5qOPQf6nwveAzEQ a3WwwlZ5fB0eS8Bi+gXMeSPppYSlCqsnQS16reV8qFO3dwh1tDhEcMu3Gn54w7t5mea+/Qmbd t79syf0tqxq78lP8k X-TUID: Z0FOHwD80UNL From: Jan Kiszka As we run the terminal via a sudo chroot, OE's way of testing for the existence of the target PID does not work. It will rather fail early due to missing permissions (user tries to send signal to root process), and we will wait in the unmount loop, generating warnings like WARNING: mc:qemuamd64-buster:example-raw-0.3-r0 do_devshell: /work/build/t= mp/deploy/buildchroot-target/debian-buster-amd64//home/builder/example-raw= : Couldn't unmount, retrying... This replaces the kill(pid, 0) with a test for the existence of the corresponding /proc/ directory. Signed-off-by: Jan Kiszka =2D-- meta/lib/oe/terminal.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py index 87058040..a9fb62b9 100644 =2D-- a/meta/lib/oe/terminal.py +++ b/meta/lib/oe/terminal.py @@ -245,9 +245,11 @@ def spawn(name, sh_cmd, title=3DNone, env=3DNone, d= =3DNone): finally: os.unlink(pidfile) + # Test for /proc entry so that target pid can also be privileged + procpid =3D "/proc/%d" % pid while True: try: - os.kill(pid, 0) + os.stat(procpid) time.sleep(0.1) except OSError: return =2D- 2.26.1