From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7231085468566159360 X-Received: by 2002:a05:6870:c0d5:b0:1b0:1d78:f784 with SMTP id e21-20020a056870c0d500b001b01d78f784mr840910oad.54.1688617947546; Wed, 05 Jul 2023 21:32:27 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6871:520b:b0:1b3:d776:8172 with SMTP id ht11-20020a056871520b00b001b3d7768172ls170083oac.1.-pod-prod-00-us; Wed, 05 Jul 2023 21:32:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlG9nLuTt2RqGr3mr1t7LX3qDWMdnsVvaUy/Gisknu+a8XMFznWLDMADj+5w1xUnEWqxUHVg X-Received: by 2002:a05:6870:c6a2:b0:1b0:226a:2f3d with SMTP id cv34-20020a056870c6a200b001b0226a2f3dmr686583oab.14.1688617946951; Wed, 05 Jul 2023 21:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688617946; cv=none; d=google.com; s=arc-20160816; b=jaodhg80eWeDeD76wZ4RFuMCx3MWUzA04SC2N9vZUTbuoQCy/7pYMNoNd1v+Qle4bV 10rmAouNIzTTXEgQM4wxm4Jnkys8ALz78SnLhpZSo0OPo34Syu4T8PKRSN49ezxFP2rn /vLgrG9fVyfiYCRGgaTC4L8qi1p2zSx9r4FU8BSOuGRaGCZvoEUmgSIzD1ThK+6fbcr+ rdnyGmHKWxgUqPDLOSI0bTNBs8bDDJdqRBUIgfy+gZURWi5Jr5FxlgRGbCO51sj411Gg Vsb1MdZzvaLPGEWwP38Cg6mqxhSv9PBGkvxGRd7xCioGLp6oxXd887oN/FW9YWnO+rnD 07VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id; bh=bV6vo7jjA6Y8LFJ+w3b7O7/VnVEy+pTItnPsPdoERT0=; fh=+uOPEgF/mVggnsyw1oF6RzPwGuKxXqVfTHhmVskHbPw=; b=cE7zPsi6ctDQ39Y1CcMt6C4hjpCaTMkwOiSNoyXd19sREErGC6aR8AK2nCccDD+/8K js2kPiYi7ev0gbkiQPN7RVti9OdeGKB35nMNEuJLcGTWH+6id6CtfVpv65bDoPRSebKD CToTszzUF7str6XAanEgRMVsTtGh9OxN69iotdLMqZQmUy0a8JEL7C8ZXbNa3EFjFlAk crFO4oSa8IL3M7HOwOFmy9rAUAQn0hIFXtsctPr3PzGcQ/jzYwAG8Hhi5JUw78/5ORZx ehjdzri8CW+8yPPrletfXKwIg1cpLYAwctqBZejJLVDQgwA721unX+mrmQuFj8uhQrcF /Zag== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id lv16-20020a056871439000b001b3caa6f8adsi62864oab.2.2023.07.05.21.32.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jul 2023 21:32:26 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 3664WNvg002695 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Jul 2023 06:32:24 +0200 Message-ID: <3b879c736e1cc47931a5218f55be34cdcce1aeb2.camel@ilbers.de> Subject: Re: [PATCH v3 0/4] Rewrite the image-account-extension in python From: Uladzimir Bely To: "T. Schaffner" , isar-users@googlegroups.com Cc: quirin.gylstorff@siemens.com, henning.schild@siemens.com Date: Thu, 06 Jul 2023 07:32:25 +0300 In-Reply-To: <20230522065531.2300448-1-tobias.schaffner@siemens.com> References: <20230522065531.2300448-1-tobias.schaffner@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: VftBerfgu2Tm On Mon, 2023-05-22 at 08:55 +0200, T. Schaffner wrote: > From: Tobias Schaffner >=20 > This allows us to drop a lot of encoding and parsing code that was > used > to transition to shell and therefore makes it easier to read and > maintain. >=20 > Using python functions for more complex tasks allows us the usage of > unittests. A very basic infrastructure for unittesting using the > build > in python unittest and the bb.parse module was added. This was used > to > test the re-implementation of the image-account-extension as a first > showcase. >=20 > This is a rebased version of the refactoring part of the "allow > creation > of users/groups before rootfs creation" patch series to decouple the > merge of the simplifications. >=20 > Changes since v1: > - Fix wrong year in copyright of image-account-extension >=20 > Changes since v2: > - Only set system flag if a new group is created and create a > unittest > =C2=A0 that proofs that it is not added for existing groups. >=20 > Tobias Schaffner (4): > =C2=A0 simplify image-account-extension > =C2=A0 create a minimal python unittest infrastructure > =C2=A0 add unittests for the image-account-extension > =C2=A0 set minimal python version in user_manual to 3.5 >=20 > =C2=A0doc/user_manual.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 +- > =C2=A0meta/classes/image-account-extension.bbclass=C2=A0 | 368 ++++++----= ------ > -- > =C2=A0testsuite/unittests/README.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 28 ++ > =C2=A0testsuite/unittests/bitbake.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 37 ++ > =C2=A0testsuite/unittests/rootfs.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 45 +++ > =C2=A0.../unittests/test_image_account_extension.py | 157 ++++++++ > =C2=A06 files changed, 392 insertions(+), 245 deletions(-) > =C2=A0create mode 100644 testsuite/unittests/README.md > =C2=A0create mode 100644 testsuite/unittests/bitbake.py > =C2=A0create mode 100644 testsuite/unittests/rootfs.py > =C2=A0create mode 100644 > testsuite/unittests/test_image_account_extension.py >=20 Since this passes full and fast CI and there were no any comments to v3 for a long time, we are going to merge the patchset.