From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6735105003214602240 X-Received: by 2002:a05:600c:2108:: with SMTP id u8mr2311890wml.13.1568704497909; Tue, 17 Sep 2019 00:14:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:a54b:: with SMTP id o72ls577211wme.2.gmail; Tue, 17 Sep 2019 00:14:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNm8blzfLCTGXPzAV92rgA1kzSg0lpK7D+dZ03kJLmBfoq0ehnGfu+Q38b5Q2oJ6vKqcok X-Received: by 2002:a1c:1dd4:: with SMTP id d203mr2290592wmd.45.1568704497379; Tue, 17 Sep 2019 00:14:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568704497; cv=none; d=google.com; s=arc-20160816; b=IbMlr0i6ScBUtKj5aHj8dZNBGnYk4emQeY4Us9ms2UhAivlkbD13sHWZoH9xlXxHFY SWEYk/DIY31g1EYott4wsXpc26Fv/cmjcWsTi8oWRcXiy7oMrAhEYYIvucGhTYb9UZ0P unkmRL8ooUpV0S9qh+R3Av7E7/M/s1lYIHuJLAD/CDqy26xzOI8Z7nT9itQOkhPriXkO T5+MpNnkDkANzjlmAdOUZks2p/jTxIyszizHxacGpFgM+ANAQEeFIsUDDgrrPIqay6FO z7iUWOMtCI4TnFM1/qiXz+q355jfZRUaEsf23QrZgBfW126dZ365u+SIZowYwUPKeBnZ D96Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:mime-version:user-agent:date:message-id:organization :autocrypt:openpgp:from:references:cc:to:subject; bh=g/CP9y1Mn/MV3391SdqMqYBD4v3qfAijNZNRYcOnSIc=; b=rpi+1wPU7Fl5XPqvh1L0WNjwBtQ4KifezgL1DkeM+hfOSzNdxGW18e0dQH77BHAk3l PGyd0vA4onhQTu8Iit/ZGD72JbWxQpH4+4wclJiUitnrPiyoALzIynq4RETYi+uDU9NI Ggvl+eNGsKIAIX55M65UtrbYIclcPmtSklIYe0SvIdOgURplppyxEt2gDjq0A7ERfYZp 5ASC7fLpRH9qjqGo8p2NqrkbYhl5hYEnPHsMx9oRTKrTOO3XocHD6SxYC8MqEhy0jFJp dkq1rzlQklf0tTCiQ77fUf1QiznEA7ct0KtffwqJHHDJsVBiX+yRg+fmcQV59L9ilW8q TlPA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id j9si409883wmh.1.2019.09.17.00.14.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 00:14:57 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 46XZB919S1z1rGSM; Tue, 17 Sep 2019 09:14:57 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 46XZB90kC6z1rg1y; Tue, 17 Sep 2019 09:14:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id miRAtYN12vTg; Tue, 17 Sep 2019 09:14:56 +0200 (CEST) X-Auth-Info: Ofl2dgRT4FdRjC73OJQdOc97HdaUT4fbwUo444DPksI= Received: from [10.0.201.101] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 17 Sep 2019 09:14:55 +0200 (CEST) Subject: Re: [PATCH] linux-custom: Control linux-libc-dev deployment manually To: Henning Schild , Jan Kiszka Cc: isar-users , Cedric Hombourger References: <0600904d-7f34-875f-6bcf-6fbbfe8b9933@siemens.com> <20190916102742.284e1838@md1za8fc.ad001.siemens.net> <3ea40d5b-daab-f6a6-6bc8-c14b11a49a91@siemens.com> <20190916104607.7142b22e@md1za8fc.ad001.siemens.net> From: Claudius Heine Openpgp: preference=signencrypt Autocrypt: addr=ch@denx.de; keydata= mQINBFSuWugBEADI18RqDRNsXrWtQBuI60knLMfJ6j26C4ArB5ht4TzTQg9PfTJf1BwKUMYH 1s5qKikAX1mAFm7ca4uxc8uY1AdTFKepNp6ewcRShWPFo1+7DJcTlS1O+cIUyOeo6yrMMI2D DeILzcird0ATI+v7QzO1TmAmEGB28kp9KozZqFKS28p6/GLJ8qCYo50MpacsB0oi8pUeU6+8 KUlKfDDNZvwM+7rVlshOdp0iuAe12IH4gePkXycTm/PvCdqpvm6Uc0FryYh2AzB78Zvzpysb VTdGzFYavdLJJjNifj1XKgeRayR1UG0dMpcUwzLxqRmeRN1Ca7/NVT/NUHm8r80ta6mvjDHj 0vHWfn0CFgfikRtB4tftWmsvYs8YtDtR7X4gaYk5CHhR9iAGU2zElYp2Q417oe1FuXn0eFxG 1SzENtFdUZv64oQSOblJ9ZKslXLBlwCLacSdNK499IEs03UAaTPgh5L/t8G81FDeXduFt129 h6UY6Si2xDYE9wZ90XGag7Uv0wC2LKyOWzEgeOJDIGjQVAMlcr5i6nNa30n/qMTWSf+jahLa 7cr8Mgzw0W9lSAX1CytJJjh5hTHF/atZkl6+vInHJLTtBA2leRF7og2H6PHfUmpJ/A46x71l rODfqjq4/ZblSgqgQCU3rXq8bPwnl7zo/dlyqYUPVAJQ79m9jwARAQABtBtDbGF1ZGl1cyBI ZWluZSA8Y2hAZGVueC5kZT6JAlUEEwEKAD8CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheA FiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlw288kFCQl50EgACgkQEXPLGZgIsVNveQ/9HeM+ 2rWn2pWtrhiKdVEZHb0OIoRdbxYvdp+GcAMJxSay7avAGVxRW5Kjc0Q3/RmNXh+eHcR+US5n y8qduw0Bbpx25Rr8CseCot3G58BCHzNfI/yKswuSRUSWPHIAj8FT8yw2R7b/aYu0J8NvGSfw Rt8pTCfdKXcGEnEcF9XFSHHvKIjDLFErTZh35fTjlOtaLzcWNEw1QMf3Ctym3dCLfNvWNr+j sSG1AL/6ECn5x5Y/mWuSwfjrP+jZCBLMLDrNvOP+1+q4wTFZsPjvrXZFYp0lPLXwv+SB0QwP onXwLqa2VYXhIKesWioQA9TuGzO1MSEeezTEvPYuvRCdBbjltW1SaJFenimAI9dSpeglqx30 jJdVi7E9izw715jrmwSgdgZfAHIOSkXwJ4AoOF5SeBxMlloC/2MKG8SYUYrE+9jUrrGALgjb VEhEuNnIDTOisK4islin4zt5BjpUpzv4OXz6df0x0ZMatgTxvD+QF8t1X0STezHnY4iEGEzS rYdaYP8q0Yjb7Go0qRDlJ9vdvIu/Gv9jKXkCnjteDkcpHCjnkAs9ecX3hW6JcAYb40DTneWA Aq9I6kAbamH3MF+9oXqcMy34LvFKM1vHOKBLjBCt7HuRvo2iSgmfr8vATw/Euouf3S/FpoIr I+7QjuH029kmV9d9/Hb3xZhQCrDlfoa5Ag0EVK5a6AEQANbSW8FeAXDMaL26JYiaWriOCB4g zqSIGXPjy1pdtS3dghks2WvADdoUuXBE6ZdbEGl+3QUlXhv167iY1M48oOVCmBnp/ENt1D9s mYB8lby4bVfb5e6eP4VivRUKiU1S2Yvp3en6/Bnts8q6clDezcbWu8lOjzlZEgXbcUPM77r3 3knriTtjnGEGc4Blta/1ED6U00NjqZ3mxpyVT1dmafmMt2Onh6XsYUgCuuAFOkhg0hUB3ems 7NPawURj6PYDYxnbpt/qTJiKbWM6CCkPDHrHesoY/ONvCeGaxzIytaUwXJ/mi3ws36hJXSST Nfyo2W5SskPJvGyn06KXr9YMW9IyZ4AV1pIs2iJ6T1rUXlXpxZ63BMY8Ja8r58Zg5+0cOaBr IAtMCo2aPsfChHEBc3m7XBCfM8yNtvzex8SCVLa/pOVXbKmXKbseInpdtP+3EM1p3R/PjBvK bvsyesk90F6+zsyVu46JVCyqrN3RGGyZCdicFHIPfqzUAnuFIOlUYSDwqvJXMwT5XcZ1jvNR eUvYwqpIJJYumoL3V5SFu434Wu81vMLeFPEccgLW4tbqpckBdbwP8GaPVmgnCWsQhcO9KUDE bnL4nO4lNPgz94dmb579BLsoAH5VVNQONyBEBxeiQBsK3DebwCmQha3qunRc4VUJQlZm/if4 lBdkNMavABEBAAGJAjwEGAEKACYCGwwWIQRv8uWfAMa8KDHYZMERc8sZmAixUwUCXWO7jQUJ CpaUJQAKCRARc8sZmAixU/kkD/9mfz2gjhb+XC1m0yUEQUhYCWxGZ/Z+9GXp9V1Fe9zvwNzf jlhqrG/3oRvWBKeW+Fr3UNrN41R8l0MuZBFACdDzWq3cQi4EnIxmkpJ4BQAnnnhc2o+eeMLw E3arpSo/mc4MWZFyyjbw3NYOeUuEvDtO4T5bnaESIkuWDfNW4D6Q8higZmaAPt25H/poyl4G +ikZzaJQDdTSciAGj8osApddLEeeDZwzef5VKu0HVLpB66NYlEHFiBi5ns2e5qbIN4G4NHXq /TJNn/pfMsyax/1VWJ6hOgQ7dC2F8wVNZBXZ10K0c1DWLwsJX28EiLvENc2+I8muwtv26Sbm 8G7Heq3hSXXPEQk3yCMdB9AsgUYe3Mik2OtdVicVziHd4/Lurj4Kpl7vWGE/2hX1MFVstbl9 dn0MKR0THCRW/BOLn6L3ssNbuanr5KAm/SlyFJOn1dmwE6b+HwLSEr0KS45vZdClG/ZTklEL rUDqhi2aeQE3tBeyzEatcU1JogP7p0FmVkPph28x0VBRHVYgePQiMz+V0YX3hnDQEmKidTVs huBSfPoVjeYwMnPAy2OUimtz6Arnd7GkPFVVQmTIj4c2uX6kPOnV0ZY7a4YjtlUjHN0HXXj4 Z5oxaCT/vqoqOQsIJmcegq1MSs3uNv9kiMdtjnrP/cbZRSCHOgoaEJTgQq/o0g== Organization: Denx Software Engineering Message-ID: <3c2c06e2-7cf3-35c1-f906-80cf2d2e2050@denx.de> Date: Tue, 17 Sep 2019 09:14:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190916104607.7142b22e@md1za8fc.ad001.siemens.net> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mYLyIHBgiWuKzPiHjWTINn4UjE0zPVBF9" X-TUID: lnhqEJpdcFxf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mYLyIHBgiWuKzPiHjWTINn4UjE0zPVBF9 Content-Type: multipart/mixed; boundary="Dm4I9EJo7zFd8CkndyLDVYi36qpeQaIzB"; protected-headers="v1" From: Claudius Heine To: Henning Schild , Jan Kiszka Cc: isar-users , Cedric Hombourger Message-ID: <3c2c06e2-7cf3-35c1-f906-80cf2d2e2050@denx.de> Subject: Re: [PATCH] linux-custom: Control linux-libc-dev deployment manually References: <0600904d-7f34-875f-6bcf-6fbbfe8b9933@siemens.com> <20190916102742.284e1838@md1za8fc.ad001.siemens.net> <3ea40d5b-daab-f6a6-6bc8-c14b11a49a91@siemens.com> <20190916104607.7142b22e@md1za8fc.ad001.siemens.net> In-Reply-To: <20190916104607.7142b22e@md1za8fc.ad001.siemens.net> --Dm4I9EJo7zFd8CkndyLDVYi36qpeQaIzB Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi, On 16/09/2019 10.46, Henning Schild wrote: > Am Mon, 16 Sep 2019 10:32:19 +0200 > schrieb Jan Kiszka : >=20 >> On 16.09.19 10:27, Henning Schild wrote: >>> Am Tue, 10 Sep 2019 20:07:11 +0200 >>> schrieb Jan Kiszka : >>> =20 >>>> From: Jan Kiszka >>>> >>>> Deploying a version of linux-libc-dev that is different from the >>>> one Debian uses easily causes problems. We already ran into those >>>> when doing a downgrade, but we can also create deadlocks when >>>> doing an update. The latter happens in common cross-build >>>> scenarios when pushing a new version for the target arch but not >>>> providing one for the builder. >>>> >>>> Avoid such troubles my making the package deployment opt-in. In >>>> most cases, we will not depend on such an update because we will >>>> rarely exploit new kernel API in userspace packages. >>>> >>>> We can revert this behavior once we support building packages for >>>> both target and host. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> meta/recipes-kernel/linux/files/build-kernel.sh | 7 ------- >>>> meta/recipes-kernel/linux/linux-custom.inc | 7 +++++-- >>>> 2 files changed, 5 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh >>>> b/meta/recipes-kernel/linux/files/build-kernel.sh index >>>> 8b7b23b..7b651af 100644 --- >>>> a/meta/recipes-kernel/linux/files/build-kernel.sh +++ >>>> b/meta/recipes-kernel/linux/files/build-kernel.sh @@ -127,10 +127,3 >>>> @@ rm -f linux-image-${PV}_${PV}-1_*.deb fakeroot dpkg-deb -b >>>> "${REPACK_LINUX_HEADERS_DIR}" \ >>>> linux-headers-${KERNEL_NAME}_${PV}-1_${KERNEL_NAME}.deb rm -f >>>> linux-headers-${PV}_${PV}-1_*.deb - >>>> -# linux-libc-dev causes dependency problems if we downgrade >>>> -# remove it after the build so the downgraded version does not get >>>> deployed -LINUX_LIBC_DEV_V=3D$( dpkg-query --show --showformat >>>> '${Version}' linux-libc-dev ) -if dpkg --compare-versions >>>> $LINUX_LIBC_DEV_V gt $PV-1; then >>>> - rm -f linux-libc-dev_${PV}*.deb >>>> -fi >>>> diff --git a/meta/recipes-kernel/linux/linux-custom.inc >>>> b/meta/recipes-kernel/linux/linux-custom.inc index c045b89..e75eed1 >>>> 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc >>>> +++ b/meta/recipes-kernel/linux/linux-custom.inc >>>> @@ -26,6 +26,8 @@ KBUILD_DEPENDS ?=3D "build-essential:native >>>> libssl-dev libelf-dev bc git kmod biso KERNEL_DEBIAN_DEPENDS ?=3D >>>> "initramfs-tools | linux-initramfs-tool, kmod, linux-base (>=3D >>>> 4.3~)" KERNEL_HEADERS_DEBIAN_DEPENDS ?=3D "libc6, libssl1.1" >>>> +KERNEL_LIBC_DEV_DEPLOY ?=3D "0" >>>> + >>>> do_install_builddeps() { >>>> dpkg_do_mounts >>>> E=3D"${@ bb.utils.export_proxies(d)}" >>>> @@ -61,7 +63,8 @@ dpkg_runbuild() { >>>> export >>>> KERNEL_HEADERS_DEBIAN_DEPENDS=3D"${KERNEL_HEADERS_DEBIAN_DEPENDS}" >>>> sudo -E chroot --userspec=3D$( id -u ):$( id -g ) >>>> ${BUILDCHROOT_DIR} ${PP}/build-kernel.sh ${PP}/${PPS} >>>> ${DISTRO_ARCH} >>>> - if [ ! -f ${WORKDIR}/linux-libc-dev_${PV}*.deb ]; then >>>> - bbwarn "Kernel downgrade detected, not deploying >>>> linux-libc-dev" + >>>> + if [ "${KERNEL_LIBC_DEV_DEPLOY}" !=3D "1" ]; then >>>> + rm -f ${WORKDIR}/linux-libc-dev_${PV}*.deb =20 >>> >>> Maybe keep that warning in an else ... "not deploying since >>> KERNEL_LIBC_DEV_DEPLOY=3D0" =20 >> >> I don't see the point in this warning. It suggests that you do want >> to deploy, which is actually not true. >> >>> >>> And Claudius always suggest to stay away from such boolean variables >>> and use arrays instead. That is easier to layer with "random" layer >>> prios. =20 >> >> Can you refer to an example? >=20 > I could look one up. Do you want a code-example or a quote from > Claudius? Just put him on cc, he can probably explain it without going > through some ml archives. Not sure about the issue with the layer priorities, but my point about preferring a small number of feature array instead of many boolean options are more in terms of usability from programmer and user perspective, that they are easier to document and more in line with what people coming form OE/YP are used to. regards, Claudius --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --Dm4I9EJo7zFd8CkndyLDVYi36qpeQaIzB-- --mYLyIHBgiWuKzPiHjWTINn4UjE0zPVBF9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAl2Ah+sACgkQEXPLGZgI sVPcpxAAu3JPjgkkvEISbArt6KP1kXAM0DwciVZYgjLkxK/IK0FGTA0Wq5NpNF8P cYln9tY9Dz708XLJCgABRj5OamW9YnCorfO0UaYk2EN0fy9ajE4s7JIslLvyYcCF pXw8ao/45hjZVszn26poYt2k+eyIe2aK514fgzBeRRQy3mQbDDpBeImCIcuu9nEG 8PNBTfj88098mltWTTKWhHVP8fneZsBiNFZdJFw2brLlNycsFgL/xA3dHHjQYEgL ha/B3lz7qoANbhsB9q0MVruh0ogxvNu90aa5Vp0HayHapH/eWr4rxbN4S/YbyOmT JKc/496fMlQK1CE5JRkhCRrxXPidVpeoi94diY6lxl0GSl8K+yLOGNcXjmmpjOv+ bA2dpiWC0UfDugvenHKyy16Di5m7znvDw7FYgOt1T31XpUS0X/loKm5F7x/SeoNQ c+3KPYosHo+KaDKDSOYJfEWOYHHtgxWpzaJarPV8O9k9JwOfzQDP6r7LaUmFWaWh XtZxfDuH1eXEwr5QU/D7Fk/dm8E8gq1DzsF+GNbHt8/0z0aT10HXBwRKEXlK9OX6 ETPcAnY4nl9ZFU0nrUOIgvGGTVcnr3DmIJ0OnGe/KwVs+M/cGmUxji9lMBdGFAXE oDKjq6FYPph7UtNCLbGLv3faPmgM8LysRGqkqt5bzwhdP+x1zEM= =fCzZ -----END PGP SIGNATURE----- --mYLyIHBgiWuKzPiHjWTINn4UjE0zPVBF9--