From: Jan Kiszka <jan.kiszka@siemens.com>
To: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>,
isar-users@googlegroups.com
Cc: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
Subject: Re: [PATCH v2] linux-custom: Install config and map file to /boot
Date: Mon, 23 Mar 2020 07:12:00 +0100 [thread overview]
Message-ID: <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com> (raw)
In-Reply-To: <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com>
On 18.03.20 14:21, Vijai Kumar K wrote:
> Align with upstream debian linux-image package. Install the config and
> System.map file to /boot directory. Skip installation for User Mode Linux.
>
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
> Changes in v2:
> - Moved um condition check as per Henning's comment
>
> .../linux/files/debian/isar/install.tmpl | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> index 12d592d..849da5e 100644
> --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> @@ -37,6 +37,10 @@ do_install() {
> set -x
>
> install_image
> + if [ "${ARCH}" != "um" ]; then
> + install_config
> + install_map
> + fi
> install_hooks
> install_dtbs
> install_kmods
> @@ -69,6 +73,14 @@ install_image() {
> install_image_debug
> }
>
> +install_config() {
> + cp ${O}/.config ${deb_img_dir}/$(dirname ${kimage_path})/config-${krel}
> +}
> +
> +install_map() {
> + cp ${O}/System.map ${deb_img_dir}/$(dirname ${kimage_path})/System.map-${krel}
I think those cp calls should be install with proper modes, no?
Jan
> +}
> +
> install_image_debug() {
> # Different tools want the image in different locations
> # perf
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2020-03-23 6:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 17:14 [PATCH] " Vijai Kumar K
2020-03-17 17:19 ` vijai kumar
2020-03-17 17:39 ` Jan Kiszka
2020-03-25 7:07 ` cedric_hombourger
2020-04-03 7:28 ` vijai kumar
2020-04-03 7:29 ` vijai kumar
2020-03-17 17:32 ` Jan Kiszka
2020-03-18 5:53 ` vijai kumar
2020-03-18 7:34 ` Henning Schild
2020-03-18 13:03 ` vijai kumar
2020-03-18 13:21 ` [PATCH v2] " Vijai Kumar K
2020-03-23 6:12 ` Jan Kiszka [this message]
2020-03-23 6:53 ` Henning Schild
2020-03-23 6:55 ` Jan Kiszka
2020-03-23 7:49 ` vijai kumar
2020-03-23 9:13 ` Henning Schild
2020-03-23 9:24 ` vijai kumar
2020-03-23 10:40 ` Henning Schild
2020-03-23 13:40 ` [PATCH v3 1/2] " Vijai Kumar K
2020-03-23 13:40 ` [PATCH v3 2/2] meta/recipes-kernel: Replace cp with install Vijai Kumar K
2020-04-17 15:05 ` [PATCH v3 1/2] linux-custom: Install config and map file to /boot Baurzhan Ismagulov
2020-04-17 18:44 ` vijai kumar
2020-04-17 18:59 ` vijai kumar
2020-04-20 9:28 ` Baurzhan Ismagulov
2020-04-20 10:07 ` vijai kumar
2020-04-20 16:03 ` Baurzhan Ismagulov
2020-04-20 19:46 ` Henning Schild
2020-04-20 19:51 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=Vijaikumar_Kanagarajan@mentor.com \
--cc=isar-users@googlegroups.com \
--cc=vijaikumar.kanagarajan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox