From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6805226701613694976
X-Received: by 2002:a2e:3002:: with SMTP id w2mr12983290ljw.82.1584943926047;
        Sun, 22 Mar 2020 23:12:06 -0700 (PDT)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:ac2:41d5:: with SMTP id d21ls1836712lfi.11.gmail; Sun, 22
 Mar 2020 23:12:05 -0700 (PDT)
X-Google-Smtp-Source: ADFU+vtVhLYsBGPXkVRqK9LSQCwYk2j8cYZYZ1Q1FOkiqsmip9zZHFSN0klGRJn8JZao7Qmcho73
X-Received: by 2002:a19:c388:: with SMTP id t130mr10018949lff.175.1584943925218;
        Sun, 22 Mar 2020 23:12:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1584943925; cv=none;
        d=google.com; s=arc-20160816;
        b=NBRcZRuWMNUiXycuPngF1RPx6xOuT1XpnXLuT50XDtSa6TTja5B/Ny6M24XSfyf2CV
         pS1xBdvCFcZqYdN5ihs/Lknzz9fZ9RPRo6yPgECvQXSp83QZl1n+YDveH8WpUwhDh+sf
         drzFi/GJDWScdjljBXDtvK3YRSyxI0hyvF0wNWGsT3D96Km9k3tysrgrUQLUcgFnrqPq
         eAoa079kdh7n/N8eXaU5LtiSWRDewe+s+LAd568HcAS12GTY0Pe7YREzSKVOn6HqXkro
         c9Ub7uR74tGcqGk/MqVw87OrFxpmR3sc6T9TDgYRMCuSELrXJUzfSvNO3LzpuwXIse90
         /IcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:content-language:in-reply-to:mime-version
         :user-agent:date:message-id:from:references:cc:to:subject;
        bh=fpeN0W/tuBqTMQhDrMDFsvpsgFxFeBaB/QgMyAAN9eo=;
        b=quu51t5wXTzwLx8At8vsrwh3V7rduquU07xjQMsCZu5lZhcrSgQEEXueO7sVL4rN4G
         qz2jRo1nZw9h78+tAGPbaTV1iQ4q1aXVxXKalRuzXZclCr9TedJYqMlCCgOGwW0grTOG
         6ZAtE5enVjc0jiyR2RQk+lUQZuJbeD0mv04IZuWJ8uwxrdJ8Zkxo3e+2PZIjRxoqwbgq
         MmkKKo++GQUJdRvhnBZCe5dYjlO0i/fdUIKbZZzZ2RsLrvwtCihIjdv6PEBZDwqnVxhK
         cRLc60mGAQd9hRC0tktpvgRcrsYfsLaNwrbU+aT8T57NoYBL0a3FzA+Z6ztHkGtwAKKv
         ivPA==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com
Return-Path: <jan.kiszka@siemens.com>
Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2])
        by gmr-mx.google.com with ESMTPS id d12si768349lfi.2.2020.03.22.23.12.05
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Sun, 22 Mar 2020 23:12:05 -0700 (PDT)
Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2;
Authentication-Results: gmr-mx.google.com;
       spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com
Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66])
	by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 02N6C3ij024881
	(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Mon, 23 Mar 2020 07:12:04 +0100
Received: from [139.21.64.131] ([139.21.64.131])
	by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 02N6C1nN027578;
	Mon, 23 Mar 2020 07:12:02 +0100
Subject: Re: [PATCH v2] linux-custom: Install config and map file to /boot
To: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>,
        isar-users@googlegroups.com
Cc: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
References: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net>
 <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com>
Date: Mon, 23 Mar 2020 07:12:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-TUID: lSfc9PPXPoys

On 18.03.20 14:21, Vijai Kumar K wrote:
> Align with upstream debian linux-image package. Install the config and
> System.map file to /boot directory. Skip installation for User Mode Linux.
> 
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
> Changes in v2:
>      - Moved um condition check as per Henning's comment
> 
>   .../linux/files/debian/isar/install.tmpl             | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> index 12d592d..849da5e 100644
> --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> @@ -37,6 +37,10 @@ do_install() {
>       set -x
>   
>       install_image
> +    if [ "${ARCH}" != "um" ]; then
> +        install_config
> +        install_map
> +    fi
>       install_hooks
>       install_dtbs
>       install_kmods
> @@ -69,6 +73,14 @@ install_image() {
>       install_image_debug
>   }
>   
> +install_config() {
> +    cp ${O}/.config ${deb_img_dir}/$(dirname ${kimage_path})/config-${krel}
> +}
> +
> +install_map() {
> +    cp ${O}/System.map ${deb_img_dir}/$(dirname ${kimage_path})/System.map-${krel}

I think those cp calls should be install with proper modes, no?

Jan

> +}
> +
>   install_image_debug() {
>       # Different tools want the image in different locations
>       # perf
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux