Re: [PATCH 1/1] refactor: use to_boolean when comparing boolean vars

[Uladzimir Bely <ubely@ilbers.de>]

On Wed, 2024-02-21 at 10:33 +0100, 'Felix Moessbauer' via isar-users
wrote:
> When comparing user-defined boolean variables (e.g. ENABLE_<FOO>),
> a comparison against the string "0" or "1" is error-prone, as the
> user
> might use other strings which also denote True / False. For that,
> bitbake offers the bb.utils.to_boolean function.
> 
> This patch refactors all these patterns which are in scope of ISAR.
> The parts which are copied from OE are not touched, as well as the
> WIC
> plugins.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta-isar/recipes-app/hello/hello.bb                        | 2 +-
>  meta/classes/base.bbclass                                   | 6 +++-
> --
>  meta/classes/compat.bbclass                                 | 2 +-
>  meta/classes/crossvars.bbclass                              | 4 ++--
>  meta/classes/dpkg-base.bbclass                              | 6 +++-
> --
>  meta/classes/imagetypes_container.bbclass                   | 2 +-
>  meta/classes/imagetypes_wic.bbclass                         | 4 ++--
>  meta/classes/multiarch.bbclass                              | 2 +-
>  meta/classes/patch.bbclass                                  | 4 ++--
>  meta/classes/sdk.bbclass                                    | 6 +++-
> --
>  meta/conf/bitbake.conf                                      | 2 +-
>  meta/recipes-bsp/u-boot/u-boot-custom.inc                   | 4 ++--
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc         | 6 +++-
> --
>  meta/recipes-devtools/sbuild-chroot/sbuild-chroot-target.bb | 2 +-
>  meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc       | 4 ++--
>  meta/recipes-kernel/kselftest/kselftest.inc                 | 2 +-
>  meta/recipes-kernel/linux/linux-custom.inc                  | 2 +-
>  17 files changed, 30 insertions(+), 30 deletions(-)

Applied to next, thanks.