public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] wic: plugins: Improve rootfs-u-boot script_prepend passing
Date: Tue, 8 Jun 2021 09:47:08 +0300	[thread overview]
Message-ID: <3c95cc11-9b7b-90d8-60f0-cb2f4e36d401@ilbers.de> (raw)
In-Reply-To: <185f97a0-6755-1344-43cd-7df51040ba65@siemens.com>

08.05.2021 15:43, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Passing a script_prepend value down to the generated boot.scr currently
> requires double escaping: once for the wks file when being parsed by
> wic and a second time for /etc/default/u-boot-script when being parsed
> by the u-boot-script tool.
>
> This removes the need for double escaping by detecting if the " or $
> characters are already escaped after the wic parsing step. If not, the
> plugin injects the required escape character.
>
> In addition, this provides a way to avoid the wic warning about an
> unknown (bitbake) variable when injecting ${some_var} into the script:
>
> do_wic_image: WARNING: cannot expand variable some_var
>
> The user can now simply escape the curly braces as well: $\{some_var\}.
> The plugin will remove these escapes before generating the u-boot-script
> configuration file. This also resolves the more theoretical case of a
> naming clash between a WICVAR and a U-Boot script variable.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Applied to next, thanks.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov


      reply	other threads:[~2021-06-08  6:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08 12:43 Jan Kiszka
2021-06-08  6:47 ` Anton Mikanovich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c95cc11-9b7b-90d8-60f0-cb2f4e36d401@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox