From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6959899212283641856 X-Received: by 2002:a05:600c:c9:: with SMTP id u9mr20053123wmm.156.1623134835967; Mon, 07 Jun 2021 23:47:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1d0e:: with SMTP id l14ls768176wms.1.canary-gmail; Mon, 07 Jun 2021 23:47:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqa8rELJWMy9w/BOzqjzh1uDFIg4kYOQgNgmktXIDSgvUWwcIHDIDq37psy/c4gfgMZHPR X-Received: by 2002:a1c:770b:: with SMTP id t11mr2528744wmi.79.1623134835177; Mon, 07 Jun 2021 23:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623134835; cv=none; d=google.com; s=arc-20160816; b=vi3BUrYSBuKPWBEjOAYlpBYgsbDX7exCCLido8QNUg2+S4NTYgj9l1FlhdI7G2+abI Fg1XdMysAC3hgaFzGWfLn3/hRzece6++3JG5MH/ij6S96uqTpoaG0aMAoeriPXkbYVIH qbXqjrDhleIYkA0oTJjJXrCOWTvrLG/3NpHFQ2XMLOlDBxInZ8Ywbg/5bO80a9Ebgqp4 w1qWBd/vF+OPoW+hHfdqTv/vjHs0sKTU2R+KTlT9EdZ7QzVIG+NTCQ/6BV7KgJov+GvS hzb7loL6IKNbMS8eJ12uhhod6pUGgsEfJe1rsyAWTGBDAJYmiTUb2fF5yQ7O6jB5//5y AhQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=b/nJl8TR0+Yyvi300qOGIJBrA0nUGDBcahU9ULJ+n0E=; b=iA84a/jRqMVh95E6MvLdJ//I1idXI3nY8ZKtmXF/qHmU7tCYA355DC3RDIoGPC9Y13 wSXxVxIRK6yHPDlSQea6W4wqboCWCzrtL2i4Nf8nRmtaPdGqcVRw0L/l3XtcQ05qdblJ GkLkjdYzGVUmd1eJQoRaWIJtI0OAGUQmQkp2Bp+EqXSmYjOqOXYK5C2pqD2+0NdwEGSO V0qh4JtDCn1T/N2Ucw6C3kXr6hSXiXTPaiU7srzpx94H5Oe+cvlqvCXWR/qBsSa9aRSr Eg5vnPizo0ZxwIVWW3irzV0UHAeZ+PgW/46u/qRw29TesSQRFgkcdZ7zb8+moZjj3nZ9 Eu8Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id k18si127700wmj.0.2021.06.07.23.47.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Jun 2021 23:47:15 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-141-65-214-37.mgts.dynamic.pppoe.byfly.by [37.214.65.141] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1586lDX4004463 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Jun 2021 08:47:14 +0200 Subject: Re: [PATCH] wic: plugins: Improve rootfs-u-boot script_prepend passing To: Jan Kiszka , isar-users References: <185f97a0-6755-1344-43cd-7df51040ba65@siemens.com> From: Anton Mikanovich Message-ID: <3c95cc11-9b7b-90d8-60f0-cb2f4e36d401@ilbers.de> Date: Tue, 8 Jun 2021 09:47:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <185f97a0-6755-1344-43cd-7df51040ba65@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: zJj6l8IlP50Z 08.05.2021 15:43, Jan Kiszka wrote: > From: Jan Kiszka > > Passing a script_prepend value down to the generated boot.scr currently > requires double escaping: once for the wks file when being parsed by > wic and a second time for /etc/default/u-boot-script when being parsed > by the u-boot-script tool. > > This removes the need for double escaping by detecting if the " or $ > characters are already escaped after the wic parsing step. If not, the > plugin injects the required escape character. > > In addition, this provides a way to avoid the wic warning about an > unknown (bitbake) variable when injecting ${some_var} into the script: > > do_wic_image: WARNING: cannot expand variable some_var > > The user can now simply escape the curly braces as well: $\{some_var\}. > The plugin will remove these escapes before generating the u-boot-script > configuration file. This also resolves the more theoretical case of a > naming clash between a WICVAR and a U-Boot script variable. > > Signed-off-by: Jan Kiszka Applied to next, thanks. -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov