Re: [PATCH 2/2] ci_build: Introduce REPRO_TARGETS_SET

[Claudius Heine <claudius.heine.ext@siemens.com>]

On 23/05/2019 14.46, Maxim Yu. Osipov wrote:
> On 5/23/19 2:38 PM, Claudius Heine wrote:
>> Hi,
>>
>> On 23/05/2019 14.34, Maxim Yu. Osipov wrote:
>>> On 5/23/19 2:27 PM, Claudius Heine wrote:
>>>> Hi Maxim,
>>>>
>>>> On 18/05/2019 13.11, Maxim Yu. Osipov wrote:
>>>>> Use minimal targets set to test local apt repo caching feature
>>>>>
>>>>> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
>>>>> ---
>>>>>   scripts/ci_build.sh | 11 ++++++++++-
>>>>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
>>>>> index ae9f5c9..9d370ac 100755
>>>>> --- a/scripts/ci_build.sh
>>>>> +++ b/scripts/ci_build.sh
>>>>> @@ -34,6 +34,10 @@ TARGETS_SET="\
>>>>>             # qemu-user-static of <= buster too old to build that
>>>>>             # multiconfig:qemuarm64-buster:isar-image-base
>>>>> +REPRO_TARGETS_SET="\
>>>>> +            multiconfig:qemuarm-stretch:isar-image-base \
>>>>> +            multiconfig:qemuarm64-stretch:isar-image-base \
>>>>> +            multiconfig:qemuamd64-stretch:isar-image-base"
>>>>
>>>> What is probably missing here a 
>>>> 'multiconfig:qemu*-buster:isar-image-base' target.
>>>>
>>>> At least after my current base-apt patchset it should be possible to 
>>>> build stretch and buster in the same build environment.
>>>
>>> Would be great.
>>> Are you going to send the next version of your series (w/o ci patches 
>>> from v1 series)? If yes - please add patch to ci_build.sh updating  > 
>>> REPRO_TARGETS_SET with qemu*-buster targets.
>>
>> Will do, but will first run the CI on them again.
> 
> OK, thanks.
> 
>> In principle we could also add rpi-stretch if cross-build is not enabled.
> 
> I fear that this will not work for the 'fast' build as it enables cross 
> compilation (f.e. "fast" favor Jenkins projects launch now 'ci_build -q 
> -f -r').
> 
> 
> BTW, is your series addresses the question you posted yesterday
> https://groups.google.com/d/msgid/isar-users/54843fa8-16ea-195c-4ffa-8ec10fa9246c%40siemens.com 
> ?
> 
> Honestly, I've not yet read it carefully.

Yes. My solution is now to have a separate repository for each ${DISTRO}.

We should probably have to take a closer look at base-apt and the 
population process soon. And think about a improved design that supports 
multiple repositories and code names. But this patchset should just fix 
the issues I encountered.

Claudius


-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de