From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7068549159628832768 X-Received: by 2002:a05:6808:1a22:b0:2d4:f7a6:3d1d with SMTP id bk34-20020a0568081a2200b002d4f7a63d1dmr2185814oib.95.1645810216450; Fri, 25 Feb 2022 09:30:16 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a9d:4602:0:b0:5ad:3c9b:886f with SMTP id y2-20020a9d4602000000b005ad3c9b886fls1045420ote.1.gmail; Fri, 25 Feb 2022 09:30:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJxp/A25Ek6cm49sFnQSlOSUGG1RzI9uyGeFEcNqbaloOUGr0/M1wXq1EckKmR/totASAUhZ X-Received: by 2002:a9d:5a06:0:b0:5af:b5fd:5b72 with SMTP id v6-20020a9d5a06000000b005afb5fd5b72mr3079139oth.200.1645810215964; Fri, 25 Feb 2022 09:30:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1645810215; cv=pass; d=google.com; s=arc-20160816; b=IdU8ezIjv0lCtgPERuiCHQ+FHiIzYCZgDKaWjrWzsjdDOxkt6++YUBXJihtnIIxcYY C3TJTuoISucy6nvDaeHftTHw39Cmkc4QNBsmMJpx/TvhdMGjh6qDkpDNqtqKqHUqZmmq AMVC5eIICwMZKXi4JMM2iqBiIgjsWsNTHg9rG4rWspd7i4bvC+saifNaDo5w6qFrkFPr 0yrSvUSUIFaaroqfOiFlo5hp1u+rgZg5BEHwo3v36zV+9oHOTPF2R62N4gdTsfV7xqVP gsjjhMf1bw4yUYFXHXgJrNL+xq6LLWPUpXAnvXU74S6qJu5+/fBwhPZmWMMMCnHKti5Z yycw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=57wErIZwAuace03xbxvTXnynn4bb7aqJxgtN/L+Mja4=; b=WY3FASxeG8FqcfcurPSXity0tuoIYvNFrwVW1AFG7U+cThmLm0S7aMVSbxhImHUKXE WG9nmUkKgNGdXVSwQPzCJhVs+yj9KAEU6TA3lc1QZ5HugZEZ44BOZ2Fb9HiWDWrx5Top UWZwvKPrNwkIDDhU9ziMoTAlmwDl475hPn1u+kpi7uvu6m+y8Y3WT7kD4Et9VtxNVssC +RDMSp6EbENAoTgq20Jr3R21TD/6PmkJ9vbs8Gl2DmVU68OE9AdtIfDIKgwo18zXIWZb 8qHe5/xpOPZ6qp41whf0rVhRyT1SeJoewLBFFdPLvGBQLwURUdeKLLuFo4xJMZtsogUi 4uBA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=bao12c8s; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe1e::62d as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on062d.outbound.protection.outlook.com. [2a01:111:f400:fe1e::62d]) by gmr-mx.google.com with ESMTPS id 22-20020a05687011d600b000bad0134c99si433229oav.0.2022.02.25.09.30.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Feb 2022 09:30:15 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe1e::62d as permitted sender) client-ip=2a01:111:f400:fe1e::62d; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=bao12c8s; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe1e::62d as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WKGC78rCOU+xOAk3uuRqTlt5aa7XiJ2i+gvnFiQjLpE72Q1A0mKGt3pXujsbA2yHpoh7scryCBNqaCJ7MmNXq+c2UlF+PRY29l9rpjhdrrxUcG4zB8gtirAYRl4gJfaV5bI8ea19XvBoMQ4rn+23bOQpkdxymbn4UkqXbfynsE0lTl6nyXXmL9h+tEaej7V59fcJXwqwNZjVT3cub76Ge6MOnPDawGVCwB3XPgJxWnh04KctgGNYrRvkgKhW6H3xn4VvDGbPVOT4hu1QCX33eF534itM7vP4eZc+jF+o9FJBzi2fcySnP9JpWLksOvK7h1xjcAOGPEDPfrVP2hreJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=57wErIZwAuace03xbxvTXnynn4bb7aqJxgtN/L+Mja4=; b=LeF60x0Nhcpl1UlC3N5Xu7kqcUeDs967Z1eOpViFyPgXk7SclxgYooAu3PWFG0aib6Gi3jLhYDrasdZ+tzyGrMN0vokJAKdKORYldQ2OMp4kyvi0Z5OzAHlkbFikQG1SC/T8H0Ewytv8MvjlQL0oGPXAksuVLq47iRsrb7NVxIHDnG20fNI6QIcTsSgh8MWEguLt1a4bV5O1voIr0ztkmFTG9DBso3mf1HdrW/6qvRRQpcmpeR869HVUF7PweA0vRa09W+5Yk5VcR8t8kKInpHd/WCZSxTw0ycroiCPrStPrBYB+bLOyCdZP6pCw6UR6Mf2fz8QBoF35mXjc1Yc5Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.70) smtp.rcpttodomain=ilbers.de smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=57wErIZwAuace03xbxvTXnynn4bb7aqJxgtN/L+Mja4=; b=bao12c8sa+0//CYjKBLjzv1bmNHOyTYCKdbO1TadQrXNh00y8aTf4xet6M6hSQxD7JoV76Ns+57pREmr9p9/DOofYS9C6vPjwKuFUr7ci4yBvDW3ydvWQebFj+/rh3I2O0XdO2JRJ0k+1li7a+bjkBBvAG8byfOlBadYgDRrZE+2FfQ9fz0dfC1FpHunwCqO1vAzBAAYK71xq1Y7DFiI2m9VB0CF/6Nvrb4c/bAgu7+UW0a8+Nj0lRdLnE8PzNPNLYlWcePwawG5rP7/16CHqQr1T2JxCyyXeB3HCJW31CdUPs1bacNLBtZRK9PkGLXdB3YeDuhlh7l9X54OHVPVQw== Received: from OL1P279CA0045.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:14::14) by PAXPR10MB5133.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:218::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 17:30:13 +0000 Received: from HE1EUR01FT023.eop-EUR01.prod.protection.outlook.com (2603:10a6:e10:14:cafe::29) by OL1P279CA0045.outlook.office365.com (2603:10a6:e10:14::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21 via Frontend Transport; Fri, 25 Feb 2022 17:30:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.70) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.70 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.70; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.70) by HE1EUR01FT023.mail.protection.outlook.com (10.152.0.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5017.22 via Frontend Transport; Fri, 25 Feb 2022 17:30:13 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SJA.ad011.siemens.net (194.138.21.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 25 Feb 2022 18:30:12 +0100 Received: from [139.22.139.122] (139.22.139.122) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 25 Feb 2022 18:30:12 +0100 Message-ID: <3e6ee8a2-c998-e174-f386-3c6e5a382876@siemens.com> Date: Fri, 25 Feb 2022 18:30:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [RFC 1/5] dpkg-base: Cover do_apt_unpack task by lock Content-Language: en-US To: Anton Mikanovich , References: <20220225074040.20975-1-amikan@ilbers.de> <20220225074040.20975-2-amikan@ilbers.de> From: Jan Kiszka In-Reply-To: <20220225074040.20975-2-amikan@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [139.22.139.122] X-ClientProxiedBy: DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0678803c-ce49-4ea7-7421-08d9f8847b0c X-MS-TrafficTypeDiagnostic: PAXPR10MB5133:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gtpgLtsuX86hew8GUMG1luA+TNewHH67V5Jn9PfX08Wt13YD1bw3zoaNvn0WXw4b309785FTU03bWAv2aizHkK6HUpAlT+DKe7OLO2+MbyHY6UHooUoVm8J/78ajfJLAKsNgD22eyjiVwRFTyLr0yMSSBHpH5J2IisnIDf5m3oEYlEF2Yqb0SoF6eCwcEGxd+MdiseE14f4YWd4OHaovGt9vRaTt/9L2pnq9ybWu0xfGpNee7YKSI7IYQDHo3b9K0fCcB4mcCjH1Jho9j/kQe8idSAsGDRSpWFZExHAUECH43rynNKxxA5oe9o2DQD8Dec0A+KjIkZ01euGUlSE85Q/N78ENoSiVn/3JZFTXg+EUnlsaAMdgxWAEXLfXrye4SoEzWZKl1/ltcZFnalRH09EXhDVnH/ZpxVEGoX6yIIxm8xcar8vuKLZPYbBnMdL10FRPlOa2h41Nw9BguMRmpg9Ewr8ht++XtLUyPenGO0knmc4rr1B4LmVhGjLvVpHHvrcg5c57mQ01x8XLrbDjmtLocfoE/zZc4KF6dRmLzd9ZtZwQujjZeHFpoFbhRpV3O6E1BO9qdVgLQyjOU/v6zRAi2hpg6XTM9jxZivRID05Be1l69E5+APsxHircLjt9xrDglPixE0SxQgu2NE/oSPB+Au/R1leGYbr4telCq3tdJShq9jWvxSV+eGcvMjhhE6u/N4H78/UKk88UXGk35k33vnPkRXhZb43zaYCcJxk= X-Forefront-Antispam-Report: CIP:194.138.21.70;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:hybrid.siemens.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(36860700001)(31686004)(7596003)(6706004)(110136005)(47076005)(82960400001)(356005)(7636003)(508600001)(36756003)(82310400004)(5660300002)(53546011)(70206006)(8936002)(16576012)(44832011)(316002)(83380400001)(2906002)(956004)(16526019)(26005)(186003)(31696002)(40460700003)(86362001)(336012)(70586007)(8676002)(2616005)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 17:30:13.2647 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0678803c-ce49-4ea7-7421-08d9f8847b0c X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.70];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT023.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB5133 X-TUID: ihu3zBjHAXa8 On 25.02.22 08:40, Anton Mikanovich wrote: > After moving apt-get call from lock-protected do_apt_fetch to the > do_apt_unpack it should be also covered by isar.lock to avoid conflict. > Mind to tell us when this happened (Fixes: ...)? Did you see real problems? How often? All valuable information to assess the relevance and criticality for downstream possibly using an affected version. Jan > Signed-off-by: Anton Mikanovich > --- > meta/classes/dpkg-base.bbclass | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 928856a..e3ec133 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -142,6 +142,8 @@ do_apt_unpack() { > dpkg_undo_mounts > } > > +do_apt_unpack[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" > + > addtask apt_unpack after do_apt_fetch before do_patch > > addtask cleanall_apt before do_cleanall -- Siemens AG, Technology Competence Center Embedded Linux