From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6812695221159067648 Date: Tue, 1 Sep 2020 22:24:09 -0700 (PDT) From: "vijaikumar....@gmail.com" To: isar-users Message-Id: <3e7859c4-bbd3-4e90-95a7-b270b56dc70an@googlegroups.com> In-Reply-To: <20200901195313.GJ11779@yssyq.m.ilbers.de> References: <20200406201648.26945-1-henning.schild@siemens.com> <20200610172627.09cfb239@md1za8fc.ad001.siemens.net> <20200612065522.GP5077@yssyq.m.ilbers.de> <20200612200335.0ad5c340@md1za8fc.ad001.siemens.net> <20200901195313.GJ11779@yssyq.m.ilbers.de> Subject: Re: [PATCH 0/3] fix and test wic exclude-path MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_232_1291131518.1599024249758" X-TUID: v6hfCUBaa3AU ------=_Part_232_1291131518.1599024249758 Content-Type: multipart/alternative; boundary="----=_Part_233_896411153.1599024249758" ------=_Part_233_896411153.1599024249758 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Baurzhan, On Wednesday, September 2, 2020 at 1:23:23 AM UTC+5:30 i...@radix50.net wrote: > Hello Henning, > > On Fri, Jun 12, 2020 at 08:03:35PM +0200, Henning Schild wrote: > > > 1. I'd like to understand what exactly is failing when the fix is not > > > applied. > > > > You have the code for that. Just revert the fix and you will see. > > Fair enough -- just thought it would speed up things. > > > > > 2. The test case is failing with the fix applied. > > > > Just apply the changes and you will see ;). > > I meant that your patches started to fail in CI, see e.g. > http://ci.isar-build.org:8080/job/isar_ibr_devel_2_fast/12/consoleFull. > The > build succeeds, but start_vm fails due to init dying. > > The problem seems to be that Debian doesn't support operating without /usr > anymore. We can fix it by saving a backup of the image before generating > one > without /usr -- I'll send the updated patch. > My suggestion would be to exclude one of /srv /media instead of /usr. Since those might not be critical for the system to boot. > > > I'd be ready to apply this with the modification above. I see that the wic > series also touches this part but doesn't include the CI patch. What would > be > the preferred way? > > 1. Apply this, rework the wic series, OR > We could apply this and I can rework the wic series based on this. > > 2. Include the CI patch in the wic series and apply that. > Right now we are testing only --exclude-path which this series adds support for. For a comprehensive wic test, I was thinking to have a custom wks file which would have most of the options exercised and we could use some tools to validate whether the final image is as expected. It is something in my pipeline. Will try to work on it and send a patch as early as possible. Thanks, Vijai Kumar K > > With kind regards, > Baurzhan. > ------=_Part_233_896411153.1599024249758 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Baurzhan,

On Wednesday, September 2, 2020 at 1:23:23 AM UTC+5:30 i...@radix50.net wrote:
Hello Henning,

On Fri, Jun 12, 2020 at 08:03:35PM +0200, Henning Schild wrote:
> > 1. I'd like to understand what exactly is failing when the fix is not
> > applied.
>
> You have the code for that. Just revert the fix and you will see.

Fair enough -- just thought it would speed up things.


> > 2. The test case is failing with the fix applied.
>
> Just apply the changes and you will see ;).

I meant that your patches started to fail in CI, see e.g.
http://ci.isar-build.org:8080/job/isar_ibr_devel_2_fast/12/consoleFull. The
build succeeds, but start_vm fails due to init dying.

The problem seems to be that Debian doesn't support operating without /usr
anymore. We can fix it by saving a backup of the image before generating one
without /usr -- I'll send the updated patch.

My suggestion would be to exclude one of /srv /media instead of /usr. Since those
might not be critical for the system to boot.
 


I'd be ready to apply this with the modification above. I see that the wic
series also touches this part but doesn't include the CI patch. What would be
the preferred way?

1. Apply this, rework the wic series, OR

We could apply this and I can rework the wic series based on this.
 

2. Include the CI patch in the wic series and apply that.

Right now we are testing only --exclude-path which this series adds support for.
For a comprehensive wic test, I was thinking to have a custom wks file which would
have most of the options exercised and  we could use some tools to validate whether the
final image is as expected. It is something in my pipeline. Will try to work on it and send a patch
as early as possible.

Thanks,
Vijai Kumar K



With kind regards,
Baurzhan.
------=_Part_233_896411153.1599024249758-- ------=_Part_232_1291131518.1599024249758--