From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 25 Oct 2024 15:58:41 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-lj1-f190.google.com (mail-lj1-f190.google.com [209.85.208.190]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 49PDwT6Z023874 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 25 Oct 2024 15:58:30 +0200 Received: by mail-lj1-f190.google.com with SMTP id 38308e7fff4ca-2fb4994b3d0sf16253381fa.3 for ; Fri, 25 Oct 2024 06:58:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1729864704; cv=pass; d=google.com; s=arc-20240605; b=kfb7lVNlvuYMKAU6CWDf2bzc8bjuB1P7k7DJqbJ8P3OHNbiDAeiKRBfKqkqhTnJNr/ 9wHYZlP4gVgaNsFZDQ/APYWjlLvQLnQhRUeCffvfm+yn+YDBoySN5oDokP7BNFP2sa70 FxkqE26uA9xUQVvhggJgKpgBW+g6upm/GC2GFGHsQLQF80yGJHaX+Xp1xMxlDKnnwXI8 5AduNcEtvSsB5loED7CjJqPlRFzt0mOP6bTh/Nz73bNhciQ3qI/tBw8aY10wMYgFWr7g blkRfcyKjPpmLvME1owm4YkiGcOjXDTUy8EzSwuzr0NBeNR8HVHzvoBeQxCXzYhZNAPM fErA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:sender:dkim-signature; bh=RyVvan9EEwhYbKnBdzMY1rD+FeBZqhjAZuKsOkxNZhA=; fh=yzgv6edWnfdmL7oRnAjKFHrzQsRZAA1iDQqg5bMRLx0=; b=hwJ6hCjVaOUmCMHCaokb1eIfFo0YJ+5lfaR7sYMUtZXoShbUaKWLAlnAzV+9KAuTsQ Irxx+dd44iP7DH9i3KnCfI9xj/7LH7jeHU331sSI8cBn67o6/ZDiZjqf4mJOpjr/cNTR w6c6r7mNxczuq2x5+V1qSQ9Wloc0KjMx4y9sQ6yCgoy5IVjUmYdzbgb0kyB6nRbkJyzz zlST+vRGW7MEWzb2o6KVf+9/jsX4JyOgVz72qeteoafMpQd2l71sdgU84Yq+iDkKWeHJ vRBXQRuX6jesiIVjbhfSsjWtXLlHKMjjQmz8DGoCDP/+ep4oKPkXXtzkx0DKhw+MVMHw x9wQ==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1729864704; x=1730469504; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :references:in-reply-to:date:to:from:subject:message-id:sender:from :to:cc:subject:date:message-id:reply-to; bh=RyVvan9EEwhYbKnBdzMY1rD+FeBZqhjAZuKsOkxNZhA=; b=AHuqaAXoue6hTiRzVPvw3M29ilsg7CsSEtfjsworow0JedxFVvZo3i2LyrQfjkIF7W qVfYrlY9HnSYAvYJNwBi4tfLbQls/J4kBV+oEX39rbFHLl8ZpOzXYDq+DJbE+PX6rsy5 CbakLBfxTQTapABNfRIV5qID+FeMyLhf5mmIdJ+CXUcaDHz/uaxOb58jGko/ZEXKuLH6 b9JgRTiWWuSWfB/WHQ7j7PeX2RkSS/FZXHBMtkTlX0M1zMeP72Wqxv3WA70CBZaatnvk OgJFLQiCqmrJnVhNpLT1BJIg6kiVd7Gb3evSFiDr0YWc/mGzCCX2c1Mh5MUapgulzcOE A6Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729864704; x=1730469504; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:references:in-reply-to:date:to :from:subject:message-id:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=RyVvan9EEwhYbKnBdzMY1rD+FeBZqhjAZuKsOkxNZhA=; b=F9xsd1gDV+PCuazTevs0ugjckV9td1Ips8WqZCUhaUoVdRWu7oGC1ezJBPC6y/t5MJ +i5WOqQYNiv829wQ/598DQIPa8VmAwpIyP50PxUS5cKs2w0qI4vUX8fNWNVKwWh9z4lF lcSeO/xce+4JYAQpNauTOjZkyGddUzYjZc96bj2DOVijluYYvsLV3h08K9QvsRwkyjsx xhQawSqdX69vm5yLx0HTbuYjclSYy6MNHK7RGp8E+Nc/A2mNcs5Rvry4z7/GqzRNa2PQ IfdQDqO/YDJrvTfKE9D6/vvszSs0F6JbiaPT3DEjAjVSS2X9SRBkSI6l496UckTGAahE MJaw== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVVy7lxRGxQFCdwrl6n8/0ULJiLNYtZQGqnFhDnAVNqTk7wehj94pYUZrzVSmBGdz96NW7d@ilbers.de X-Gm-Message-State: AOJu0YwEdzLb+qf+kDBfapixP1LYidSLoAx4DRqI7kiRiFfANtwTimP1 HJksb0dWI3f8JC0HBARY0gr06prvWTS93nRUJEsvuZIo2UlwUfnJ X-Google-Smtp-Source: AGHT+IFYOopgdyFbW2j5WDyHyq+Q6Myh00G55iycNd0MMTmD0wFyn+gsp2Y3rPEMAW9CSl5SmsK9vQ== X-Received: by 2002:a05:651c:552:b0:2fa:c59d:1af3 with SMTP id 38308e7fff4ca-2fc9d35a597mr59929111fa.20.1729864703299; Fri, 25 Oct 2024 06:58:23 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:1f11:0:b0:2fa:c593:661b with SMTP id 38308e7fff4ca-2fca593d2b5ls3194821fa.2.-pod-prod-03-eu; Fri, 25 Oct 2024 06:58:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWkq5H122pOnpvPx1bVLf+Xy8NU9BCW2udfJYqhfMBPckwTp/nFFliKo5M8dl9udwTteUnNMfQwgGpF@googlegroups.com X-Received: by 2002:a05:651c:507:b0:2fc:a026:bb41 with SMTP id 38308e7fff4ca-2fca026bb99mr55411191fa.15.1729864700783; Fri, 25 Oct 2024 06:58:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729864700; cv=none; d=google.com; s=arc-20240605; b=in+lyL2i9nCFDkbGsEMie9uI6jH6gvh5fOR6+4BF0LGljUX73TIHpS4lC9k2cv0R2Q t2g0L7D4o3SfaSgplmNjwKy87Gx1wvZKIDbRqDmaJKvB/PGPiFuiaE1W1QSjg5AwBaKG n+EznU+IY4r75usyauJR/8E9aXB1YbK0dZ5nnSUX/1T1kjFqqIF9ihUzX2B8WLMXHkDc dGH1Hmkk2HE9YsAuWbWJASNlcKvIJxdnYceYFXkVi78MZBWIWBCajfqD5uCrP7IlxW0f BolDLSfMk1nhM0SKEZkqzNQOcmG6Cz9kNbf3FN3ID4GnQgPl0AcloXdO+wACKAhl/SpX GpAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=m3+o/sOxmZ/5Jvn2kT89eC6W5ijaHXRzyjlErWg0FvU=; fh=JZvUnqoG0jWph92hWpw0EINycbLveqkIcdkusZDYok4=; b=jbqvScp02RRnRQGLEltf9tehIfkvDKurdQR78onFt6YpVHraYywvULOrKDpRrRDUhc VcUGKl9J5r0QC1fgUyoJTlt/b1Be1PIDbF0Ih+oo2PjWdH7u6AVBBSWMS60GpwYrtSHV Bb102tdi06+u9/fJjdVeWJiKWh4AnmQKkhhnmHkta+5DBW0rGuI13E4FXcOaTm1hsKnt JPwFc5Quks6oWIH18X1G2uPVBsdJ21gKGCmtsk73lBd8q5G198oYMPfMywwt51NOTwbd v6l5c+J+ekyFYRIkXCCvqjRGhfQAL2Zt2vxxoy+5ypcr0ry3pj7va+dAg+C+rTPF3xkH xnHA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 38308e7fff4ca-2fcb469d2f4si259761fa.4.2024.10.25.06.58.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Oct 2024 06:58:20 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 49PDwDaj023842 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Oct 2024 15:58:15 +0200 Message-ID: <3ea2565951efedfd51d097722b1dcf71453af2ad.camel@ilbers.de> Subject: Re: [PATCH v2] initramfs: Avoid hanging mounts on failed update-initramfs From: Uladzimir Bely To: Anton Mikanovich , isar-users@googlegroups.com Date: Fri, 25 Oct 2024 16:58:03 +0300 In-Reply-To: <20241024101004.214465-1-amikan@ilbers.de> References: <20241024101004.214465-1-amikan@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,T_SPF_TEMPERROR autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: NkZqBN8cWeLu On Thu, 2024-10-24 at 13:10 +0300, Anton Mikanovich wrote: > If update-initramfs fails during do_generate_initramfs task execution > there will be mounts left behind: >=20 > > E: /usr/share/initramfs-tools/hooks/isar-example failed with return > > 1. > > update-initramfs: failed for /boot/initrd.img-6.1.0-26-amd64 with > > 1. > > WARNING: exit code 1 from a shell command. > ERROR: Task (mc:qemuamd64-bookworm:isar/meta-isar/recipes- > initramfs/images/isar-initramfs.bb:do_generate_initramfs) failed with > exit code '1' > NOTE: Tasks Summary: Attempted 38 tasks of which 27 didn't need to be > rerun and 1 failed. > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/isar-apt left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/sys left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/proc left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/dev/pts left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/dev/shm left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/dev left mounted, unmounting... >=20 > Protect mounting with a trap for cleanup in case of failure. >=20 > Signed-off-by: Anton Mikanovich > --- > =C2=A0meta/classes/initramfs.bbclass | 4 ++++ > =C2=A01 file changed, 4 insertions(+) >=20 > diff --git a/meta/classes/initramfs.bbclass > b/meta/classes/initramfs.bbclass > index 42013356..0197a60b 100644 > --- a/meta/classes/initramfs.bbclass > +++ b/meta/classes/initramfs.bbclass > @@ -35,6 +35,10 @@ do_generate_initramfs[sstate-inputdirs] =3D > "${DEPLOYDIR}" > =C2=A0do_generate_initramfs[sstate-outputdirs] =3D "${DEPLOY_DIR_IMAGE}" > =C2=A0do_generate_initramfs() { > =C2=A0=C2=A0=C2=A0=C2=A0 rootfs_do_mounts > + > +=C2=A0=C2=A0=C2=A0 trap 'exit 1' INT HUP QUIT TERM ALRM USR1 > +=C2=A0=C2=A0=C2=A0 trap 'rootfs_do_umounts' EXIT > + > =C2=A0=C2=A0=C2=A0=C2=A0 rootfs_do_qemu > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 sudo -E chroot "${INITRAMFS_ROOTFS}" sh -c '\ > --=20 > 2.34.1 >=20 Applied to next. --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= 3ea2565951efedfd51d097722b1dcf71453af2ad.camel%40ilbers.de.