From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7186516587736727552 X-Received: by 2002:adf:da4b:0:b0:242:63de:2f58 with SMTP id r11-20020adfda4b000000b0024263de2f58mr2514389wrl.28.1673242470376; Sun, 08 Jan 2023 21:34:30 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:5a11:0:b0:225:6559:3374 with SMTP id bq17-20020a5d5a11000000b0022565593374ls6548694wrb.2.-pod-prod-gmail; Sun, 08 Jan 2023 21:34:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXspvYvdCI2+ebHIrMWPRjeBnqsCL2VXU2xMqWekbNlfNDQyT5OdaZqb7ZCihJBp63yc4SHc X-Received: by 2002:adf:ed10:0:b0:2bb:32b0:b0f9 with SMTP id a16-20020adfed10000000b002bb32b0b0f9mr5750509wro.61.1673242469236; Sun, 08 Jan 2023 21:34:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673242469; cv=pass; d=google.com; s=arc-20160816; b=z/D2jT3cYJYdG2pzIrsWaBuc4fh2qprOr9gUb+Z/pZXfNU4zqXrhHQxEOu1Isw92qk J8cppxuGEudyx/anobdOAzGojQef62YIn/q7aMGfACaFbOqy+SnxcpzWWueSDU5ATvg3 ByqCSgH4p0z9f1Cm5AJk9TEKoAxVo0CHWNSR2O5ET+GJ5TCxbzq4fq/BPex1JCTzq5oc 3irEysitmbcPtnlcBBSEOeBiIKtsWY6N50QTWhRzI0jDx+0J1kw8n7QyN3BIxFdflvN5 QiO2AZOgt7F2nXW8CuI8HI/U5VGczb0BFlpjfhtPoeRDxKXmbXwWXrpDkFaJeoftjH9J 46gw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=fq5SHA+1e78N5pTEvaNS79G4/mZgv6I2vJhH+VvCG3k=; b=GXOuuoWNMHvuW3upkgZDOxLido9zVEwt6fCIPlvF41a/nr3Zbp27EhxBZNsXOirvPE WzVlVOwflWSoBP7noKqXGIkO2ZjDMDWKU/BCwHmJI4WQO5sq5YCYEBmxl+wUVenwKqDZ 5DbSPOfU0n547MwFPNPF5bi0peKtYwgS1qTiuQtfrKKEmfCkHWM7i5C+YIaze+5jZFrE LZXCNf3pcsXabjItnDsx4FalbfQB28OesjvW0eBdC/nOkzJIVZ8z2EtnRYLFlQPKZN+a /6YUIvr7GOpmLyFBnTD1A562eHZiREsdcz7hOQsxi5N1Tyby5tb+Kms/TORie5xRywZm cDWg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Z0gcpcle; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.66 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2066.outbound.protection.outlook.com. [40.107.21.66]) by gmr-mx.google.com with ESMTPS id v5-20020a5d59c5000000b00236e8baff63si311655wry.0.2023.01.08.21.34.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Jan 2023 21:34:29 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.66 as permitted sender) client-ip=40.107.21.66; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Z0gcpcle; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.66 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=luKMhZEcq5OCSNHta8T7pRuqV5v9nvQaCBZjWvVnPf+5prFkhVNyW7JK2RH1zJRVM1XgjdsvV3dMbGI9A8kVIGrrHtCYyPWZ1WaZIKpwEiXM2R1BwltmJ5B4nnXSJ/AMflSEEguu/BE+29COwOWcA2SZD4xCGzGfdpTKHHpiD3Z6AEsW9KQP+YwQVJ5/3mPRJloRvYXEFYRJfsOG6Abmrj2utBrhhRJP3AnUs19TaxP6u3g9IMfV1CIxKpYEDhAG6M2KUHiXjK7+JoZL4+ML4Aq1TxtJ28kxIkzTh9i2zdKd0sa9jDJM81pBWiT01J48AGswDcbxbTKnwT7PU6+GkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fq5SHA+1e78N5pTEvaNS79G4/mZgv6I2vJhH+VvCG3k=; b=lvDZbtYE8wmoqysTs7PGqLDuvCl1hDWQEmGzbyd45rmYj7S5P+AbBc9cX4S3p2LIFucCJyo7wXZ8abdbZjt8j76SrdIY9vv+Tygby/6wRSZ9S1TNNvKS1jczENQonqYevL559jq+EA7o/OLmm/sQWMoPHqTIr/GgNNAQaFf30tjPjD+gP9Q1EJF+giDlq7R9BDqMoYBIpak/J0O9tTECE/fIoYWNtWv9Ydabz18SUefRFGeDZoPVEVsXFPBVtxVCxR5TVr2Bwrral7p3qkT+Z5hdCl0HWE1/z2RfaNuZVRvbClzxS8m/zFb/96wBDbaXwjo8JQA3YEkSVcG9xBjoCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fq5SHA+1e78N5pTEvaNS79G4/mZgv6I2vJhH+VvCG3k=; b=Z0gcpclezgefdcNtOPP3nqPOgheQkV3FMqQQdV9SCKLzpSMtmDo1JgUmsfmWur/k0Cv/2bLhTf0YJvodTkpZ5gAgnaP+ZyE8IaRdrw5Wuoax2h8JbXq09dmHVkxGR4P2//XatqUkA5zfM4SxdX9PkVji6QsZbUGs3xNiPGIjN0n+egB3YZwH/RjvJAFVRHs1hLM1F9V2qf6UUbTkmi7zqQCCkrkD4EcD7Zwa58C2s0UN1gKflxAHLJ5gSQB3iFSV4cD4nKlBHDPMqH0pGtj+66/wNkQ52z/P9FrxVgP8my6xjElGHM3emsDQtlj+xpLPkcKwqp3oXe6Bm4NN5DfjpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DB5PR10MB7775.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:48e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 05:34:27 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5%6]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 05:34:27 +0000 Message-ID: <3ea51234-0a50-8e5d-2af2-20b20055d4a5@siemens.com> Date: Mon, 9 Jan 2023 06:34:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/3] deb_add_changelog: use SOURCE_DATE_EPOCH Content-Language: en-US To: Felix Moessbauer , isar-users@googlegroups.com Cc: henning.schild@siemens.com, venkata.pyla@toshiba-tsip.com References: <20230109051428.450854-1-felix.moessbauer@siemens.com> <20230109051428.450854-4-felix.moessbauer@siemens.com> From: Jan Kiszka In-Reply-To: <20230109051428.450854-4-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::11) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DB5PR10MB7775:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d156567-e2f9-41d6-4506-08daf2032cba X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E6c1PTi4PPaPy3JsXUtJmilHvq4GxPAR31hU/yRHK6DcoTmt4CxmGOmddZyePeIiM6aaaSWGk/awUywIlyM1XNIQMh0PNHRKnnBMz51oZiEDcA724UA4S5ELkqIsk3cVerYFtWCK8EYmX722SKcTxyZ3F0fj8gSG13Rv3qdBOwHs+19wfi20r7e/bnvTRjwcjAjA7CjtZTHGdfnZtISqBKCeWRyG383rKRTGQypzPQKgxtJP9dL1qQn5PGXhGruOaNKaAw5levYjSILjJZ7ktH1BbLDrqXayBs3Q1z1/qVr/jQAd0ekUEsCj8qB5kHIefb9V4g6yHfykCkljsF1q7/FefMWmEK6SKJiEzevelAT4JmzlTqV1Dq7cKQYtQs10ZXRRPwsItNKIDfBn+oPG+VA0bm3QwmQW5XotkqIo66WzlWzL9rH9TZlW41wxI+UiP0UFgDgOBdTAnozHO+AyTlzo5oi8/qqIpeOaHugzYlhf7cbQQPJstdcGI14aBzjGSRedTFvQ4deETaxpdYvTJDbNCC2+bIuh8tUyFp1t6QVBxufYU9AU0qdCHzLMP461y+2ermcvV+J0rjB0MRCd33RoCs7bIKcfUwf4habeJ7bZfyHB9OmbPNzcUCQ8RhCfiw7+8q57s2rnYS380z49KzKt6jl6tQfgDIMOgUlPY4lE5O9I9PHYCgB0TWdb0H1vV4PkEVC0FBtXD16hTw+lDWGFc1JUEDFsI2OajdYByTeyoI5cGLa33YWHi9JcZeetoJsGuwM/dSo87ULJfOGcnjQ+YyP7JdHhbK6iEx4bRyk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199015)(38100700002)(31696002)(86362001)(82960400001)(36756003)(53546011)(2616005)(316002)(26005)(186003)(6512007)(478600001)(6486002)(31686004)(6666004)(2906002)(83380400001)(44832011)(8936002)(5660300002)(66476007)(66556008)(66946007)(8676002)(4326008)(6506007)(41300700001)(59356011)(207903002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0w4Wkx6TkFCNlNKQlVZamlQa2ZqN2ZURWhUNFIrL2xaL3g4V0NQSTE3eXY2?= =?utf-8?B?NVl0dlQ1ZlJ6dG81ajZwQmVTYnNJWjErMklRSDN6SUhjN3BIMThyVDJBQ2Jj?= =?utf-8?B?OVd5VDlmY3dDakJzcTFXdGo2YzNMMWJiRmhMZG8zVC90YmRxUzBNTlpBWEtI?= =?utf-8?B?bEQ5N2xJYkkwUlNiWVFhY01raEtFZkpPclU2NjlsYlRjMUJxVE53YnRPRkow?= =?utf-8?B?U0d2OVVLeVdlSFNJZEpRNEh6WnE5cWFMVGd5ZTZ4T3F1dXluN3FlaVhycWRi?= =?utf-8?B?NGwwWkQyNnZJbXRyZUNYRlhIT2FLWFczUFJQdjhXL0FlcHJ6dkJFQkx6WHY2?= =?utf-8?B?aVNNVWtRWnpMZ2dIWE1IMEdsYlJvUUtPc3RXVy9XR0Y4QUxUMndodDFrNkww?= =?utf-8?B?ZEFSSGl5ZzhzdVdXc2xNcTVlYUttOUJZdXdQRU9MNlB0a1NRSU92MC94dlAy?= =?utf-8?B?bUg0d1ZJUzIvOC8zSlVqbkhaYkVMUkJuUytaM21Db2FVNTFTNDhGeFNNZm5k?= =?utf-8?B?NThSZVlmRGRFU1hkWWtKR3hIV2Z1RUZPbTNrQTJCRCsvWXhQa3ZiRzcxVm1i?= =?utf-8?B?bUdBRjk2elBRZGRQY0JsRGJ4ejRQem5lL3BQZjNkL25DUkJXNzJmNitoNHNH?= =?utf-8?B?VDVDRzdaK3d4RFpRMnZrSDJ3dEpUMzJRZkIrMmRDQnVJZXRuTStrR1dEVGFk?= =?utf-8?B?UCtuZk9mbDV5WjJ0YjFBQm1LQW1palN6bmlmcW9aRjJOeWZPOWpZblpFaHJU?= =?utf-8?B?K09NM1liY1duc1dqYWFRWkNobHFqWng2YlZLQ0RQTzJ0MytyUm5JM2c4UHIr?= =?utf-8?B?VStjT0tFSVVFdGk1YjIxT3FkbTduK1dnbjgwdVdGMjVQN25HbnZxL0liajhN?= =?utf-8?B?ZER3dzZSRDVURE9HSjc2R2F0RkF6T3dnOTN6REZkWUxGRDlkOTVlOTB3ZmdP?= =?utf-8?B?L0w0RGxTbEdCUXVReVhaSmNheGFIbXc2WTYxdy9xbHVlTmplMXN1U29ER3ky?= =?utf-8?B?S3FTVVpJcy9GNWRvY21FKzlkYnB1SHlDd2EvZDFEL0plUHZGWFVhZlNucEJj?= =?utf-8?B?Tkg4ZEZ1YjUyUnhnWjRkcVdqZGxaa0ljdGRpZ1hYaFZLbmRDU0FLK0dFdU04?= =?utf-8?B?Yk9Eb0d3cGNQSXM5aEtuTXJWS04wN1grV3pCQXdEMXV5U01IWnlFcFhhZk5n?= =?utf-8?B?cmpCaUY3OVRJM09QbzBMRXlXZGttYUZma3RyMks0ZG1iTTIyL3ZTNTIxb3Fj?= =?utf-8?B?OEZieEJ4LzRCUWYzZlpiVHBtSWhxRmlzd3RPbHVYUGk2ME9Xb2FoV2VuWnov?= =?utf-8?B?d1FyMlk3ZDE5NXBjNjF2RmN5c1RBeDZDcHNkelExUWhFUWVldXJldk1OQlJI?= =?utf-8?B?cW01U1lBSzBHbGxuNEhuK04xemRzTE1ESjNrck9xMHllMlJXYVExVGM4elov?= =?utf-8?B?UUVUc2VNVjNWNVVOUVBJM1dyZFhlY1JSdmFVV05WdXBUY0VNNE52Q0N6L3l6?= =?utf-8?B?dWZiTVdXYlRmSjNHYzFwRUljaGtLR1lTSnpNbkZxK3lDbmxldk1oWGVxS0Fu?= =?utf-8?B?WmE5WmxKb3pyWS90T3hyQjdzQ3FMSjFWTUh6SFRzalZDRU5CUEtqZHB1ZFUw?= =?utf-8?B?N0tjU0hmdVRqYnpjcVNWQWo1OTZpQXRJbDBVaHdqT0pScllZZzJvMnZXRU1r?= =?utf-8?B?MEZKSW1HdGNMSVpmaHFzRXgycnJjcTltejBNRUpPS2I4Uk52M0ZGbXVEOWhQ?= =?utf-8?B?TFIrd3ZUUll0WEVwZWlUWDI0ZUFCNVE3N0ZROUJCTzBtQyt2REE2RkRxY3Zp?= =?utf-8?B?MEZTVE9oME5HV1o3MUY3eWtDVjN4a0V1MjFjYTFKcGJHMUhLbkR1MFkyeHJ6?= =?utf-8?B?NWlFZlhZUE1UQUNGamxmMi9NbVQrTEpsVnF2RnZuSFhONy9qQlRqQk4zb2lN?= =?utf-8?B?L0EzRUMwVHFvSW9xbEpOR3JveEVuTXVrQ2FtQ3BmT0JNMkVURkNLYUREVTcz?= =?utf-8?B?NzN2RkQwYnhRRDZuQlpFU1A4RTN1dFFuNG55SEFsdUdtcktnRm1EQ2VBNWJs?= =?utf-8?B?K1I5MGgwMlFCYU04ZkV6WjhFZVVneEVTN2FpRkwvZjNJY0VZOTB1c2NYWXR2?= =?utf-8?B?bkpZdkEvY24vbFAxeloybC9td094TnpaZGxoTS9xTEVXY2luQXdmQ3VnVG9I?= =?utf-8?B?dHc9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d156567-e2f9-41d6-4506-08daf2032cba X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 05:34:27.6824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ObG5YN0+6OjXmmtpOmdUZuJxRR/S/tBv32OBINbIVPk7Dx4PZuBAwmP+ReSTfBd98HuODirHUV2WtItpgMs6Jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR10MB7775 X-TUID: KcQN7uHgsGjI On 09.01.23 06:14, Felix Moessbauer wrote: > In case the SOURCE_DATE_EPOCH bb variable is set, use that value > both for the auto-generated changelog as well as when appending to > an existing changelog. > > Signed-off-by: Felix Moessbauer > --- > meta/classes/debianize.bbclass | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass > index 3531421..49ae0dd 100644 > --- a/meta/classes/debianize.bbclass > +++ b/meta/classes/debianize.bbclass > @@ -14,7 +14,7 @@ MAINTAINER ??= "Unknown maintainer " > > deb_add_changelog() { > changelog_v="${CHANGELOG_V}" > - timestamp=3600 > + timestamp=${@ d.getVar('SOURCE_DATE_EPOCH', True) or '3600' } > # we have a changelog and that is not autogenerated > # (when autogenerated, changelog.orig is empty) > if [ -f ${S}/debian/changelog ] && [ -s ${WORKDIR}/changelog.orig ]; then > @@ -23,9 +23,11 @@ deb_add_changelog() { > fi > orig_version=$(dpkg-parsechangelog -l ${WORKDIR}/changelog.orig -S Version) > changelog_v=$(echo "${changelog_v}" | sed 's//'${orig_version}'/') > - orig_date=$(dpkg-parsechangelog -l ${WORKDIR}/changelog.orig -S Date) > - orig_seconds=$(date --date="${orig_date}" +'%s') > - timestamp=$(expr ${orig_seconds} + 42) > + if [ -z "${SOURCE_DATE_EPOCH}" ]; then > + orig_date=$(dpkg-parsechangelog -l ${WORKDIR}/changelog.orig -S Date) > + orig_seconds=$(date --date="${orig_date}" +'%s') > + timestamp=$(expr ${orig_seconds} + 42) > + fi > fi > > date=$(LANG=C date -R -d @${timestamp}) > @@ -42,7 +44,6 @@ EOF > # prepend our entry to the original changelog > echo >> ${S}/debian/changelog > cat ${WORKDIR}/changelog.orig >> ${S}/debian/changelog > - fi This hunk should go into patch 1, I suspect... Jan > > if [ -f ${WORKDIR}/changelog ]; then > latest_version=$(dpkg-parsechangelog -l ${WORKDIR}/changelog -S Version) -- Siemens AG, Technology Competence Center Embedded Linux