public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: alexander.heinisch@siemens.com, isar-users@googlegroups.com
Subject: Re: [PATCH] meta-isar: Fixing isar-image-installer to bundle correct target disk image.
Date: Wed, 26 Jun 2024 09:30:41 +0300	[thread overview]
Message-ID: <3ed5c2c630d645acc9033460912dc0ae7a917d9b.camel@ilbers.de> (raw)
In-Reply-To: <20240619095351.192990-1-alexander.heinisch@siemens.com>

On Wed, 2024-06-19 at 11:53 +0200, alexander.heinisch via isar-users
wrote:
> From: Alexander Heinisch <alexander.heinisch@siemens.com>
> 
> When using multiconfig setups with differing machine configs the
> deploy dir of the target to be installed differs from the deploy dir
> of the installer.
> 
> Signed-off-by: Alexander Heinisch <alexander.heinisch@siemens.com>
> ---
>  meta-isar/classes/installer-add-rootfs.bbclass | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-isar/classes/installer-add-rootfs.bbclass b/meta-
> isar/classes/installer-add-rootfs.bbclass
> index 7767d96e..c738f690 100644
> --- a/meta-isar/classes/installer-add-rootfs.bbclass
> +++ b/meta-isar/classes/installer-add-rootfs.bbclass
> @@ -12,6 +12,7 @@ INSTALLER_TARGET_IMAGE ??= "isar-image-base"
>  INSTALLER_TARGET_MC ??= "installer-target"
>  INSTALLER_TARGET_DISTRO ??= "${DISTRO}"
>  INSTALLER_TARGET_MACHINE ??= "${MACHINE}"
> +INSTALLER_TARGET_DEPLOY_DIR_IMAGE ??=
> "${DEPLOY_DIR}/images/${INSTALLER_TARGET_MACHINE}"
>  
>  IMAGE_DATA_FILE ??= "${INSTALLER_TARGET_IMAGE}-
> ${INSTALLER_TARGET_DISTRO}-${INSTALLER_TARGET_MACHINE}"
>  IMAGE_DATA_POSTFIX ??= "wic.zst"
> @@ -24,9 +25,9 @@ def get_installer_source(d, suffix):
>      installer_target_image = d.getVar('INSTALLER_TARGET_IMAGE') or
> ""
>      if not installer_target_image:
>          return ""
> -    deploy_dir = d.getVar('DEPLOY_DIR_IMAGE')
> +    target_deploy_dir =
> d.getVar('INSTALLER_TARGET_DEPLOY_DIR_IMAGE')
>      image_data = d.getVar('IMAGE_DATA_FILE')
> -    return f"{deploy_dir}/{image_data}.{suffix}"
> +    return f"{target_deploy_dir}/{image_data}.{suffix}"
>  
>  def get_installer_destination(d, suffix):
>      installer_target_image = d.getVar('INSTALLER_TARGET_IMAGE') or
> ""
> -- 
> 2.43.0
> 

Applied to next, thanks.

-- 
Best regards,
Uladzimir.

      reply	other threads:[~2024-06-26  6:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  9:53 alexander.heinisch
2024-06-26  6:30 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ed5c2c630d645acc9033460912dc0ae7a917d9b.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=alexander.heinisch@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox