* [PATCH] isar-installer: Add logic to call other install script @ 2025-10-06 13:55 'Clara Kowalsky' via isar-users 2025-10-07 7:59 ` 'MOESSBAUER, Felix' via isar-users 0 siblings, 1 reply; 4+ messages in thread From: 'Clara Kowalsky' via isar-users @ 2025-10-06 13:55 UTC (permalink / raw) To: isar-users; +Cc: florian.bezdeka, Clara Kowalsky By setting INSTALL_SCRIPT, another script than the default deploy-image-wic.sh can be called in case of a different installation procedure. Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com> --- .../deploy-image-service/deploy-image-service.bb | 8 ++++++-- .../deploy-image-service/files/install.override.conf | 5 ----- .../deploy-image-service/files/install.override.conf.tmpl | 5 +++++ 3 files changed, 11 insertions(+), 7 deletions(-) delete mode 100644 meta-isar/recipes-installer/deploy-image-service/files/install.override.conf create mode 100644 meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl diff --git a/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb b/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb index 0fa3dcf3..7f5ff749 100644 --- a/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb +++ b/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb @@ -5,11 +5,15 @@ DESCRIPTION = "systemd service to add target image to rootfs" - inherit dpkg-raw -SRC_URI = "file://install.override.conf \ +SRC_URI = "file://install.override.conf.tmpl \ " + +INSTALL_SCRIPT ??= "deploy-image-wic.sh" +TEMPLATE_VARS += "INSTALL_SCRIPT" +TEMPLATE_FILES += "install.override.conf.tmpl" + DEPENDS += " deploy-image" DEBIAN_DEPENDS = "deploy-image" diff --git a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf deleted file mode 100644 index 357d8662..00000000 --- a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf +++ /dev/null @@ -1,5 +0,0 @@ -[Service] -ExecStart= -ExecStart=/bin/sh -c "deploy-image-wic.sh || (echo 'Rebooting in 60 s'; sleep 60); reboot" -StandardInput=tty -StandardOutput=tty diff --git a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl new file mode 100644 index 00000000..e09c5036 --- /dev/null +++ b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl @@ -0,0 +1,5 @@ +[Service] +ExecStart= +ExecStart=/bin/sh -c "${INSTALL_SCRIPT} || (echo 'Rebooting in 60 s'; sleep 60); reboot" +StandardInput=tty +StandardOutput=tty -- 2.51.0 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251006135501.1593114-1-clara.kowalsky%40siemens.com. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] isar-installer: Add logic to call other install script 2025-10-06 13:55 [PATCH] isar-installer: Add logic to call other install script 'Clara Kowalsky' via isar-users @ 2025-10-07 7:59 ` 'MOESSBAUER, Felix' via isar-users 2025-10-13 6:54 ` 'Clara Kowalsky' via isar-users 0 siblings, 1 reply; 4+ messages in thread From: 'MOESSBAUER, Felix' via isar-users @ 2025-10-07 7:59 UTC (permalink / raw) To: isar-users, Kowalsky, Clara; +Cc: Bezdeka, Florian On Mon, 2025-10-06 at 15:55 +0200, 'Clara Kowalsky' via isar-users wrote: > By setting INSTALL_SCRIPT, another script than the default > deploy-image-wic.sh can be called in case of a different installation > procedure. > > Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com> > --- > .../deploy-image-service/deploy-image-service.bb | 8 ++++++-- > .../deploy-image-service/files/install.override.conf | 5 ----- > .../deploy-image-service/files/install.override.conf.tmpl | 5 +++++ > 3 files changed, 11 insertions(+), 7 deletions(-) > delete mode 100644 meta-isar/recipes-installer/deploy-image-service/files/install.override.conf > create mode 100644 meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl > > diff --git a/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb b/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb > index 0fa3dcf3..7f5ff749 100644 > --- a/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb > +++ b/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb > @@ -5,11 +5,15 @@ > > DESCRIPTION = "systemd service to add target image to rootfs" > > - > inherit dpkg-raw Hi! this change is unrelated. > > -SRC_URI = "file://install.override.conf \ > +SRC_URI = "file://install.override.conf.tmpl \ > " > + > +INSTALL_SCRIPT ??= "deploy-image-wic.sh" > +TEMPLATE_VARS += "INSTALL_SCRIPT" > +TEMPLATE_FILES += "install.override.conf.tmpl" > + > DEPENDS += " deploy-image" > DEBIAN_DEPENDS = "deploy-image" The install script comes from the deploy-image package. Why not simply add multiple providers for the deploy-image package and just install the corresponding one? Here we pull in dependencies which are then not used. Apart from that, by modeling this via dependencies, the risk for package-name-collisions under multiconfig can be avoided. Felix > > diff --git a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf > deleted file mode 100644 > index 357d8662..00000000 > --- a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf > +++ /dev/null > @@ -1,5 +0,0 @@ > -[Service] > -ExecStart= > -ExecStart=/bin/sh -c "deploy-image-wic.sh || (echo 'Rebooting in 60 s'; sleep 60); reboot" > -StandardInput=tty > -StandardOutput=tty > diff --git a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl > new file mode 100644 > index 00000000..e09c5036 > --- /dev/null > +++ b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl > @@ -0,0 +1,5 @@ > +[Service] > +ExecStart= > +ExecStart=/bin/sh -c "${INSTALL_SCRIPT} || (echo 'Rebooting in 60 s'; sleep 60); reboot" > +StandardInput=tty > +StandardOutput=tty > -- > 2.51.0 > > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251006135501.1593114-1-clara.kowalsky%40siemens.com. -- Siemens AG Linux Expert Center Friedrich-Ludwig-Bauer-Str. 3 85748 Garching, Germany -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/33fda28752170ee40cea8467139f9589abde8515.camel%40siemens.com. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] isar-installer: Add logic to call other install script 2025-10-07 7:59 ` 'MOESSBAUER, Felix' via isar-users @ 2025-10-13 6:54 ` 'Clara Kowalsky' via isar-users 2025-10-13 9:58 ` 'Heinisch, Alexander' via isar-users 0 siblings, 1 reply; 4+ messages in thread From: 'Clara Kowalsky' via isar-users @ 2025-10-13 6:54 UTC (permalink / raw) To: Moessbauer, Felix (FT RPD CED OES-DE), isar-users Cc: Bezdeka, Florian (FT RPD CED OES-DE) On 07.10.25 09:59, Moessbauer, Felix (FT RPD CED OES-DE) wrote: > On Mon, 2025-10-06 at 15:55 +0200, 'Clara Kowalsky' via isar-users > wrote: >> By setting INSTALL_SCRIPT, another script than the default >> deploy-image-wic.sh can be called in case of a different installation >> procedure. >> >> Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com> >> --- >> .../deploy-image-service/deploy-image-service.bb | 8 ++++++-- >> .../deploy-image-service/files/install.override.conf | 5 ----- >> .../deploy-image-service/files/install.override.conf.tmpl | 5 +++++ >> 3 files changed, 11 insertions(+), 7 deletions(-) >> delete mode 100644 meta-isar/recipes-installer/deploy-image-service/files/install.override.conf >> create mode 100644 meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl >> >> diff --git a/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb b/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb >> index 0fa3dcf3..7f5ff749 100644 >> --- a/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb >> +++ b/meta-isar/recipes-installer/deploy-image-service/deploy-image-service.bb >> @@ -5,11 +5,15 @@ >> >> DESCRIPTION = "systemd service to add target image to rootfs" >> >> - >> inherit dpkg-raw > > Hi! > > this change is unrelated. > >> >> -SRC_URI = "file://install.override.conf \ >> +SRC_URI = "file://install.override.conf.tmpl \ >> " >> + >> +INSTALL_SCRIPT ??= "deploy-image-wic.sh" >> +TEMPLATE_VARS += "INSTALL_SCRIPT" >> +TEMPLATE_FILES += "install.override.conf.tmpl" >> + >> DEPENDS += " deploy-image" >> DEBIAN_DEPENDS = "deploy-image" > > The install script comes from the deploy-image package. Why not simply > add multiple providers for the deploy-image package and just install > the corresponding one? Here we pull in dependencies which are then not > used. Apart from that, by modeling this via dependencies, the risk for > package-name-collisions under multiconfig can be avoided. > > Felix Hi, true, it works fine by just adding to the new recipe: PROVIDES = "deploy-image" DEBIAN_PROVIDES = "deploy-image" And setting: PREFERRED_PROVIDER_deploy-image = <new-recipe> Thank you. Clara > >> >> diff --git a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf >> deleted file mode 100644 >> index 357d8662..00000000 >> --- a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf >> +++ /dev/null >> @@ -1,5 +0,0 @@ >> -[Service] >> -ExecStart= >> -ExecStart=/bin/sh -c "deploy-image-wic.sh || (echo 'Rebooting in 60 s'; sleep 60); reboot" >> -StandardInput=tty >> -StandardOutput=tty >> diff --git a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl >> new file mode 100644 >> index 00000000..e09c5036 >> --- /dev/null >> +++ b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf.tmpl >> @@ -0,0 +1,5 @@ >> +[Service] >> +ExecStart= >> +ExecStart=/bin/sh -c "${INSTALL_SCRIPT} || (echo 'Rebooting in 60 s'; sleep 60); reboot" >> +StandardInput=tty >> +StandardOutput=tty >> -- >> 2.51.0 >> >> -- >> You received this message because you are subscribed to the Google Groups "isar-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. >> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251006135501.1593114-1-clara.kowalsky%40siemens.com. > -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/3f611c07-f98a-478b-b07c-6dce3fd5a7a7%40siemens.com. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] isar-installer: Add logic to call other install script 2025-10-13 6:54 ` 'Clara Kowalsky' via isar-users @ 2025-10-13 9:58 ` 'Heinisch, Alexander' via isar-users 0 siblings, 0 replies; 4+ messages in thread From: 'Heinisch, Alexander' via isar-users @ 2025-10-13 9:58 UTC (permalink / raw) To: isar-users, Kowalsky, Clara, MOESSBAUER, Felix; +Cc: Bezdeka, Florian Have you seen: https://groups.google.com/g/isar-users/c/fP88xwMFQuQ/m/qAzBGXQ5AgAJ BR Alexander On Mon, 2025-10-13 at 08:54 +0200, 'Clara Kowalsky' via isar-users wrote: > > > On 07.10.25 09:59, Moessbauer, Felix (FT RPD CED OES-DE) wrote: > > On Mon, 2025-10-06 at 15:55 +0200, 'Clara Kowalsky' via isar-users > > wrote: > > > By setting INSTALL_SCRIPT, another script than the default > > > deploy-image-wic.sh can be called in case of a different > > > installation > > > procedure. > > > > > > Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com> > > > --- > > > .../deploy-image-service/deploy-image-service.bb | 8 > > > ++++++-- > > > .../deploy-image-service/files/install.override.conf | 5 - > > > ---- > > > .../deploy-image-service/files/install.override.conf.tmpl | 5 > > > +++++ > > > 3 files changed, 11 insertions(+), 7 deletions(-) > > > delete mode 100644 meta-isar/recipes-installer/deploy-image- > > > service/files/install.override.conf > > > create mode 100644 meta-isar/recipes-installer/deploy-image- > > > service/files/install.override.conf.tmpl > > > > > > diff --git a/meta-isar/recipes-installer/deploy-image- > > > service/deploy-image-service.bb b/meta-isar/recipes- > > > installer/deploy-image-service/deploy-image-service.bb > > > index 0fa3dcf3..7f5ff749 100644 > > > --- a/meta-isar/recipes-installer/deploy-image-service/deploy- > > > image-service.bb > > > +++ b/meta-isar/recipes-installer/deploy-image-service/deploy- > > > image-service.bb > > > @@ -5,11 +5,15 @@ > > > > > > DESCRIPTION = "systemd service to add target image to rootfs" > > > > > > - > > > inherit dpkg-raw > > > > Hi! > > > > this change is unrelated. > > > > > > > > -SRC_URI = "file://install.override.conf \ > > > +SRC_URI = "file://install.override.conf.tmpl \ > > > " > > > + > > > +INSTALL_SCRIPT ??= "deploy-image-wic.sh" > > > +TEMPLATE_VARS += "INSTALL_SCRIPT" > > > +TEMPLATE_FILES += "install.override.conf.tmpl" > > > + > > > DEPENDS += " deploy-image" > > > DEBIAN_DEPENDS = "deploy-image" > > > > The install script comes from the deploy-image package. Why not > > simply > > add multiple providers for the deploy-image package and just > > install > > the corresponding one? Here we pull in dependencies which are then > > not > > used. Apart from that, by modeling this via dependencies, the risk > > for > > package-name-collisions under multiconfig can be avoided. > > > > Felix > > Hi, > > true, it works fine by just adding to the new recipe: > PROVIDES = "deploy-image" > DEBIAN_PROVIDES = "deploy-image" > > And setting: PREFERRED_PROVIDER_deploy-image = <new-recipe> > Thank you. > > Clara > > > > > > > > diff --git a/meta-isar/recipes-installer/deploy-image- > > > service/files/install.override.conf b/meta-isar/recipes- > > > installer/deploy-image-service/files/install.override.conf > > > deleted file mode 100644 > > > index 357d8662..00000000 > > > --- a/meta-isar/recipes-installer/deploy-image- > > > service/files/install.override.conf > > > +++ /dev/null > > > @@ -1,5 +0,0 @@ > > > -[Service] > > > -ExecStart= > > > -ExecStart=/bin/sh -c "deploy-image-wic.sh || (echo 'Rebooting in > > > 60 s'; sleep 60); reboot" > > > -StandardInput=tty > > > -StandardOutput=tty > > > diff --git a/meta-isar/recipes-installer/deploy-image- > > > service/files/install.override.conf.tmpl b/meta-isar/recipes- > > > installer/deploy-image-service/files/install.override.conf.tmpl > > > new file mode 100644 > > > index 00000000..e09c5036 > > > --- /dev/null > > > +++ b/meta-isar/recipes-installer/deploy-image- > > > service/files/install.override.conf.tmpl > > > @@ -0,0 +1,5 @@ > > > +[Service] > > > +ExecStart= > > > +ExecStart=/bin/sh -c "${INSTALL_SCRIPT} || (echo 'Rebooting in > > > 60 s'; sleep 60); reboot" > > > +StandardInput=tty > > > +StandardOutput=tty > > > -- > > > 2.51.0 > > > > > > -- > > > You received this message because you are subscribed to the > > > Google Groups "isar-users" group. > > > To unsubscribe from this group and stop receiving emails from it, > > > send an email to isar-users+unsubscribe@googlegroups.com. > > > To view this discussion visit > > > https://groups.google.com/d/msgid/isar-users/20251006135501.1593114-1-clara.kowalsky%40siemens.com > > > . > > > -- Alexander Heinisch Siemens AG http://www.siemens.com/ -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/33bad1a16f2a45b51da9b3555f35648969056ed9.camel%40siemens.com. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-13 9:59 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2025-10-06 13:55 [PATCH] isar-installer: Add logic to call other install script 'Clara Kowalsky' via isar-users 2025-10-07 7:59 ` 'MOESSBAUER, Felix' via isar-users 2025-10-13 6:54 ` 'Clara Kowalsky' via isar-users 2025-10-13 9:58 ` 'Heinisch, Alexander' via isar-users
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox