From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 13 Mar 2025 14:10:37 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-lj1-f184.google.com (mail-lj1-f184.google.com [209.85.208.184]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 52DDAaXw026117 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Mar 2025 14:10:36 +0100 Received: by mail-lj1-f184.google.com with SMTP id 38308e7fff4ca-307359756d0sf5431891fa.0 for ; Thu, 13 Mar 2025 06:10:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1741871431; cv=pass; d=google.com; s=arc-20240605; b=ArNX9GoHLLmQAr1l4SAIdGZYfyjMnTkFW2nbmsv3U5FsvYRBKtnhYGpl2zV4zZH1FR TZT5NP9sF990tIvy3kkkeD4TYM5WTSZkReipXfew062lFGp2mpL1c2bqxuq5c4fHj2Mh GjlJyfkdtZqVkXLDMAqetNnNkbkzfHZb9kBZIwS4iLTcg5Dbd6btzLwZon4OzEDSn/S/ R8CpWvhCA/4/LFkEhHDDm1oZXqTrXyHlq2A4PNLKpKxsK0HE2vSx4NS/RGHWrzOY8IA6 V5vx10VAv06IUhp5w3bYCVhVtqXIEdfHudenm0OzyjJGlOeoXBYMO1YBCT7z+8uqtlBU b3lQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:autocrypt:references:in-reply-to:date:cc :to:from:subject:message-id:sender:dkim-signature; bh=KE78yklzZRSJGb2d76e1tWMK8fPq17SCt89cBbiDTYE=; fh=g5euIXuIHZRQE24UB1Pu0pIdsXyXF/Qub4MYatANgbM=; b=keIE2czfqRhUPTeD2GimDkwYH+FLpHgIfjDX6K5qVEFzH5bDN0Z2OCBJBFkK3BxlMT KCdI3P88HdFT9MsphmlHEJdl8Th2FH9ZnRXdbapU/Y3Dn5PwDVbQCgoe9kgEFv5yLS+P FxUgjlk2cS4yPPo34U+rMQ7JaTYZ45b5dzQAuFJ5E8ZuyvPhX3n/u1kH2L055XfblKVf L1gDi+yPwqITzOqDNwm/aWlxyBQzfRTUfo2qulAzm69p2HIUiO0kM8gbHTxbK37rJHlS +fgWDu5bS/iCQ8IEPLeJ59BuBQ38qSAxBJ7IU2tMIL40Cn0LPdyAIN9sznUpCBxr4Nuj SuYA==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1741871431; x=1742476231; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=KE78yklzZRSJGb2d76e1tWMK8fPq17SCt89cBbiDTYE=; b=etgyVtHRo0xTbuxdGrT0Ii7tMAnD1SPjgMNrvJ+SMDJ8y1sfZbtyCIFskI8ZFzVbVd ZYvM0+zzi2D9KnUQZLKIVKKpVVr2BN1KWQhW2r1gvn0YeC5im+hrAllY1+g3W3vs5nhK R3EoZ4s4vSv7v2YBUYQk0cIJpncaTd+Mt/ym3snFyehFwsbTIvKSOsPaRyF0J7D/W690 P8MfQG1se/VKzWxaOIEoudBcv3UxQ0QfGqsz4ozkyvyWg7qqXFrlw3Y4WqqC82YlSjfM 7/8ieHJKiJpy3xK0hShFoQr/8fmCkEZ69ssj3AB7HxzrLnvFCfCXm9fPviCV3I7/2wxW JDgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741871431; x=1742476231; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=KE78yklzZRSJGb2d76e1tWMK8fPq17SCt89cBbiDTYE=; b=WCMRSppA2KDJ1YSrtAzU6K2xEQYeHyoj4n38FDJFeo5HZH/+I+PGQQ78Y+cYPz0LJU +WMrTYfE/3kTMyHly3+cAI9F6MCSs96dXYLxukNbyCE6a+a5sHzvq1zB0sJmtN5gKUus jBNVXl23GqBT/XUpub1pcg56enBfUhS++oKoy9uWBG81uFJua8z+bZXOG6MtixIZKvbh i4zrX6iNtQSOSlOYAbme72n83XyapkpSnXJoW50zkHBN7OJUQ4988hSxVcjDLoUPylRy o+Jq8oWI5bT+iQ8pralPvdnDcuqOYkG0+LrMNHcAb728O1tyJBHt0HQw/JWdB4kA0+Cr DEoQ== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWoLhG1Mf4uoCa/18FPjirBo7nSm4qCIDaoexRQBDHm0yej3ATxDYHZu/W0xj3bTeVZfv9d@ilbers.de X-Gm-Message-State: AOJu0Yz2koE/hlT1WKr83sovmIrzPNDLWbBu9PU7yEsUQviWmCHWGQBi ZWTw65fqirOsvCk7+aSmpb8sapL5BqW3BVHiiIBwX0tV0Mn/gpfG X-Google-Smtp-Source: AGHT+IHZFsDXlN+WW637SKimJgDdekTXZAS43L0F+Gwd2ni4hTQkbXEmDS7GYlHumZ0GxWpZrnNHjg== X-Received: by 2002:a2e:3206:0:b0:30b:efa5:6988 with SMTP id 38308e7fff4ca-30bf454f983mr91455651fa.20.1741871429959; Thu, 13 Mar 2025 06:10:29 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=Adn5yVHTuDQjkgo5IZJP9BqJEOOulHVWrloK4V2bOFqyq0QBDQ== Received: by 2002:a2e:95da:0:b0:30b:fc92:55c1 with SMTP id 38308e7fff4ca-30c3ae5c84als1934091fa.0.-pod-prod-06-eu; Thu, 13 Mar 2025 06:10:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUCPpuIcNAjqOuKsyth45on7tlk016uvWeRDwpuAx6caopemdls+2hnMtINh10VvhfGVkgmZ4QwGNWC@googlegroups.com X-Received: by 2002:a2e:be11:0:b0:30c:d32:aba8 with SMTP id 38308e7fff4ca-30c0d32af78mr63664991fa.30.1741871426562; Thu, 13 Mar 2025 06:10:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1741871426; cv=none; d=google.com; s=arc-20240605; b=NVZAZAC11NdG0hoc7nIJJvZ5YtG0St1vDw56q45Fo0J+T4g2XquZE679sz6yq1o+dB SU3zh2mqUNCGD4m1tOjiLvmi/6wZSUbKrstBymGePOPWZ+wYNViEzOU0GmW7+/7zQY2J DaVN3RjfzGT9dZBddsiXlY7gCm4j+KyhHz8dacdjhEVjlHCcdLejlVfmoxgZejgtjSR/ Mny55lLluZOBjXoiH0pzyCSPm3nGfZwNpu6UZZwn44eoQ4sr9PdzNqzmPyQzkjySaQTi /NQRBysS4l0RFRfcvywqSRaZzHH/UOb810I/3VfNdK9Kqrmxq9lq6f96quL4va85Auf9 lNdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id; bh=8nyU3YrAtGdjv2ST8dmJFyU2kXIFfuzYVUrnLC14TLg=; fh=ckLJ/YdaA2J+MKRK+92UKmsLtjKnSsvrxhMy7erkAFU=; b=DyEkNX2BK6NRqkk++WP7A3TpzNlNPv46brdhn16zJBiYe2O1HPXeWiqFiMxk2udUDy XimcN4T8hshlOhfaK17PoLpUON8dQBz5xkI0duMmdO94SYbRaWmhp+3u3iDgMdPVMnlE WsWr/yhlIHGc6HcF58w8IP4fGBxtjnG79eL4JT1Iu8UkQf5MD6blg32EqMeFKnOpNi90 5varwMowDuCPfsCs5ywFvFl1UmIIAQzEBMM5UYEvv2eYfkOxKrTlNLq33j4dvi4UTRSs gQMkRdpE6lnwxYc2JtTyUngjpuaaM4FNQqCXQ47dfjJLny6fw6urJ5l1qpla0EhN+X7g poQw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 38308e7fff4ca-30c3f1aa3b4si290791fa.7.2025.03.13.06.10.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Mar 2025 06:10:26 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 52DDANor026107 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Mar 2025 14:10:24 +0100 Message-ID: <3fd6bdc491628229686855d3278b8d5684643108.camel@ilbers.de> Subject: Re: [PATCH 03/17] meta-isar: deploy-image: Change reboot logic From: Uladzimir Bely To: Jan Kiszka , isar-users Cc: Quirin Gylstorff , Shekar Kasturi Date: Thu, 13 Mar 2025 16:10:23 +0300 In-Reply-To: <6e97e882f080e09a9f7d777cc84e9cd089d92d11.1719927511.git.jan.kiszka@siemens.com> References: <6e97e882f080e09a9f7d777cc84e9cd089d92d11.1719927511.git.jan.kiszka@siemens.com> Autocrypt: addr=ubely@ilbers.de; prefer-encrypt=mutual; keydata=mQENBGO2eUkBCACtT+T3OrPVSExBmqfgXT3lp9XcdxRzjYp26wezkgYjjBXaf36bxtaAf S471VoQtpar0RVeFfW7WDDdfX9ZclSj36zBQe+RVSJzoNoNQfjOXWuSHb5Z+cpAFtqBY4muxK4+ia IlLJd6CN3ejOsLHATtCeHHq8wi0z2T+KdLQO+wQRgo2hjj0Lp9pGTrKJry50HP/o7Vbdu14dOx2xq r8+wPc6SQbBIrcqaa4MqCQC00vQG7eXvo+k2MOw59FDdpMH0KR9mHgp3u/s4I+4YRBArukt9G9xz/ rsEFmxAIBC6N/a6Hzwg4puc91n7ABDsPg8Vp+X3MDraujN0dvR6OKVNtABEBAAG0IFVsYWR6aW1pc iBCZWx5IDx1YmVseUBpbGJlcnMuZGU+iQFOBBMBCAA4FiEEJqPNVhVGyk12Eh+PAUQYBM/2FkoFAm O2eUkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQAUQYBM/2FkprlAgAmuna8Hm9EyoEtTl DBGDg6Zm4ZLp5ffvZBE946h92jepDrteoxsJ7pSzJVC2HmDLa4iZUao7lLLbDsUj5x45/iLJcqBZK k3YnAxP2r6a+kI+1VVQY1pxdG1nlJAbdNzoojm/qmezNPSrqni61KVMQKsXBCWhIjSXDSM9CsBj21 a+9qaVqfxovJGTn9lgrZO+xzKQNMKZeOouJlscVuFj21P0ww3/YENiU/nMeTSuYypO76mDtAd08Jo nc3yuHa9MJGei5ixN3wT+IrGR2aL2hdw2M6NgH7sYbL2Zi4ugD6RXHJai1Bh2yvFSVqSQ+M6QOInT 4ud7wslm1XRB065dXtA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: p7HyeNl37nfR On Tue, 2024-07-02 at 15:38 +0200, 'Jan Kiszka' via isar-users wrote: > From: Jan Kiszka >=20 > Pull the reboot out of the script. This allows for cleaner > integration > with different calling environment, may they be a systemd unit, an > initramfs script or simply a shell for testing purposes. >=20 > And if the script exits with an error, wait a minute before rebooting > the system, rather than just trying to re-execute it. This permits to > inspect potential error as well. >=20 > Signed-off-by: Jan Kiszka > --- > =C2=A0.../recipes-installer/deploy-image/files/deploy-image-wic.sh=C2=A0= =C2=A0=C2=A0 | 2 > +- > =C2=A0.../recipes-installer/deploy-image/files/install.override.conf=C2= =A0 | 2 > +- > =C2=A02 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/meta-isar/recipes-installer/deploy-image/files/deploy- > image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/deploy- > image-wic.sh > index 8043aff1..12c1eea2 100644 > --- a/meta-isar/recipes-installer/deploy-image/files/deploy-image- > wic.sh > +++ b/meta-isar/recipes-installer/deploy-image/files/deploy-image- > wic.sh > @@ -105,4 +105,4 @@ fi > =C2=A0umount "$installdata" > =C2=A0sync > =C2=A0dialog --title "Reboot" --msgbox "Installation is successful. Syste= m > will be rebooted. Please remove the USB stick." 7 60 > -reboot > +exit 0 > diff --git a/meta-isar/recipes-installer/deploy- > image/files/install.override.conf b/meta-isar/recipes- > installer/deploy-image/files/install.override.conf > index 73874caa..357d8662 100644 > --- a/meta-isar/recipes-installer/deploy- > image/files/install.override.conf > +++ b/meta-isar/recipes-installer/deploy- > image/files/install.override.conf > @@ -1,5 +1,5 @@ > =C2=A0[Service] > =C2=A0ExecStart=3D > -ExecStart=3D/usr/bin/deploy-image-wic.sh > +ExecStart=3D/bin/sh -c "deploy-image-wic.sh || (echo 'Rebooting in 60 > s'; sleep 60); reboot" Hello Jan. This change seems to cause a sort of race issue. Few days ago "[PATCH v3 0/2] Cover installer image with tests" was merged. Tests were OK (and "next" is still OK) on two jenkins and one gitlab instances. But on the third jenkins instance, they were failing. Boot log: ``` Got config: installer_unattended=3Dtrue installer_image_uri=3D/install/isar-image-ci-debian-bookworm- qemuamd64.wic.zst installer_target_dev=3D/dev/sda installer_target_overwrite=3DOVERWRITE bmaptool: ERROR: An error occurred, here is the traceback: Traceback (most recent call last): File "/usr/lib/python3/dist-packages/bmaptools/CLI.py", line 116, in open_block_device descriptor =3D os.open(path, os.O_WRONLY | os.O_EXCL) bmaptool: ERROR: cannot open block device '/dev/sda' in exclusive mode: [Errno 16] Device or resource busy: '/dev/sda' Rebooting in 60 s ``` But either machine is not booted, or there are some "ext4" errors happen. I couldn't understand few things: - why this happens (unable to get exclusive access to block device)$ - why device is written even if there is such error in logs$ - why sometimes we don't see this error in logs$ - why this doesn't happen when "unattended mode" is off. The reason is that we have these two "getty" instances overriden by custom one having the race. While "serial-getty@ttyS0.service.d" does the job, "getty@tty1.service.d" produces this error visible in logs and reboot machine in 60 seconds. In some cases 60sec is enough for first service to finish writing to the disc, but on slower machines we result in incomplete copy and broken system. Before this patch, when "reboot" calls were in the script, "failed" instance simply exited and didn't try to reboot the board. As a quick fix, I would reverted this patch. Also, I think this behaviour may impact on bmap-tools "psplash" patches currently we have on maillist. I would expect that user won't see the progress bar on screen because it's somewhere on serial console. > =C2=A0StandardInput=3Dtty > =C2=A0StandardOutput=3Dtty > --=20 > 2.43.0 >=20 --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= 3fd6bdc491628229686855d3278b8d5684643108.camel%40ilbers.de.