Re: [PATCH 2/3] Revert "Change ownership of WORKDIR prior to unpacking"

[Jan Kiszka <jan.kiszka@siemens.com>]

On 14.11.18 16:43, Henning Schild wrote:
> Am Wed, 14 Nov 2018 15:11:39 +0100
> schrieb "[ext] Henning Schild" <henning.schild@siemens.com>:
> 
>> Am Wed, 14 Nov 2018 14:58:57 +0100
>> schrieb Jan Kiszka <jan.kiszka@siemens.com>:
>>
>>> On 14.11.18 14:23, Jan Kiszka wrote:
>>>> On 14.11.18 14:10, Jan Kiszka wrote:
>>>>> On 12.11.18 16:51, Henning Schild wrote:
>>>>>> We do not build as root anymore and the non-root uid/gid are now
>>>>>> in sync between inside and outside the chroot.
>>>>>>
>>>>>> This reverts commit 624b7c484bf59940ac2a4114018f7d56892dc05e.
>>>>>> ---
>>>>>>     meta/classes/base.bbclass | 5 -----
>>>>>>     1 file changed, 5 deletions(-)
>>>>>>
>>>>>> diff --git a/meta/classes/base.bbclass
>>>>>> b/meta/classes/base.bbclass index fce1084..d4082de 100644
>>>>>> --- a/meta/classes/base.bbclass
>>>>>> +++ b/meta/classes/base.bbclass
>>>>>> @@ -120,17 +120,12 @@ do_unpack[stamp-extra-info] =
>>>>>> "${DISTRO}-${DISTRO_ARCH}" # Unpack package and put it into
>>>>>> working directory python do_unpack() {
>>>>>> -    import subprocess
>>>>>> -
>>>>>>         src_uri = (d.getVar('SRC_URI', True) or "").split()
>>>>>>         if len(src_uri) == 0:
>>>>>>             return
>>>>>>         rootdir = d.getVar('WORKDIR', True)
>>>>>> -    uid = str(os.getuid())
>>>>>> -    subprocess.call('sudo chown -R ' + uid + ' ' + rootdir,
>>>>>> shell=True) -
>>>>>>         try:
>>>>>>             fetcher = bb.fetch2.Fetch(src_uri, d)
>>>>>>             fetcher.unpack(rootdir)
>>>>>>     
>>>>>
>>>>> This possibly causes this regression:
>>>>>
>>>>> ERROR: expand-on-first-boot-1.0-r0 do_install: Function failed:
>>>>> do_install (log file is located at
>>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263)
>>>>>
>>>>> ERROR: Logfile of failure stored in:
>>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263
>>>>>
>>>>> Log data follows:
>>>>> | DEBUG: Executing shell function do_install
>>>>> | install: cannot remove
>>>>> '/work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/image//lib/systemd/system/expand-on-first-boot.service':
>>>>> Permission denied
>>>>> | WARNING: exit code 1 from a shell command.
>>>>> | ERROR: Function failed: do_install (log file is located at
>>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263)
>>>>>
>>>>>     
>>>>
>>>> OK, that wasn't a "clean" re-build (rather a rebuild after the
>>>> Isar update). Retesting with the same Isar version for build 1
>>>> and 2.
>>
>> Arghh ... on a side-note. I have a few Isar-CI partial rebuild patches
>> in a queue, they target both dpkg and dpkg-raw.
>>
>>> It persists, at least for dpkg-raw, and that is likely because of
>>> the chroot we do for that package.
>>
>> Yes.
> 
> That actually revealed that we kept collecting changes in ${D} and
> never cleaned it before install. I just sent a patch fixing that.
> 
> Next step will probably be to make the raw class use standard
> debian/rules and just take the long dpkg-buildpkg route. Should not be
> too hard to just write a debian/ folder that just does "make install".
> Will look into that ...
> 

Thanks, looking forward to test everything.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux