From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6623002413686063104 X-Received: by 2002:a2e:98cd:: with SMTP id s13-v6mr264320ljj.30.1542210340085; Wed, 14 Nov 2018 07:45:40 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9c6:: with SMTP id 189-v6ls136519ljj.8.gmail; Wed, 14 Nov 2018 07:45:39 -0800 (PST) X-Google-Smtp-Source: AJdET5chXXnIUNJvKV7HoreESvT1ZBcpj+Qx7ngnOvhaFNpIGx2LJFjCSFPioKj57ouWNzaKTbVZ X-Received: by 2002:a2e:9902:: with SMTP id v2-v6mr258454lji.6.1542210339409; Wed, 14 Nov 2018 07:45:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542210339; cv=none; d=google.com; s=arc-20160816; b=Ec3tLUv7j5HNR4thUvv8EMXu85Q8A98Zxe12LxMc1REMycp5ks0UPC6uIqogu0IE/0 m1NfQuve5Xr82agn9Tv3Tm5ACjBPS3C20eBSGYifWAJ+Cvalh2S2RtHVvQ9nAjurBCHS RRBGMoNCIWoW9jsgWRrE2t5akVhiuEnksr41gHofDD/7IEKk5HPP7Vs1uAObb52uWf1m 0Oin3R5p+YdaNLN7ezQxq8uHbHsXAgmSX70jjjw60cZ5dFdto8bRV7RbiV7AiY94blNS jfrhEUHyFbIm6uXX3PanJ0URYTxNa9ZSdbGEaScsIFZVgjPoyMpqx4b06rMK3X2GOEQj hFSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=twxwoY4D/9KYIke3HrXT5aqDJ/NkP2W3VqdQntwAeBk=; b=qpWIuyj8AnPY5KbR4Dfe1I9cUk3v2/Nq7wrHBLQgiFiwsiz+jhYNTXzyuwF0sL/68T 7gYkZZAgZ2sbfVcLLZhNXDRn7v/ywTnY6JFXOHOYRDosZ1fKCBj21zasZoPJ1gIFpHI5 n9ijzjJxwdh06mSbA0M2pwQGOoBgMasW8dUoVS9TtWWAINrp0OgI9gmuzSdov9wT4s9B uXLsrM0aqgLZvncBzekA4kYoTOWiuLMf73TF+GetnWxpIlGlqtU8VkrY5E8n3SitoZni 9JUnrqPlKh7PkTAvOf3S3GtlKcXtDD7bpOJbyK1MSK/FYpdojwgX++oaQ1NOFtwLvO5T Lv2g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id t5-v6si912562lje.3.2018.11.14.07.45.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 07:45:39 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id wAEFjc0H007261 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 Nov 2018 16:45:38 +0100 Received: from [167.87.37.94] ([167.87.37.94]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wAEFjbIw031748; Wed, 14 Nov 2018 16:45:38 +0100 Subject: Re: [PATCH 2/3] Revert "Change ownership of WORKDIR prior to unpacking" To: Henning Schild Cc: isar-users References: <20181112155149.24215-1-henning.schild@siemens.com> <20181112155149.24215-3-henning.schild@siemens.com> <6852a6f3-79a6-7320-abae-5a168fcada59@siemens.com> <06ac3f88-0104-6bd0-711c-f75fec4e4a6f@siemens.com> <1b49699a-e4a5-83fb-f631-de56c7ee266a@siemens.com> <20181114151139.6ff01f5a@md1za8fc.ad001.siemens.net> <20181114164355.742be0bd@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <40092afd-a891-0b0e-4dd2-9752f16f59f1@siemens.com> Date: Wed, 14 Nov 2018 16:45:36 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20181114164355.742be0bd@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: hxkRWwiKk0Pn On 14.11.18 16:43, Henning Schild wrote: > Am Wed, 14 Nov 2018 15:11:39 +0100 > schrieb "[ext] Henning Schild" : > >> Am Wed, 14 Nov 2018 14:58:57 +0100 >> schrieb Jan Kiszka : >> >>> On 14.11.18 14:23, Jan Kiszka wrote: >>>> On 14.11.18 14:10, Jan Kiszka wrote: >>>>> On 12.11.18 16:51, Henning Schild wrote: >>>>>> We do not build as root anymore and the non-root uid/gid are now >>>>>> in sync between inside and outside the chroot. >>>>>> >>>>>> This reverts commit 624b7c484bf59940ac2a4114018f7d56892dc05e. >>>>>> --- >>>>>>    meta/classes/base.bbclass | 5 ----- >>>>>>    1 file changed, 5 deletions(-) >>>>>> >>>>>> diff --git a/meta/classes/base.bbclass >>>>>> b/meta/classes/base.bbclass index fce1084..d4082de 100644 >>>>>> --- a/meta/classes/base.bbclass >>>>>> +++ b/meta/classes/base.bbclass >>>>>> @@ -120,17 +120,12 @@ do_unpack[stamp-extra-info] = >>>>>> "${DISTRO}-${DISTRO_ARCH}" # Unpack package and put it into >>>>>> working directory python do_unpack() { >>>>>> -    import subprocess >>>>>> - >>>>>>        src_uri = (d.getVar('SRC_URI', True) or "").split() >>>>>>        if len(src_uri) == 0: >>>>>>            return >>>>>>        rootdir = d.getVar('WORKDIR', True) >>>>>> -    uid = str(os.getuid()) >>>>>> -    subprocess.call('sudo chown -R ' + uid + ' ' + rootdir, >>>>>> shell=True) - >>>>>>        try: >>>>>>            fetcher = bb.fetch2.Fetch(src_uri, d) >>>>>>            fetcher.unpack(rootdir) >>>>>> >>>>> >>>>> This possibly causes this regression: >>>>> >>>>> ERROR: expand-on-first-boot-1.0-r0 do_install: Function failed: >>>>> do_install (log file is located at >>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263) >>>>> >>>>> ERROR: Logfile of failure stored in: >>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263 >>>>> >>>>> Log data follows: >>>>> | DEBUG: Executing shell function do_install >>>>> | install: cannot remove >>>>> '/work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/image//lib/systemd/system/expand-on-first-boot.service': >>>>> Permission denied >>>>> | WARNING: exit code 1 from a shell command. >>>>> | ERROR: Function failed: do_install (log file is located at >>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263) >>>>> >>>>> >>>> >>>> OK, that wasn't a "clean" re-build (rather a rebuild after the >>>> Isar update). Retesting with the same Isar version for build 1 >>>> and 2. >> >> Arghh ... on a side-note. I have a few Isar-CI partial rebuild patches >> in a queue, they target both dpkg and dpkg-raw. >> >>> It persists, at least for dpkg-raw, and that is likely because of >>> the chroot we do for that package. >> >> Yes. > > That actually revealed that we kept collecting changes in ${D} and > never cleaned it before install. I just sent a patch fixing that. > > Next step will probably be to make the raw class use standard > debian/rules and just take the long dpkg-buildpkg route. Should not be > too hard to just write a debian/ folder that just does "make install". > Will look into that ... > Thanks, looking forward to test everything. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux