From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7221105623410147328 X-Received: by 2002:a7b:ce85:0:b0:3f1:6ef6:c9db with SMTP id q5-20020a7bce85000000b003f16ef6c9dbmr2535075wmj.8.1681911804458; Wed, 19 Apr 2023 06:43:24 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1c14:b0:3f0:b128:14c0 with SMTP id j20-20020a05600c1c1400b003f0b12814c0ls1107212wms.2.-pod-control-gmail; Wed, 19 Apr 2023 06:43:22 -0700 (PDT) X-Google-Smtp-Source: AKy350Z2NPcAlTkO0WOLW2wOh8eiWFZ2cVFwIuKB8WATWBePIieaBjZu9BZUmXrWNg+SU18zbQPR X-Received: by 2002:a7b:cb86:0:b0:3f1:7129:6b25 with SMTP id m6-20020a7bcb86000000b003f171296b25mr10051751wmi.18.1681911802698; Wed, 19 Apr 2023 06:43:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1681911802; cv=pass; d=google.com; s=arc-20160816; b=aK5pk3UWR27y+yYsHqzFIjXcHR3I5cAZlIHmqAA+BXlUEV1AyV8S54XftXm7TxeAGQ z6QoYc4IlPBUib9O+TgIDBjAfrthK2jVD+6XCiktOugn2F0IYT1P0IXc4z2JjnxaiAEl EB4SAcwt/EJBtW7r5PhVAf+tvDPdmqM2lvgx9dO2z/Kc7EUcMOL5Eso/uqWNBxnMCMpZ h9fVG2MftlyxXJkYunnXyxXhqv7otvADGu4gDyyUmI2Xbwuhe3WWLetEK3lqjPm6+swJ AXm0yi+z6yq0Xlv9oqyJsqz1cozccTK22ogXxu/+dHqhsaf3tJmDHxI5WSlSH7bFUFTz 1qVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=rvBR5/Be4THpEj9zkbV9oCVTM5RBx4Q7QC/Ed0Yszzc=; b=rOqG21PrcmQN4H6DBmX4rnpd/rDxrtSWZCbqpPENpHT7woCjN2lub1/CPWEAv88GOr W4VmHl5VjYC0zTnHGhV9b3vw81VR2EXSepELJpth+ISKy4Wfj73frTSr6EdeDC6POtZV sHdo7fGnaOAs2fm1mkhMe9LbcZweIV/ZeiWuQ4P+2857O+Az2I7gz4A7d401a0+IruXB fbK+BsH68YPQYVfS768HXcrGri3C2aW/Db5SOob08NonpGBOL6S5Tw8y0El8k7nDR5v7 PMCDlxkGhPojVUCwvABdOFF0gOH9g0+B58dw28tBVnD4L0DF9YPw+AjzUS9idp7kuq4k 7zzA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=jqU7pd3s; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20601.outbound.protection.outlook.com. [2a01:111:f400:7e1a::601]) by gmr-mx.google.com with ESMTPS id h17-20020a05600c315100b003f1728a7917si91369wmo.2.2023.04.19.06.43.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Apr 2023 06:43:22 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::601 as permitted sender) client-ip=2a01:111:f400:7e1a::601; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=jqU7pd3s; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=canhtoJP7ObyZp1RbwZxc18W2vRksn5t3Y1ebgZwkLJ6XWcw1yIiBjK1L2bHm6RNPRSZiaVsnq2mDWZ/qytkas9Has6PFLa0NRfcqjgig4//i+2MjdT353QF8Zo64PY/r8sv7X6LNVfgKiRnjvQ3J7HygZTJCQRhEaquaczAxVbUHtdBYV0dZAvRHfIyTtVGt4RvQH7rY41qw1YqeiwL63clAOWykBsX+e1WhcYWZ2CnUglFTPc58aqUtoLggknfHt7dGflQhooixr3Oqp0JpVfz/GzoAnhzsFdllpjzinPrKzkdlQBpQhIrTNM5iJdWQVuhjP+xvLbGGQjfqVkLPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rvBR5/Be4THpEj9zkbV9oCVTM5RBx4Q7QC/Ed0Yszzc=; b=NaAJ0LkUZjnsIPSGsLytw67ljCe9Bz0l3zq0QdaODmbKQkA5Z/zJaevnH9e+fA6vWfYrkx8s4AYKKvtLkwesNhbZ8H5APJUZeBaE0qg0wpAdwXzn+ZcIHcQmDrJihY/YHvO13O5DI6+25AK0x7bYY3TT1XYsynOC9lu4VpjnmR8D93E9TDiIVoAARj5UNJQf0U/kJshiEM+ofvss/1hIiKDgfBkn6Z5JDnJmpBEzz1cJhU5aIrGeQxelplabwulgFZBdg2ltFOSV/ibUzsM4e33nqrEv6xSljqzv4VL6gZw2remZGpoZyneEqbuwK+0Mb8g5bROLNH0Uzs5bghtwXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rvBR5/Be4THpEj9zkbV9oCVTM5RBx4Q7QC/Ed0Yszzc=; b=jqU7pd3s1YxboFieFHCSV4U3Ls39Vm+2M9wFVnWOEpQwjjhTK9MUzczlDfjArsJNGmevlUiX6sPOHBBD4f3Jkex5CAmNI3DdouAqkCVVH9dtVSisWPTrpP4HUK6flpIbDC/zczRSZ4kuxdnzMefYJtqbQdSL/txGHULJkDzUEPnw5h1pNyFlm6PRp+oxfq/TVzUmOXUN+pY+sEa9tEOxa6cKHLymsraB9TJtKTKVuD4Ey1B201aUrb2sE/eVYJPnoVMGka0wnBdgrsdJxXdL3Ny8P+UjU9z0kQjg2VdK7Cm6eIKyW9NzvKSO9oXtCCQ7yav89QhW+0tYZKr2QS8K9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AS8PR10MB7160.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:61c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.21; Wed, 19 Apr 2023 13:43:21 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::f5ab:5f59:3b47:fc2e]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::f5ab:5f59:3b47:fc2e%5]) with mapi id 15.20.6319.021; Wed, 19 Apr 2023 13:43:21 +0000 Message-ID: <40547f10-e5f1-4e5d-d80c-6cb0d1902d7f@siemens.com> Date: Wed, 19 Apr 2023 15:43:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2] meta/conf/bitbake.conf: enable SRCPV support for AUTOREV Content-Language: en-US To: Srinuvasan Arjunan , isar-users@googlegroups.com Cc: ubely@ilbers.de References: <12187664.O9o76ZdvQC@home> <20230419024032.1263457-1-srinuvasan_a@mentor.com> From: Jan Kiszka In-Reply-To: <20230419024032.1263457-1-srinuvasan_a@mentor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR17CA0016.namprd17.prod.outlook.com (2603:10b6:610:53::26) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AS8PR10MB7160:EE_ X-MS-Office365-Filtering-Correlation-Id: 8632aaac-ce8e-47c5-dcda-08db40dc0a39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GBP4i/Dp2NurJyetUZPZQ96QpA/QNKEEFskJjzobm4VvovR+MlZnBAW3bb5CKoDdppp5ic/vsGTG75dP+qx3GGdAWhC3b/cgQ3CpEPsV+ac9/EQomHoBzjxatW19fMnBoAZAb3yGN/D9nQ5qjLEsYD8szBQ1FuZwtdGshEl6NpKXS/MZ/rTrYSK1dpTfxqgJHxEAXxcwD8WIC43mEauBQ3geR8tDHEKTF75VTxI8umu770mOZvPfY3IzuqcRG7Df/7+h7ppjlya4TmxEXUkxVhJT4vvs1lqLHCqbVdVto4ohkEd1oh1Qnbwtlcuxk2oTZ0UgdeQP3nY2/npIb8zMURee9gdNZIgmTeIrZGe2KXjoBQpvdGYNVJXb9Y98cVgLl4NpiBJn27ye/FvMjs8ZmdZYZncTW9ooAMMSGfoW9NrFiqZXT0K8HaVQZ+OaDu2S43/SFllfZ4YR0XAYud3C+r2p27RpHskl+Igjtibr1RuCYG6AgEkxbem7cEVtE3wV7GVHWX8qInzxtwXTAE6kpCRz+uSlVtS4eBOgv2/MDTUBDNfI0bhAxxgbkcD/9InIMN5Aprj4n8EGribUu9HZcNDFdibAq/U61rRIFqSwyDqFBrrYTqUjgmLWTlLV28IFWL6u8CFGeDkK9ZYioqihGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(451199021)(31686004)(36756003)(38100700002)(44832011)(2906002)(5660300002)(86362001)(31696002)(8936002)(8676002)(66476007)(66946007)(41300700001)(4326008)(66556008)(2616005)(83380400001)(82960400001)(6506007)(26005)(316002)(186003)(53546011)(6512007)(6486002)(478600001)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUQ2dTY2NXJKUm9KS3VYWnQ2VlVCUyt4TWhlekQ0WVA0UHJEZVM1R0FESi9i?= =?utf-8?B?WGF5Zi9ja2ZNcktoc1YrcEJWY2RjOGI5ZW9Ic3VYR3RTQTdHdWR0LzlmWjJ3?= =?utf-8?B?UGlTRlphWVRiUGEyaEJGcDBldFZNVGJSMDVrMlI1UnBLT1FOSEUxaXJ1SEdM?= =?utf-8?B?djlMelFwTjBnMHdRWmxEenRLalhnbXFyenRyVXIxTUx5WnZEQ3lCVkIwYVpB?= =?utf-8?B?MkgxbFptc21Dei8zOVIrdjN5c3ZCcWJKRnByc3h3UGpHZ2pPWnFkTWhGSTRt?= =?utf-8?B?Tlp6ei9iaEFnUVk2VzNCTmpKSEtXSGxwY3NsSUVGdVljZ3NGYlhROTJiMFZ4?= =?utf-8?B?a2kyYXd5clN6K0tnQkVHZTFjREJUZGZ4eSt2ektKRG5xMEd1NG81aTJya09M?= =?utf-8?B?K2lBS3FUTjJUNDJtaUI1eDI2K2pLOVJOKzFFbFBYUGM0c2lqU3lGLzVNOU1O?= =?utf-8?B?NjBOV3hUTUFpRGh5UVhtWTlVb2RLZUdPK3VIdDlGeGV5QWdlaUZvM1VFcERG?= =?utf-8?B?MCtvaVdqVVpVcnhIWU5QcHFwRUhUTk9EcEh0eDVoU0prTGptYTJBamVyRmFJ?= =?utf-8?B?S25tL1VtSkswVFZkZ1grTExYRWxzREpxT2NNbUNJVWlVRVNLbFJkVFhkTU03?= =?utf-8?B?enh5aHBCNkhySDlMUHhZUnhpZWRwSDlESUROQ0JGM2dJdStXNmZXMjF3NUdS?= =?utf-8?B?VnZwVllFMExoZFBlVlZkWmRlOU4xdEpoY2FPNVp6THlTRkhVZ0ZnVVBCYUY3?= =?utf-8?B?YVJQK1dQbTVYdTZ0UzN5RW9jenhqaDRqbVJwVG04d0pwUGloV1U4b056bjV2?= =?utf-8?B?NDRlZWlacStNdWNVOGd6VHVjNEVqQkMxNVZhTWRwUmV3UDUwSTlPSlU2RTJR?= =?utf-8?B?cnZGZUhLRnhBYXd1UlAvOXYyOUU0dlNPN0xJbDlqZW9rN1BNTnBUSklBQzJX?= =?utf-8?B?bjd3bVE5S3RUZ2RIMjAwT0V5dDVPNDdpWElpWGRFdnpQWVdTSktsMjFOY29N?= =?utf-8?B?amdZZE5DbEs5TmJUWC90Q3oxeW45eXhhdzNpOURkSk1KNnBPbXAwRjdGRHhp?= =?utf-8?B?S1pJbUIvdUhuMTFVdnF1cUVGOHk2SFNYdE1RelpBTjdodnN3M0xERFY4UU9J?= =?utf-8?B?ZGFRSU1relVDUm5YWFNXVklnS1NNTWg4Yi81SWlLZy83dHVkMzBLOURwL0dO?= =?utf-8?B?ek8wYjJ2OFJMU2F0WnpBTWRKekhNWUUxMVd4emwwKzYzTW1sSDdVTUp3VGoy?= =?utf-8?B?Zk5kMFQvbXZyZ3g0cFE2TUl0anJqc01IYUVNbU5SNGZIL3VFQk1DT2ZnQUt5?= =?utf-8?B?UkhacmtCTmt3WC9ITklBbzl2UUQ4UkpLL1UvVzd4dFdRNGs1MGt5c3FLTWxi?= =?utf-8?B?aW1UT2ovZW1Xc0Y5UVpQd2JsRkdaT3dlSlEzM25udmJUdWdmY0IxN2N1ZjNh?= =?utf-8?B?TWlwNGptUmVUSW9rQ20zQ25SZjNaMXI1cTRuNHRDOUJsWEZIVVFzalhxcGtl?= =?utf-8?B?YjhQamRhMDFXR2VPZEtvb21SVHRYdTlIS3ZBZk9BYU1kYVpLNkpLRmZwSWta?= =?utf-8?B?VFUwZTlRaitrYTlKdjJUUnM2WTgvSG1SWnFhRDE5clNIR0k2S1VvOC9kNjVL?= =?utf-8?B?Mk8vQXFLWFNBWEwzZnJ6eFlBWVcvWVVmZ3VSSk5DNC9CQkxUeFRvUTZoaG5o?= =?utf-8?B?VURQdVliZ2hlOXdDVGNjeTg0Z2Zpa3ZEaWlCRzM5WVJsL29XamZsK21tbTkw?= =?utf-8?B?Y0QvbW43aGNvN24ycEFBVmtFUEwwanR3UTEzMHdCZTZWVkRvSlpiQXpxYXFM?= =?utf-8?B?VjhZMGpnUjJKVW4yUUxTb0xzenVWc09UMG9aaFpoSEFVNzZaNTdsU1JuYWt4?= =?utf-8?B?SUw1aklBaWp6Y296MmhhSTkrZHU3U2RTN2tTTmIyOTd1U04xMlNkeTM1Y2Ux?= =?utf-8?B?czRJMzQvVEJCT3J0S3p3QVg2QWJ0VU9OUURlaW9RS2VmeW5sTi9SRXdXN2Vy?= =?utf-8?B?MXBTUGh5ekRsWFdpaWVKd2pxVHA0VmRDWVJQUnI5bWlpaFdpMzlSRUlhb3FP?= =?utf-8?B?VnduZnN4Z1ZQS2xaNDlGUGlvdThwRUFqN2FHOVVBMjZrUHBleVF4Nnhlc2lk?= =?utf-8?Q?GVmnDzoCbq2K7Ta05bIBMejdK?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8632aaac-ce8e-47c5-dcda-08db40dc0a39 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 13:43:21.3992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wFJCz9MZsomPyxwyspwZ0WpaLIbMwFIv1Mi4jgnIfJC772+rTnHJsuEtJFKlkATg7b7qudwbTkyWZdlO8oy6Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7160 X-TUID: bZBKIxKYtxvW On 19.04.23 04:40, Srinuvasan Arjunan wrote: > From: Srinuvasan A > > One of our downstream project recipe uses `SRCREV = "${AUTOREV}"` to get > the latest changes always, but this not works after bitbake 2 migration, > it throws the below error. > > do_fetch: Fetcher failure: Recipe uses a floating tag/branch without a fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use SRCPV in PV for OE). > > Till now we don't have support for SRCPV in ISAR, hence add this support > as like OE. > > Signed-off-by: Srinuvasan A > --- > meta/classes/base.bbclass | 10 ++++++++++ > meta/conf/bitbake.conf | 4 ++++ > 2 files changed, 14 insertions(+) > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > index 53550ae..17bebe9 100644 > --- a/meta/classes/base.bbclass > +++ b/meta/classes/base.bbclass > @@ -120,6 +120,16 @@ root_cleandirs() { > python() { > import re > > + needsrcrev = False > + srcuri = d.getVar('SRC_URI') > + for uri_string in srcuri.split(): > + uri = bb.fetch.URI(uri_string) > + if uri.scheme in ("svn", "git", "gitsm", "hg", "p4", "repo"): > + needsrcrev = True > + > + if needsrcrev: > + d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}") > + > for e in d.keys(): > flags = d.getVarFlags(e) > if flags and flags.get('task'): > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index f421050..124bf49 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -36,6 +36,10 @@ PR = "${@bb.parse.vars_from_file(d.getVar('FILE', False),d)[2] or 'r0'}" > PROVIDES = "" > S = "${WORKDIR}/${P}" > AUTOREV = "${@bb.fetch2.get_autorev(d)}" > +AUTOREV[vardepvalue] = "${SRCPV}" > +# Set Dynamically in base.bbclass > +# SRCPV = "${@bb.fetch2.get_srcrev(d)}" > +SRCPV[vardepvalue] = "${SRCPV}" > SRC_URI = "" > STAMPS_DIR ?= "${TMPDIR}/stamps" > STAMP = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}/${PV}-${PR}" Looks good to me. Thanks, Jan -- Siemens AG, Technology Competence Center Embedded Linux