Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Alexander Smirnov <asmirnov@ilbers.de>]

On 05/03/2018 06:58 PM, Henning Schild wrote:
> Am Fri, 13 Apr 2018 12:38:20 +0200
> schrieb Baurzhan Ismagulov <ibr@radix50.net>:
> 
>> On Thu, Apr 12, 2018 at 04:36:14PM +0200,
>> claudius.heine.ext@siemens.com wrote:
>>> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
>>> b/meta-isar/recipes-core/images/isar-image-base.bb index
>>> 6b0030b..d39a25e 100644 ---
>>> a/meta-isar/recipes-core/images/isar-image-base.bb +++
>>> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -16,7 +16,7
>>> @@ PV = "1.0" inherit image
>>>   inherit isar-bootstrap-helper
>>>   
>>> -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}"
>>> +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME",
>>> True)) if d.getVar("KERNEL_NAME", True) else ""}"
>>
>> If I want to generate an NFS rootfs w/o the kernel and an SD image
>> with one, how would I proceed? Do I understand correctly, the latter
>> recipe would list this line, and the former would not?
> 
> I think the answer would be with two image recipes that
> inherit/override each other. So the main one that is probably derived
> from isar-image-base and would be called product-nfs.bb and
> product-wic.bb would overwrite some variables from the -nfs version.
> 
> That patch should be merged, i already heard from someone else who now
> cherry-picked that into their fork.

Started test build, will apply afterwards.

But, I've looked at this patch again, and I think that this line should 
go to image class instead of recipe, it's already generic enough. 
Otherwise you have to copy this magic expression to every new image 
recipe (if you not inherit isar-image-base).

Alex