From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6543570718688280576 X-Received: by 10.28.184.135 with SMTP id i129mr1575427wmf.26.1525364332674; Thu, 03 May 2018 09:18:52 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:9314:: with SMTP id v20-v6ls425422wmd.7.canary-gmail; Thu, 03 May 2018 09:18:52 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr0ipJiO2vR5q9UcedVD1VYdcvfgyzVKZ9NJ7u5gNyQyvo7q6l4ESSa799FtkHFRRYPAFx3 X-Received: by 10.28.50.193 with SMTP id y184mr1244872wmy.4.1525364332108; Thu, 03 May 2018 09:18:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525364332; cv=none; d=google.com; s=arc-20160816; b=K52+NFb5f+zdLsYX68Ag0MHeTDz6NPydgU/nUHa00+RBtIs/EXlgTduEqBuvpY4tqq iOAJvpdAkZxNJJB64eXQenqVCIRhSp1jROsDPxr370y0vklUSXTOFv7/OP6vWchtnN9s SCXz38BXaTNfbEaOaYuNgV2b9QZ8uUJqed+jWQad35V/LWWne2bbk8mW0sbirzip9sKn SJCkbFPSVOnSoiXqdyOcT7osNzvO8dalCUFprTqxRQW73/f2oBLEdolBNIjtwaPAecZs wxOQGxi6GfnkkkMHjAz3sRmdyUVDVLzDhm6dpl6n5jlhsYw8A94/bI5sg9OeV1ab6ofX ggvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=U9b34CbktTTqe2uVECLauNxPTmBTkMqCjFO6kIqBbgQ=; b=ltD9jXpGFcF/P2voEbB2K2sd/K8UuPtmmJ1WGI0onUTWI1ZW+3aZuWt0tOJERsGIna x/I++Y6YoiAlI+FHZnpggWPKe3jmGALbkLveLTuCakTA3THjKQiomzF/QR5RDEzvhrE9 vrVnx6thbE6KLDqWpaF84Gs36iUKV7GzV2R87eByTYJd3aNocC5/r4ARj0OZpMNxIRW6 PYJ6ek9HurFseuZ1XzodJ14vW1S6GL4Ywh4jjAHeHJhkUpNCnUh5n/aoT9MqA7ym3r+C 9b1SXsOBfvdOBanUYc2Lir+wCzQheIZzSste1gTlUi9sjkHQPkqHL562SfNfu+jUgJvZ THsQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id e17-v6si539287wri.1.2018.05.03.09.18.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 09:18:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w43GIlCZ027588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 3 May 2018 18:18:49 +0200 Subject: Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional To: Henning Schild , isar-users@googlegroups.com Cc: Baurzhan Ismagulov , Claudius Heine References: <20180412143614.31202-1-claudius.heine.ext@siemens.com> <20180412143614.31202-2-claudius.heine.ext@siemens.com> <20180413103820.GC6488@yssyq.radix50.net> <20180503175819.15695d54@md1pvb1c.ad001.siemens.net> From: Alexander Smirnov Message-ID: <41086dec-f797-faa1-8b8b-6fdeaf83f211@ilbers.de> Date: Thu, 3 May 2018 19:18:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180503175819.15695d54@md1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: KsMv9Xcoug/D On 05/03/2018 06:58 PM, Henning Schild wrote: > Am Fri, 13 Apr 2018 12:38:20 +0200 > schrieb Baurzhan Ismagulov : > >> On Thu, Apr 12, 2018 at 04:36:14PM +0200, >> claudius.heine.ext@siemens.com wrote: >>> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb >>> b/meta-isar/recipes-core/images/isar-image-base.bb index >>> 6b0030b..d39a25e 100644 --- >>> a/meta-isar/recipes-core/images/isar-image-base.bb +++ >>> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -16,7 +16,7 >>> @@ PV = "1.0" inherit image >>> inherit isar-bootstrap-helper >>> >>> -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}" >>> +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME", >>> True)) if d.getVar("KERNEL_NAME", True) else ""}" >> >> If I want to generate an NFS rootfs w/o the kernel and an SD image >> with one, how would I proceed? Do I understand correctly, the latter >> recipe would list this line, and the former would not? > > I think the answer would be with two image recipes that > inherit/override each other. So the main one that is probably derived > from isar-image-base and would be called product-nfs.bb and > product-wic.bb would overwrite some variables from the -nfs version. > > That patch should be merged, i already heard from someone else who now > cherry-picked that into their fork. Started test build, will apply afterwards. But, I've looked at this patch again, and I think that this line should go to image class instead of recipe, it's already generic enough. Otherwise you have to copy this magic expression to every new image recipe (if you not inherit isar-image-base). Alex