public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Chengshu Mou <muchengshu@gmail.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH] fix: unsupported value of disk format in ovf
Date: Mon, 19 Aug 2024 23:49:42 -0700 (PDT)	[thread overview]
Message-ID: <41452880-d4fc-4bb5-930d-6850b26f6e47n@googlegroups.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1650 bytes --]

Hello guys,

I have a patch to fix the unsupported value of disk format in ovf file 
generated by Isar. Details are as follows:

Affected part: 
Images for VMware and VirtualBox.

Modification: 
Add ‘VMDK_SUBFORMAT’ into template vars of ovf.

Reference issue: 
https://github.com/ilbers/isar/issues/106.

Patch: 
From 792a013b26a474696d11a31a8bd069554b10b190 Mon Sep 17 00:00:00 2001
From: "Mou Chengshu(Ben)" <chengshu.mou@siemens.com>
Date: Tue, 20 Aug 2024 13:28:06 +0800
Subject: [PATCH] fix: unsupported value of disk format in ovf

---
 meta/classes/imagetypes_vm.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/imagetypes_vm.bbclass 
b/meta/classes/imagetypes_vm.bbclass
index 56410de9..4da42447 100644
--- a/meta/classes/imagetypes_vm.bbclass
+++ b/meta/classes/imagetypes_vm.bbclass
@@ -60,7 +60,7 @@ macgen() {
 
 OVA_VARS = "OVA_NAME OVA_MEMORY OVA_NUMBER_OF_CPU OVA_VRAM \
             OVA_FIRMWARE OVA_ACPI OVA_3D_ACCEL \
-            OVA_SHA_ALG VIRTUAL_MACHINE_IMAGE_FILE"
+            OVA_SHA_ALG VIRTUAL_MACHINE_IMAGE_FILE VMDK_SUBFORMAT"
 
 IMAGE_TEMPLATE_FILES:ova = "${OVF_TEMPLATE_FILE}"
 IMAGE_TEMPLATE_VARS:ova = "${OVA_VARS}"
-- 
2.39.2

Please have a look, thanks.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/41452880-d4fc-4bb5-930d-6850b26f6e47n%40googlegroups.com.

[-- Attachment #1.2: Type: text/html, Size: 2203 bytes --]

                 reply	other threads:[~2024-08-20  7:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41452880-d4fc-4bb5-930d-6850b26f6e47n@googlegroups.com \
    --to=muchengshu@gmail.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox