public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: scmi <schmidt.msmichael@siemens.com>, isar-users@googlegroups.com
Cc: stefan-koch@siemens.com, christian.storm@siemens.com,
	michael.adler@siemens.com, simon.sudler@siemens.com,
	cedric.hombourger@siemens.com, adriaan.schmidt@siemens.com,
	felix.moessbauer@siemens.com, ubely@ilbers.de
Subject: Re: [PATCH 1/1] fix snmp in total set vars
Date: Thu, 27 Feb 2025 14:55:23 +0100	[thread overview]
Message-ID: <41a581d2-1e93-4796-9395-432c3cb88764@siemens.com> (raw)
In-Reply-To: <20250227101951.1586563-2-schmidt.msmichael@siemens.com>

On 27.02.25 11:19, scmi wrote:
> Fixes an issue which inhibits snmpInTotalSetVars to increment correctly
> ---
>  agent/snmp_agent.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/agent/snmp_agent.c b/agent/snmp_agent.c
> index 9913a968e1..c728059ac8 100644
> --- a/agent/snmp_agent.c
> +++ b/agent/snmp_agent.c
> @@ -1908,6 +1908,8 @@ netsnmp_wrap_up_request(netsnmp_agent_session *asp, int status)
>      }
>  
>      if (asp->pdu) {
> +	int command = asp->pdu->command;
> +
>          /*
>           * If we've got an error status, then this needs to be
>           *  passed back up to the higher levels....
> @@ -2030,7 +2032,7 @@ netsnmp_wrap_up_request(netsnmp_agent_session *asp, int status)
>          if (status == SNMP_ERR_NOERROR)
>              snmp_increment_statistic_by(
>  #ifndef NETSNMP_NO_WRITE_SUPPORT
> -                (asp->pdu->command == SNMP_MSG_SET ?
> +                (command == SNMP_MSG_SET ?
>                   STAT_SNMPINTOTALSETVARS : STAT_SNMPINTOTALREQVARS),
>  #else
>                  STAT_SNMPINTOTALREQVARS,

Wrong list? :)

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/41a581d2-1e93-4796-9395-432c3cb88764%40siemens.com.

           reply	other threads:[~2025-02-27 13:55 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20250227101951.1586563-2-schmidt.msmichael@siemens.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41a581d2-1e93-4796-9395-432c3cb88764@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=christian.storm@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=michael.adler@siemens.com \
    --cc=schmidt.msmichael@siemens.com \
    --cc=simon.sudler@siemens.com \
    --cc=stefan-koch@siemens.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox