From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6743100217749405696 X-Received: by 2002:a17:906:6d4:: with SMTP id v20mr10959465ejb.223.1570174318520; Fri, 04 Oct 2019 00:31:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:69c6:: with SMTP id g6ls702599ejs.10.gmail; Fri, 04 Oct 2019 00:31:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLVGSHieD2BcQ370R7GS0GQpw4/pEKo/KoyFjDbi1k8FcS3oRK9f3sXX50R16QcWnnUKcX X-Received: by 2002:a17:907:211c:: with SMTP id qn28mr11266877ejb.244.1570174317977; Fri, 04 Oct 2019 00:31:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570174317; cv=none; d=google.com; s=arc-20160816; b=Tl7Qs7u8FOIGoRzPU5sg5E//Vu5C1oimJZ8OQDWW//BcAzqEC2jr/CgBLDXW7bhp2H CI3iAT9mXkDLB8SdAjax8/WeZ5750w0iwId5YeytOq5Czpha5k79FTaT480vSueQDgSq XwUDSyoDFo6/IlNK0ipnOf6AOSs6MKFn3rWeIkvn8xAoZoOpD3nun0L+KggnS1P42X69 Qb6uagAAVGqzBWM3rkRC7hnPchZhZ8m+Jp2pISexI1JMp2jQ8Z5MHZ2Qesx6N6X9cWSl lWBi8xeRBazdX4/MN99NUDNZJ6F3XjLAqZc9WNR2Wkb6FT0aw4utfEODMW6PaF4oG1zQ SqPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=oAJJifYhHDg/XDcEUILZVZSIFPbQpTHZ13wy4zxFK58=; b=XBCDn7vGkeaxDccsE2sK3Vc836nsdpVB7YOZecduOWHCNmVZM7innwN+dm/C3fJtJq 48JCustvprrvuK3zY4yD0opOWSLJxi2Gq8qITHmyLWCKXCLGKGL0WI7hSMlFPboEOGNx s6nzTTQLeYCQixYS7mpH8yq64gNQF/hDxjHnAoTR7y0TJbt9e2haShqIiDneLhbLwkiu qpuorBsJaos8JgAWeHp5LDY9RFJXWkDNOyGgIPdLSGCJlcOnnB2bTXcry/EdS1kmGWHc pdawgsOACud4IJMJgGORHIIk3zHktXVKXchTEx3d97+ihrk1BbTDOp/4NhEbZVU3xIpm joBw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id c31si362753edb.0.2019.10.04.00.31.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Oct 2019 00:31:57 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x947Vv5b006337 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 4 Oct 2019 09:31:57 +0200 Received: from [139.22.119.224] (md1y04tc.ad001.siemens.net [139.22.119.224] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x947VvlC023622 for ; Fri, 4 Oct 2019 09:31:57 +0200 Subject: Re: [PATCH v2] dpkg-base: Warn about unmounting problems To: isar-users@googlegroups.com References: <20191002105620.2823-1-ibr@radix50.net> From: Jan Kiszka Message-ID: <41b5703a-b66d-ae86-3be3-2f2f59a9f823@siemens.com> Date: Fri, 4 Oct 2019 09:31:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191002105620.2823-1-ibr@radix50.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: q3YwsH/TVmf0 On 02.10.19 12:56, Baurzhan Ismagulov wrote: > From: Baurzhan Ismagulov > > If a problem occurs, log umount's error messages. Wait for the processes to > terminate and retry. If that doesn't help, warn the user about retrying > every 10 s to avoid clobbering CI logs. > > Signed-off-by: Baurzhan Ismagulov > --- > Changes in v2: > - Warn after some time. > > meta/classes/dpkg-base.bbclass | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 2e8a0d1..006d8b1 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -1,5 +1,6 @@ > # This software is a part of ISAR. > # Copyright (C) 2017-2019 Siemens AG > +# Copyright (C) 2019 ilbers GmbH > # > # SPDX-License-Identifier: MIT > > @@ -78,8 +79,14 @@ dpkg_do_mounts() { > } > > dpkg_undo_mounts() { > - while ! sudo umount ${BUILDROOT} 2>/dev/null; do > + i=1 > + while ! sudo umount ${BUILDROOT}; do > sleep 0.1 > + i=`expr $i + 1` > + if [ $i -gt 100 ]; then > + bbwarn "${BUILDROOT}: Couldn't unmount, retrying..." > + i=1 > + fi > done > sudo rmdir ${BUILDROOT} > } > Looks good to me. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux