From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6925447760545054720 X-Received: by 2002:ac2:5c51:: with SMTP id s17mr2767383lfp.580.1612536335525; Fri, 05 Feb 2021 06:45:35 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:97c5:: with SMTP id m5ls1722906ljj.10.gmail; Fri, 05 Feb 2021 06:45:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZWyHV+eBT/tzSUtpH6v+xvCo1C3c27RZ9R+lfSOSjw+cV1pC0PdyiNFLOMX+9aOx9Rg3O X-Received: by 2002:a2e:9a52:: with SMTP id k18mr2870173ljj.249.1612536334462; Fri, 05 Feb 2021 06:45:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612536334; cv=none; d=google.com; s=arc-20160816; b=UdEHVf444GdddhpCotVlHOEfUI9UqPDNuZojMFklObGx6PBPs3wbRutpsZsIzIBD0d pfR58iNCwIDSaidOzhZBS5cEWqc4d01hYQaFmaCrM5KNjGz/0CVskF543h/Y0PK1wMMb GVWEA+LX1aYgJe9d1OKi63RJnxCty1TyQTflWVBgwwA/N8BXmInID+p9r2quewyLC8v+ 4NMopgWEL5V4T6t8RtJ3IFFLd02T/KK86mcmowVrnIXZg7tdD8kKPPoHQPmZ5UyGpHQj YnDfKNnitAOxnvpirzr+uHjRakAhxS7LnZoP/mypBqDV/pU945YdxF4SDkprHfLo7Rix qvoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=Z2MJA4uesJESPN69ikt79oVMrD7stxhE3wyC61vwQUk=; b=BvIOsQ8V7LiPIFsgvYfmkS9X3OcwMPkeMZDJsphXq2TF4eq6vy7Xl/Q9AbmvTXEUyh inYLxnm2Vh1HVkDn5e5oxGONQ4DHbZQHx9y3TFHrHOvZKjTmI0YVgqm4nj3ZyBgaW2dB Ll7FH6VEM+2H335kOzFIHqf1t6myDPX10fBzAzXwnUELoGVsbAiq2KU+egC9QncKnm4K Xqb5eKlpagwW+VK7QmlGZcI2ElIz7I0J2oYmJfcGsVoils5XCzjrLZtoPcWFYMB1Cyd8 BOjdWTZSYj68pusrVEXsVPH3RJyT2N0EUpL84UNXIabSxrZAOQfDj3K/Pg87yWdt57xN DChQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id m17si281540lfg.0.2021.02.05.06.45.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Feb 2021 06:45:34 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-46-82-214-37.mgts.dynamic.pppoe.byfly.by [37.214.82.46] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 115EjWcV021317 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 5 Feb 2021 15:45:33 +0100 Subject: Re: [PATCHv3] wic/plugins: fix kernel version detection for bios To: isar-users@googlegroups.com References: <20210205114812.6370-1-henning.schild@siemens.com> From: Anton Mikanovich Message-ID: <420a0704-56cb-fad5-2d51-a6cdffb7bc83@ilbers.de> Date: Fri, 5 Feb 2021 17:45:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210205114812.6370-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: Jtgz3jg04NXJ Thanks for finding. This issue can be found not on even kernel version numbers, but on all version end on 4 and 6, because '-amd64' is used as char values to be stripped both from begin and from end. Usage of strip() looks completely wrong here. Looks good to me. 05.02.2021 14:48, Henning Schild wrote: > From: Henning Schild > > When building an image with legacy bios using wic, wic can fail to pick > up the initrd. > > ERROR: _exec_cmd: install -m 0644 /build/tmp/work/debian-buster-amd64/bla-image-qemux86-64-wic-img/0.2-r0/rootfs/boot/initrd.img-4.19.0-1-amd64 /tmp/tmp.7x9N9Wo4wZ/bla-image-debian-buster-qemux86-64.wic/tmp.wic.r10macew/hdd/boot/initrd.img-4.19.0-1-amd64 returned '1' instead of 0 > output: install: cannot stat '/build/tmp/work/debian-buster-amd64/bla-image-qemux86-64-wic-img/0.2-r0/rootfs/boot/initrd.img-4.19.0-1-amd64': No such file or directory > > The mechanism used to "cut off the end" seems to cut off too much. > >>>> "vmlinuz-4.19.0-14-amd64".strip('-' + 'amd64') > 'vmlinuz-4.19.0-1' > > But indeed we would hope for 'vmlinuz-4.19.0-14'. Seems that "even" > revision numbers trigger the problem, while "odd" works. > > Signed-off-by: Henning Schild -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov