Fwd: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

Hi Claudius,

Any feedback on Jan's question (see below)?

I've applied v10 series "Fix usage of additional apt keys and repos" 
from Andreas, this results that your v4 series "Cleanup rootfs creation" 
has to be rebased. I can rebase it - no problem - but all pending 
questions should be answered first.

Regards,
Maxim.

-------- Forwarded Message --------
Subject: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS 
usage
Date: Fri, 26 Apr 2019 13:50:50 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Claudius Heine <ch@denx.de>, Maxim Yu. Osipov <mosipov@ilbers.de>, 
claudius.heine.ext@siemens.com, isar-users@googlegroups.com

On 26.04.19 13:31, [ext] Jan Kiszka wrote:
> On 26.04.19 09:36, Claudius Heine wrote:
>> Hi Maxim,
>>
>> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>>> From: Claudius Heine <ch@denx.de>
>>>>
>>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>>> distributions.
>>>>
>>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>>> ---
>>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb 
>>>> b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> index 08b068f..3e96281 100644
>>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = 
>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>>    ISAR_BOOTSTRAP_LOCK = 
>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>>    require isar-bootstrap.inc
>>>> +# We only build debian host buildchroot environments
>>>> +DISTRO_APT_KEYS = ""
>>>
>>>   From the first glance this modification limits functionality.
>>> It looks like a hack and I would suggest to avoid this modification.
>>
>> Well it is a fix and that limited functionality was already present but
>> just implicit, hidden behind some bug and the cleanup just made it
>> appear.
>>
>>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>>> avoid confusion between target and host apt keys.
>>
>> Good idea. But that would be a new feature/improvement.
>>
> 
> If that is just about adding and documenting another variable, let's not discuss 
> about when and who because just doing that will already be faster, even if it's 
> a "drive-by" improvement /wrt this patchset.
> 

OTOH, I don't get the problem yet from just reading the commit message: 
Wasn't DISTRO_APT_KEYS designed to be a superset of all needed keys? We 
are appending raspbian to it when using that distro. So, we are at least 
missing the reasoning here why that model didn't work and cannot be made 
working for the host/target case. And then we can refer to that when 
introducing split key sets.

Thanks,
Jan


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux