public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: "Heinisch,
	Alexander (T CED SES-AT)" <alexander.heinisch@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "Moessbauer, Felix (FT RPD CED OES-DE)" <felix.moessbauer@siemens.com>
Subject: Re: [PATCH] meta: Allow to specify the snapshot date in the upstream format.
Date: Mon, 7 Oct 2024 13:27:12 +0200	[thread overview]
Message-ID: <42653669-5e3a-4591-a6ed-dc4cf687c3cf@siemens.com> (raw)
In-Reply-To: <AM7PR10MB3320D5E5FA48F34EC844D5BF867D2@AM7PR10MB3320.EURPRD10.PROD.OUTLOOK.COM>

On 07.10.24 13:21, Heinisch, Alexander (T CED SES-AT) wrote:
>> Nicely minimal invasive - but now you should also document this, just like > ISAR_APT_SNAPSHOT_TIMESTAMP. And naming should be aligned.
> 
> Sure. Just wanted to get feedback early, before spending much time on docs 😊.

It will definitely help with the kconfig approach, avoid non-working
conversion attempts there.

Let's just rename the var to ISAR_APT_SNAPSHOT_DATE and also clarify in
the doc that to masks ISAR_APT_SNAPSHOT_TIMESTAMP when both are provided.

Jan

-- 
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/42653669-5e3a-4591-a6ed-dc4cf687c3cf%40siemens.com.

  reply	other threads:[~2024-10-07 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07 10:47 alexander.heinisch via isar-users
2024-10-07 11:12 ` 'MOESSBAUER, Felix' via isar-users
2024-10-07 11:13 ` 'Jan Kiszka' via isar-users
2024-10-07 11:21   ` 'Heinisch, Alexander' via isar-users
2024-10-07 11:27     ` 'Jan Kiszka' via isar-users [this message]
2024-10-07 11:30       ` 'Heinisch, Alexander' via isar-users
2024-10-07 11:27 alexander.heinisch via isar-users
2024-10-07 11:34 ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42653669-5e3a-4591-a6ed-dc4cf687c3cf@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=alexander.heinisch@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox