From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6596658663135379456 X-Received: by 2002:a2e:9b01:: with SMTP id u1-v6mr1078064lji.11.1535904283497; Sun, 02 Sep 2018 09:04:43 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:2957:: with SMTP id u84-v6ls1598657lje.9.gmail; Sun, 02 Sep 2018 09:04:42 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZdP3ryl7F76xdZk0nHQ/SZlOoxud6Gm+KwMGxW0oNfpmGsK83UGa3FE0B4YENPaNGDp5k7 X-Received: by 2002:a2e:9d44:: with SMTP id y4-v6mr1049335ljj.19.1535904282937; Sun, 02 Sep 2018 09:04:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535904282; cv=none; d=google.com; s=arc-20160816; b=KL04UpmzBU2+R17dSWIX6Dv/AxbjB/4QQ59emx2aeQdtsWDzrm4fAaUFYGw0RsZf7E qNQu8ct2eu+9a0F+uK1NmlSwUD+iKuAWPQwvBsgUkYYsmsNfEN4HB1oi5JWxR/sdaUC3 R5LqdPON+cZb9mufd5bKHE5L1PDt7aWLl3kC4QLzN5DfW24/cjM+86jtXV+M4wHmKcLN UlMycSZ+y4cQuyd9BcVB4wmoBEGUv4OANJMjQbsreCDfbfobKs50l4AZhex7bSKFo7wG LgOTNYl8c5j/wRW2sIJUYCo0ln5qY6ZzIxWtjmaWCNGJ0592+GR5p/jZ+mpz1MMR6QbI AlQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:references:in-reply-to:message-id:date :subject:to:from:arc-authentication-results; bh=9mqM6XPgnFSMBExG9H68FfrbQ2IKVa5P+4B5dcKSXfg=; b=ick3UCjNcXcGcNqlpRXyvYZcVnXZO921HZyjrbLhmAO/99pt+u0PXbnT+7rgMvkpNA 6NgfqlYPSvczILJEx4003T/dSnpKNtALZ9t8hCKsAwBhAnVydDz7AUTEs4WJlfhqx1YY KwDvDVLYUGW5yEvVONDmyVHsMO+8Ssk/15U5+WhPP7kfQ0qK7KkBMbSk21oDlNgPAIEe vKwPH9u4pWy3Y51wxv8qyMfgA8L9yCvq8LBdz1PgifEXFp0KRONM2xOuTQP1EBVrebNY D3zuFVdjfUdb6FNmhxT7AWKm/tp+rWXmgTE9L40YoJs2gJTB9KX8Ue4mbQG6q81zD4G1 VUxA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id n42-v6si503191lfi.2.2018.09.02.09.04.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Sep 2018 09:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w82G4f5Z029333 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 2 Sep 2018 18:04:42 +0200 Received: from md1f2u6c.ad001.siemens.net ([139.22.32.125]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w82G4fqp004352 for ; Sun, 2 Sep 2018 18:04:41 +0200 From: Jan Kiszka To: isar-users Subject: [PATCH 3/6] dpkg-base: Relocate dpkg_runbuild and adjust comments Date: Sun, 2 Sep 2018 18:04:37 +0200 Message-Id: <4394c1a505ad889a48482e4f177542cf7c927e4b.1535904280.git.jan.kiszka@siemens.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: References: In-Reply-To: References: X-TUID: hP0J8dxVPBJs From: Jan Kiszka This puts this placeholder in the context of its task definition and also improves the comments related to dpkg_runbuild as well as dpkg_prepare. No functional changes. Signed-off-by: Jan Kiszka --- meta/classes/dpkg-base.bbclass | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index 5826357..84c56af 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -50,13 +50,10 @@ PPS ?= "${@get_package_srcdir(d)}" BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" -# default to "emtpy" implementation for dpkg_prepare() and dpkg_runbuild() +# Empty do_prepare() implementation, to be overwritten if needed dpkg_prepare() { true } -dpkg_runbuild() { - die "This should never be called, overwrite it in your derived class" -} MOUNT_LOCKFILE = "${BUILDCHROOT_DIR}/mount.lock" @@ -89,6 +86,11 @@ do_prepare() { addtask prepare after do_patch before do_build do_prepare[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" +# Placeholder for actual dpkg_runbuild() implementation +dpkg_runbuild() { + die "This should never be called, overwrite it in your derived class" +} + do_build() { dpkg_do_mounts dpkg_runbuild -- 2.16.4