From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7320571525847842816 X-Received: by 2002:a25:8d01:0:b0:dbe:9e89:72aa with SMTP id n1-20020a258d01000000b00dbe9e8972aamr1801711ybl.37.1704459102447; Fri, 05 Jan 2024 04:51:42 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:622a:34c:b0:427:a283:e24c with SMTP id r12-20020a05622a034c00b00427a283e24cls693743qtw.1.-pod-prod-09-us; Fri, 05 Jan 2024 04:51:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBgUCYXdTJ8PC4/GJGRwlyMEJ748UciQnAOc8gDJ4ywq1yQoLmerziOrMsa6zUaiSiFFML X-Received: by 2002:a05:620a:7f8:b0:781:b4a4:d793 with SMTP id k24-20020a05620a07f800b00781b4a4d793mr1951796qkk.149.1704459101510; Fri, 05 Jan 2024 04:51:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1704459101; cv=pass; d=google.com; s=arc-20160816; b=dW1WWrn5Ck54bAcShWzLRy35i0pDeZ0ICEk6q77DpT2SASt0oLt+GSH3css6xW3X+j DaZvR03i3anFYDI+Bm5zOq1/0v9TnFVQslGJFwLgbE63rE+T+erKkNt9zB1UwuFev4sl CVgKOkmvfnwxA0LfZAT4Re17Xf89A+Lz2h/utUa2KdhehGDw3r2WU96MEPrAByIzVu+O zslpGDZS5T4xDh6gXybtmGwm8Am58G4ZRLGykPJoTL11XXsFV5ucTsGdeq3cL24qvQGH NGHnnfMeOtVigVcpPpbZPORaYVcIj4ZHrRvkbd8Sjg5XVwJS55yYRdWOqRg4TeVJRVxa 9Epg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=JTO9X13x1uDWSfxT9rdjNTXoYU4nGes6fzziUGDIuvs=; fh=kaJf5ZaNljRs0+NLwvLTfVDw2pLoGCeXr9nWUjeXZsQ=; b=ncArpo48mS8uAP2E+1VUcM+vXK4nqZDW6H9p6qJrigG457bdb4pEy/J5r0MRvvNrP6 KakNIRPQfhx08DYhUQB9LAEfRPMVLTzk4h3U/Huka8FSS5JKwmWEzluGcta1vZ/KZLkq 921oONhOkAfj5kOaZpH5RP4ioOp+D6Q5UWD1Uh9Cvq5CYLW3k7sqNpulmgq/mvIXiAKo XlFNQtEBCuB7x5YuRtHZBXyf5Q4wJHiyD3rkszhGp7HEXqNtPmH8e6zkXYtIxW0Uz5iE /pu82aGRxrzfQe6WxnRTHFcxkhoK6cxmCKS7+YAmME+nJjC4OftiItyShIAu4Rnhm+nM FPhA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=cNwFPYrj; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:260e::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20601.outbound.protection.outlook.com. [2a01:111:f403:260e::601]) by gmr-mx.google.com with ESMTPS id v26-20020a05620a0a9a00b0077f0dcac143si110931qkg.6.2024.01.05.04.51.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jan 2024 04:51:41 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:260e::601 as permitted sender) client-ip=2a01:111:f403:260e::601; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=cNwFPYrj; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:260e::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZBeONRONh/w/KTJ932FD1g1FxEZszfwmIoZyVpO06hJa+v9NbBFGxb0GNjCycS7Q01sh1iuJ8WL7m2yuXqLwFnMIxbNIIT2ag/ml5npqFbbllEjETfa3grxoFwMHkjss+ZH1BFDkyARhtZmWw/90Sg8YAr/Hj4mnC5hn9x5qYQVTYNIfTI7shra1PXoRy72yv0yMYq0tDlpGlpCmQf6tcrGqP9rNZ3UzVNu2zOk54YMJepIhrZGVfdEuhQeX2nZMwCIx/jvyFLxw86wg14CVnrLkpVviLytKf4CITtHM0igpJVmugUZNBXn/yohWBzd7/BBh3puqx87TNcGRsfe01A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JTO9X13x1uDWSfxT9rdjNTXoYU4nGes6fzziUGDIuvs=; b=LICgaqLQCmx7BRwM+6KI7gpkbpOTwIUY9xQHy75U4KIief5xilKyFKQsChiWgW0k0fOCGUc6/+8MxTzndxfbGWdRyrRTEsYldO0PEy08RlmC87v5ptq0yjpdcWiVnUVYCyes119tc3FiJ9UcqTflqi4ZTEqxicNEjtzrY0RpOkTV4GmLxeKXnQfNwFR97qKK5QZ8l+Gz3DWfPcJ7jItFTxAi0XZet5lqoNJhucOwlVvKNA6rVGzI6Il9pd+E0djY/fCY+FWu7s1TlMCUma0p2MDpHgeC31WnTsTWReAvkvMFTcMEQsx9gta86dWm1S1X/N1qw1vKLM1ESLJqHlo8EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JTO9X13x1uDWSfxT9rdjNTXoYU4nGes6fzziUGDIuvs=; b=cNwFPYrjYPnkjV4X/JZ6YJ4NlcOCI1XSw2n+/aS5AbOegPD12awij2SSv62icS3kpOOi80xqef1r8NX79/Wb5xXl9WIj4abmtvpwKhGSSSTXTc/mIveu9Rx4xgsc1cWwsjofn08SzHtWUvTiya+Fj7/eZ/8LSqdzHHInvo20eILxbwBC8/etNZWLC0PdWj6mjvhEK5CYIFqF5OrhGgv1erfiXOEkZw9rf7JU/mfSEFZLfXvSPi9cQa1vgDQU5JlCLR0iK7HR4BEMvaC2vr75PdchlCcE7LnC8uH0w5YNHNwpvyG1uLyAtaz/J8nzZwed77rgL/Q1X0sYUOMBVaLitQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by PR3PR10MB3833.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:4a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Fri, 5 Jan 2024 12:51:39 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::96c7:d239:1723:8761]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::96c7:d239:1723:8761%5]) with mapi id 15.20.7159.013; Fri, 5 Jan 2024 12:51:39 +0000 Message-ID: <4468ef6f-5b19-4e1a-87cb-85c1edf10648@siemens.com> Date: Fri, 5 Jan 2024 13:51:36 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] classes/image-tools-extension.bbclass: remove prepare isar-apt part Content-Language: en-US To: Srinuvasan Arjunan , isar-users@googlegroups.com Cc: Srinuvasan References: <20240105111552.664182-1-srinuvasan_a@mentor.com> From: Jan Kiszka In-Reply-To: <20240105111552.664182-1-srinuvasan_a@mentor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0030.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::17) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|PR3PR10MB3833:EE_ X-MS-Office365-Filtering-Correlation-Id: 09cd6667-6c4b-446d-a152-08dc0ded0f1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gt1L3HIdEZ3tBc67cc2CcoMBb5jG4p+hY2N5HGw3n4GpW9xvu1a0/Ol83ETeAlI0P0jlVR3QjQBUjM+Ze0rsopCdDK+mccOEwIgXG/e1gA523jf6wowKjMBFtMAqINlw1jmXP36eFaIj4V1z6+WA7whBzQYjhU9PMT1qKfCTCPjptPhbjNZyE25ZM4izuLop3fCCZn9XfUhEfbELsbotfq4j33wAN1Cz+9PU6H6Xkc20LFyWSRwBK/9PLFs+VkFBygL+pTO8y8SQ8ArYXp9OlZsk8NFK4dukw7y1TIrm0LlV+iVARxqjmqazbiSct/Kaaw4KGg6+CcLrt/9bXJzqMHOsboRqp/EQA67X710o5WHlCQ/OWcEu7+AOyIRjccXFgXlX7kck9OIqaFjWPn2XxT/TgHMh40NTRx0OBOiRCDbTTATXy5vHTtDwHHMP8LNrv5/YjFj2jFnnJ34p9Qi0FMbfRuKTEWO67XwFDZUbouI8Y+mAp8C/TCQNW6IjAbucxcMzMAnczIYxyIjvxGC/14gWa5P1dKy3rfddTOZEltyhOJDmMwtElZluRZ8aMc9hNmL8MTl/zVEGvZ5moIn4AeRvwEM6mb1k5OOywjtcfVXdV+vVkJUCXcq5K4fafxduWmfPeHq3Ve58gXqafTBgxQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(136003)(396003)(346002)(366004)(376002)(39860400002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(66556008)(66476007)(66946007)(38100700002)(31686004)(31696002)(82960400001)(6512007)(6506007)(53546011)(86362001)(6666004)(107886003)(26005)(2616005)(2906002)(44832011)(5660300002)(36756003)(478600001)(966005)(6486002)(83380400001)(316002)(8676002)(8936002)(4326008)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUhOUkM1aHhRL1FQWm50cEpoeTdvSjlIejJUNEx2Vm1TSEc0UzNsc2YwTzNm?= =?utf-8?B?eUx2NFdWWjR5Ymt0a3hGaDJ3bk4zQXkxMmFEbmdjdmRZc1FTM1hNR01sNTUr?= =?utf-8?B?OTZnaXZBU0t0WEk0STBReXJnbGN3OG94M0djREVuUmVhQ0xYNmkydGZyYUdU?= =?utf-8?B?Vjk4MEJSNlhaVnBrYUtYOS83WkV4aXIwVk1aRG1BM0QwYk8rdmJzMGl0a1Zx?= =?utf-8?B?WW1CZWN1NUZBZTNWb0VUSDdrcndnODhKZGdIa0hjN29SYUY1MHdCVVBQc3J4?= =?utf-8?B?Sno0NXVPL1BMSTZSTkdBdEF5bStBUGpSQ3E1dTlOeHFYVTV3NTlHVjZSNWpT?= =?utf-8?B?YklUZVJFWUpNaVpkNm1OME9keU8rOHQyTFBmZGxzN2Q1eDlINTBvRzJUYWJx?= =?utf-8?B?a0xDZkhjOUZSN1VENlpXUEV6UFN3VXFMOHU5U3FEZ21YaUxHMHlzTUtGN0hP?= =?utf-8?B?SUlIRWswc2h3MFJhNVBmbU5SSU82U2JRVkpYTWJSbnZmUEx0SVZCR25SdE1Z?= =?utf-8?B?Q0ZxcFlwazZzbDc5dkxwMDRLajBGRHBsWElGT1JiMlBWZERheEF4a2VLOEZW?= =?utf-8?B?S202WG8wT1hOa096QUdOQjY5TnVkUzBYbHZlSVdVQjBoN29jdllUcGxjdnhK?= =?utf-8?B?aGQ4bGxlKzIyMU9Qa05kMG03VW5lc0p0TXc0Q3QwOVpvMEJ2ZjJUcndtRk1a?= =?utf-8?B?ZGtTc0pqdXRjVU84SGxib0RZQzhrWTNpbm5MWEI0S0pKcUIwcmN6dDBGaTRx?= =?utf-8?B?MGNhaTBuelE3Z0Y0dElnTWFGbzFqejNKVU90cUtyeGZscE0vVGtFZXdpYzNk?= =?utf-8?B?WWwzNmE0RFZHYlVqdWU1bjF5M0Zxa3ZndVpKbW1xWlRQbUFDamM2TUFkYWdH?= =?utf-8?B?RzZkOWJhbXRBUHNaZzhpNWl5bVplc1Z2RmFlMzV3OWFIb2x1b3hVKzcrN1Nl?= =?utf-8?B?czNQRExvbEJWTE1XQnNWZ2VlTUZUV2YrQU1NazlteFFKVXZQR2srQnBReVF5?= =?utf-8?B?MjdPS0tacTVwMUszT1hJTFpQNVZHdUFDK21Mbm5Yd3RrcnkvdG50TWJkdVBh?= =?utf-8?B?QWpzVkV2YUtoNlo3QS9mUWFyd1hDMk12QnBiN05uRmh4MWYyRjB2Vld6NUFS?= =?utf-8?B?RThJcVA1RTAwdmp1N2hXKzJSMjl4L05wcHVRRDhlTXB2SXBkZmJWeC9sTld1?= =?utf-8?B?dHIxZWFqd0d5alFpZUlhb3c2bzhLMXd1Qm1IVmk4SmdDei9aUmxIMnZ0c1ZI?= =?utf-8?B?NEZrS3A0RVRZLys1Z2pPVW1ma21kMWwvRlg3UENSTEdaOFo5VG5TODRwK3VQ?= =?utf-8?B?ZzJBUG9GYlpzSFVEdlRJalAyQldmd2R5OE5jek1JVlZhNkNvR1oxWXFRTG01?= =?utf-8?B?YWRaVnpqUWdpVlRYZmJkOUhockp0VkJacUw3RFpyK2xaZnlhNDNOSVRWUDFz?= =?utf-8?B?WG1jcUU2cHBRbk1PSVF3M1g4UVRRY3NTdVdGRlZoN3BRblVxVlU0VjFTbDFR?= =?utf-8?B?Q1Q1V25EZis1Mm1xR1VqSmdRangxSmJqT0JjUS85aGQ3aUVyRW9rcHdBanNu?= =?utf-8?B?NnMwQmU0RWhXbU91WC9BekVaWjBXS2didExob2I0K0hNalVOZUY2aDRJbkRq?= =?utf-8?B?azM4V096czFTM21CVGFWK2tscjNLclpHN2pFV3ZuSUZ1aGYvM1BlemNYSmtw?= =?utf-8?B?S1RDbDBoM2RwNWNKTEtGL2xOL0VyUjBGcThQOGxvYzBBRGR0NzJHVGhxZG12?= =?utf-8?B?Ym5oVHROS1Vka0I3SlNqbUZ3dnpZZStDemFpRHIyeERoaW9NT3hPemgwOWVG?= =?utf-8?B?YjRIckZOdHFpMlBBU3lhazhoNm8zcklIM1YvdTliMVRaS0t6eUlTaTJWQVVZ?= =?utf-8?B?T3lBaTVaNnY3LzZBMjZFVHNMekxXcU1FVnVwTmFzeGRzTUxXLy9XTjgrZ2VK?= =?utf-8?B?eHRYcDl0Z0h4SXlwRmVHVjdzeENNM0c0b1M2ZENnQnhsTFJQb1VueGNiV3Fa?= =?utf-8?B?ckdtOSsvN3hxV21mZWVTNTVnTElmb1E1bjJ3OWhkTzB0d3g0OWxtVmdxS01D?= =?utf-8?B?VCtMQ0QxNWg5MlpIWEZmdGlDQldkYktaMm1oeXoxL3dRR1lwdHh2MU9KUm9q?= =?utf-8?B?TTY2NGFqT3Q4dVR4ZEVJbFZnUFEzRHl2MUVPMWxxWktaTmJrQzNvdXNwcU95?= =?utf-8?B?QkE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09cd6667-6c4b-446d-a152-08dc0ded0f1f X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 12:51:39.4933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KR0xoDMa+HakVSvrmXo/oY00PYQTcmBG+7Wej/a6kjnGlTMnvgSnmZWHit33prRjq1o6Eu3zLmzEsJubMNUqRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB3833 X-TUID: u8Jvb2toOUxN On 05.01.24 12:15, Srinuvasan Arjunan wrote: > From: Srinuvasan > > Now isar-apt configured during sbuildchroot generation, hence remove the prepare > isar-apt part from the imager_run method. > > This changes depends on [1] > > [1]: https://groups.google.com/g/isar-users/c/k8ZNw3OkWLw > > Signed-off-by: Srinuvasan > --- > meta/classes/image-tools-extension.bbclass | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/meta/classes/image-tools-extension.bbclass b/meta/classes/image-tools-extension.bbclass > index 58799fcf..46bdf78b 100644 > --- a/meta/classes/image-tools-extension.bbclass > +++ b/meta/classes/image-tools-extension.bbclass > @@ -44,19 +44,6 @@ imager_run() { > distro="${HOST_BASE_DISTRO}-${BASE_DISTRO_CODENAME}" > fi > > - # prepare isar-apt > - schroot -r -c ${session_id} -d / -u root -- sh -c " \ > - mkdir -p '/etc/apt/sources.list.d' > - echo 'deb [trusted=yes] file:///isar-apt ${DEBDISTRONAME} main' > \ > - '/etc/apt/sources.list.d/isar-apt.list' > - > - mkdir -p '/etc/apt/preferences.d' > - cat << EOF > '/etc/apt/preferences.d/isar-apt' > -Package: * > -Pin: release n=${DEBDISTRONAME} > -Pin-Priority: 1000 > -EOF" > - > E="${@ isar_export_proxies(d)}" > deb_dl_dir_import ${schroot_dir} ${distro} > schroot -r -c ${session_id} -d / -u root -- sh -c " \ Good catch! I assume this is just redundant but harmless code now, right? If not, it should better be folded into a v4 of my patch. Jan -- Siemens AG, Technology Linux Expert Center