Re: [PATCH] isar-bootstrap: debootstrap --include flag to support https:// sources

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Jan,

On 04/12/2018 15.28, Jan Kiszka wrote:
> On 04.12.18 15:23, [ext] Claudius Heine wrote:
>>> @@ -138,6 +154,12 @@ def get_distro_components_argument(d, is_host):
>>>       else:
>>>           return ""
>>> +def get_debootstrap_includes(d, is_host=False):
>>> +    if get_distro_have_https_source(d, is_host):
>>> +        return "locales,apt-transport-https,ca-certificates"
>>
>> Those package names should be configured in the distro config.
>>
> 
> Means you would suggest to introduce two variables, e.g. 
> DEBOOTSTRAP_INCLUDE and DEBOOTSTRAP_INCLUDE_HTTPS to encode those 
> packages? Those could then be set in distro confs and simply used here.

Not sure about those names, but in principle yes. Package names are 
distro specific and should not be part of isar-bootstrap IMO.

Not sure why the 'locales' package made it through review, but that 
might just be because its just one package that is probably named like 
this in every distribution, past and future.

Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de