From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631131420328722432 X-Received: by 2002:a19:f60d:: with SMTP id x13mr1623990lfe.12.1543934809196; Tue, 04 Dec 2018 06:46:49 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:554c:: with SMTP id j73-v6ls2347565ljb.4.gmail; Tue, 04 Dec 2018 06:46:48 -0800 (PST) X-Google-Smtp-Source: AFSGD/WnmdbnoeR9la7ODTH/oOx3EKWN8i8xvBTu9hd4eYioD4NSZpZMhk9usChUsY+dpsnXtPgO X-Received: by 2002:a2e:9053:: with SMTP id n19-v6mr1897537ljg.12.1543934808724; Tue, 04 Dec 2018 06:46:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543934808; cv=none; d=google.com; s=arc-20160816; b=svP9dJNYfHqI5ylfxTkTNfb995Cqnbm4syb6IaiXpOvhpvNpvFY2I4p6zTnrYSV7bt ZpJWiMiYsIJ81wiZ8tLz+oj/nE7YQ6qr34+2c9ER9VzqnxrZY+2sUZgaM+WT3YnzZ1o3 2LEtVvPRUlYrML5cnAZRW3uoQbOIl0GHS2OVcEdcF1srYOLrgqWr0UJ7Nf+dRqMyWNw0 kbJjzjJtX+yjvyMLNuISXNlf7Ox4M2spsuru8Mq/vVNgblBy2qpPDY/TY2oZ7fT0sICz csKCGqnHzX5LDKbw7AhX5R5go8CAXZaCFIefxwlbBJn+AyiQPserySeEfxTy38kR5/qN 1bOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=pRL9Jv9eCCXTA9t9ZntdieAeVcTEq/nr1+Jm0vn1fZ8=; b=0FnlwlKT/CZdtAoFA0M+8QQuqUgWvJLrndAue4Zx8ud3/vhLUHF5MhzeMj1Gs2TvEc PykXN7Z6a2ioNSKN7lbyp63xHq3iWbzcAsWMJNeDxHwc+DOz1QFQ0+q1MiXZuBxYo50h 4IiNdIlUtfBuTbE2V0x/iLbbZ1LL0luF1GEsC6iFRch5bPYMnwCZmeo+dKdrpL8ff4My L6a0CP3SjOMq2/3LUi+JJ8x1O9tVMFQ+zCIJNrz3wwPf9g5pYm7Zyqb4TuwgAzHeJPjl nVAMjxt4enezFPk0ZP4sLsZpT72vmBInfRPBj/XVyoSoy77IXqlpNbhi+lnKv1H34hmR TcXA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id 205si472984lfb.2.2018.12.04.06.46.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Dec 2018 06:46:48 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id wB4Ekia3009354 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 4 Dec 2018 15:46:45 +0100 Received: from [139.25.69.181] (linux-ses-ext02.ppmd.siemens.net [139.25.69.181]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wB4Eki3c008208; Tue, 4 Dec 2018 15:46:44 +0100 Subject: Re: [PATCH] isar-bootstrap: debootstrap --include flag to support https:// sources To: Jan Kiszka , "Hosgor, Tolga (CT RDA DS EU TR MTS)" , isar-users@googlegroups.com References: <20181204133544.50621-1-tolga.hosgor@siemens.com> From: Claudius Heine Message-ID: <45323f2d-7dac-9b9d-6382-013b9ae1242c@siemens.com> Date: Tue, 4 Dec 2018 15:46:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: B9utwRNFu05g Hi Jan, On 04/12/2018 15.28, Jan Kiszka wrote: > On 04.12.18 15:23, [ext] Claudius Heine wrote: >>> @@ -138,6 +154,12 @@ def get_distro_components_argument(d, is_host): >>>       else: >>>           return "" >>> +def get_debootstrap_includes(d, is_host=False): >>> +    if get_distro_have_https_source(d, is_host): >>> +        return "locales,apt-transport-https,ca-certificates" >> >> Those package names should be configured in the distro config. >> > > Means you would suggest to introduce two variables, e.g. > DEBOOTSTRAP_INCLUDE and DEBOOTSTRAP_INCLUDE_HTTPS to encode those > packages? Those could then be set in distro confs and simply used here. Not sure about those names, but in principle yes. Package names are distro specific and should not be part of isar-bootstrap IMO. Not sure why the 'locales' package made it through review, but that might just be because its just one package that is probably named like this in every distribution, past and future. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de