Re: [PATCH] linux-custom: compile only those specified dtbs

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 02.08.24 19:03, 'Jan Kiszka' via isar-users wrote:
> On 02.08.24 13:41, 'Nicusor Huhulea' via isar-users wrote:
>> The current implementation makes a full kernel build and that means it will
>> compile all dtbs specified by the bsp makefile e.g arch/arm64/boot/dts/ti/Makefile
>> Currently the required dtbs are given by the DTB_FILES.
>>
>> These changes are checking if the DTB_FILES is specified, compile only those
>> and avoids compiling all the dtbs from the bsp directory. Otherwise build all dtbs
>> specified by the kernel source.
>> Preventing the automatic dtb builds is made by using target specific build
>> commands e.g KERNEL_IMAGETYPE
>> The compilation of the dtbs accepts the following formats e.g:
>> a) full path from the architecture directory:
>>    arch/${ARCH}/boot/dts/bsp_dir/test.dts
>>    arch/${ARCH}/boot/dts/bsp_dir/test.dtb
>> b) relative path from the dts directory: bsp_dir/test.dts
>> c) device tree blob file: bsp_dir/test.dtb
>> Compilation of the dtbs is somewhat similar to KERNEL_DEVICETREE from OE when
>> it comes to declaring the path to the dts, but for now in the DTB_FILES variable
>> only Device Tree Blobs(.dtb) needs to be declared due to the fact that is being used
>> in do_copy_boot_files task.
> 
> Can you provide some numbers on how much can be saved this way? Time or
> (I rather assume) space?
> 
>>
>> Signed-off-by: Nicusor Huhulea <nicusor.huhulea@siemens.com>
>> ---
>>  meta-isar/conf/machine/imx6-sabrelite.conf    |  4 +-
>>  meta-isar/conf/machine/phyboard-mira.conf     |  4 +-
>>  .../linux/files/debian/isar/build.tmpl        | 43 ++++++++++++++++---
>>  .../linux/files/debian/isar/install.tmpl      | 31 ++++++++++++-
>>  meta/recipes-kernel/linux/linux-custom.inc    |  6 +++
>>  5 files changed, 80 insertions(+), 8 deletions(-)
>>
>> diff --git a/meta-isar/conf/machine/imx6-sabrelite.conf b/meta-isar/conf/machine/imx6-sabrelite.conf
>> index e48823d6..6ca0a907 100644
>> --- a/meta-isar/conf/machine/imx6-sabrelite.conf
>> +++ b/meta-isar/conf/machine/imx6-sabrelite.conf
>> @@ -15,4 +15,6 @@ MKUBIFS_ARGS := "-m 0x1000 -e 0x3e000 -c 1500"
>>  UBINIZE_ARGS = "-vv -m 0x1000 -p 0x40000"
>>  IMAGE_FSTYPES ?= "ubi-ubifs"
>>
>> -DTB_FILES = "imx6q-sabrelite.dtb"
>> +KERNEL_IMAGETYPE = "zImage"
>> +
>> +DTB_FILES = "nxp/imx/imx6q-sabrelite.dtb"
>> diff --git a/meta-isar/conf/machine/phyboard-mira.conf b/meta-isar/conf/machine/phyboard-mira.conf
>> index feec4e54..d64b4624 100644
>> --- a/meta-isar/conf/machine/phyboard-mira.conf
>> +++ b/meta-isar/conf/machine/phyboard-mira.conf
>> @@ -16,10 +16,12 @@ MKUBIFS_ARGS := "-m 0x800 -e 0x1f000 -c 8012"
>>  UBINIZE_ARGS = "-vv -m 0x800 -p 0x20000"
>>  IMAGE_FSTYPES ?= "ubi ubifs"
>>
>> -DTB_FILES = "imx6q-phytec-mira-rdk-nand.dtb"
>> +DTB_FILES = "nxp/imx/imx6q-phytec-mira-rdk-nand.dtb"
> 
> This change is only correct when also the kernel is 6.5 or newer (i.e.
> when the dts folder of arm was split into vendors) - which it was in
> fact. So, this is a separate fix that should be factored out.
> 

I think you forgot to send this as separate patch, don't you?

Jan

-- 
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/45999d3d-6432-425f-a909-c4a034e11992%40siemens.com.