public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: cedric_hombourger@mentor.com
To: isar-users <isar-users@googlegroups.com>
Subject: IMAGE_TYPE vs IMAGE_TYPE(S)
Date: Fri, 1 Jun 2018 07:40:23 -0700 (PDT)	[thread overview]
Message-ID: <45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 889 bytes --]

Hello!

The documentation suggests that IMAGE_TYPE may be a list of images to be 
built:

   | The `IMAGE_TYPE` variable contains the list of image types to generate.

(ref: https://github.com/ilbers/isar/blob/master/doc/user_manual.md#image-type-selection)

It appears that one could set this to e.g. "ext4-img wic-img" to get Isar 
to generate both an EXT4 image and a WIC image.
Alright.

But then how about this code:

   | if d.getVar('IMAGE_TYPE', True) == 'wic-img':
   |     d.appendVar('BUILDCHROOT_PREINSTALL',
   |                 d.getVar('BUILDCHROOT_PREINSTALL_WIC', True))

(ref: https://github.com/ilbers/isar/blob/master/meta/recipes-devtools/buildchroot/buildchroot.bb#L45)

The condition would be False for the example provided above and our 
buildchroot missing vital tools such mkdosfs

We probably need to fix one or the other. What are your thoughts?

Thanks
Cedric

[-- Attachment #1.2: Type: text/html, Size: 1249 bytes --]

             reply	other threads:[~2018-06-01 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 14:40 cedric_hombourger [this message]
2018-06-04  7:16 ` Jan Kiszka
2018-06-04  8:27   ` Henning Schild
2018-06-04  7:17 ` Claudius Heine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com \
    --to=cedric_hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox