From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6562126013157867520
Date: Fri, 1 Jun 2018 07:40:23 -0700 (PDT)
From: cedric_hombourger@mentor.com
To: isar-users <isar-users@googlegroups.com>
Message-Id: <45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com>
Subject: IMAGE_TYPE vs IMAGE_TYPE(S)
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_9128_452794177.1527864023836"
X-Google-Token: ENe1xdgF0FfC4LxB1qk0
X-Google-IP: 81.14.33.59
X-TUID: Zdox+ko07iAj

------=_Part_9128_452794177.1527864023836
Content-Type: multipart/alternative; 
	boundary="----=_Part_9129_716902776.1527864023836"

------=_Part_9129_716902776.1527864023836
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hello!

The documentation suggests that IMAGE_TYPE may be a list of images to be 
built:

   | The `IMAGE_TYPE` variable contains the list of image types to generate.

(ref: https://github.com/ilbers/isar/blob/master/doc/user_manual.md#image-type-selection)

It appears that one could set this to e.g. "ext4-img wic-img" to get Isar 
to generate both an EXT4 image and a WIC image.
Alright.

But then how about this code:

   | if d.getVar('IMAGE_TYPE', True) == 'wic-img':
   |     d.appendVar('BUILDCHROOT_PREINSTALL',
   |                 d.getVar('BUILDCHROOT_PREINSTALL_WIC', True))

(ref: https://github.com/ilbers/isar/blob/master/meta/recipes-devtools/buildchroot/buildchroot.bb#L45)

The condition would be False for the example provided above and our 
buildchroot missing vital tools such mkdosfs

We probably need to fix one or the other. What are your thoughts?

Thanks
Cedric

------=_Part_9129_716902776.1527864023836
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello!<div><br></div><div>The documentation suggests that =
IMAGE_TYPE may be a list of images to be built:</div><div><br></div><div>=
=C2=A0 =C2=A0|=C2=A0The `IMAGE_TYPE` variable contains the list of image ty=
pes to generate.</div><div><br></div><div>(ref:=C2=A0https://github.com/ilb=
ers/isar/blob/master/doc/user_manual.md#image-type-selection)</div><div><br=
></div><div>It appears that one could set this to e.g. &quot;ext4-img wic-i=
mg&quot; to get Isar to generate both an EXT4 image and a WIC image.</div><=
div>Alright.</div><div><br></div><div>But then how about this code:</div><d=
iv><br></div><div>=C2=A0 =C2=A0| if d.getVar(&#39;IMAGE_TYPE&#39;, True) =
=3D=3D &#39;wic-img&#39;:</div><div>=C2=A0 =C2=A0| =C2=A0 =C2=A0 d.appendVa=
r(&#39;BUILDCHROOT_PREINSTALL&#39;,</div><div>=C2=A0 =C2=A0| =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 d.getVar(&#39;BUILDCHROOT_PREINST=
ALL_WIC&#39;, True))</div><div><br></div><div>(ref:=C2=A0https://github.com=
/ilbers/isar/blob/master/meta/recipes-devtools/buildchroot/buildchroot.bb#L=
45)</div><div><br></div><div>The condition would be False for the example p=
rovided above and our buildchroot missing vital tools such mkdosfs</div><di=
v><br></div><div>We probably need to fix one or the other. What are your th=
oughts?</div><div><br></div><div>Thanks</div><div>Cedric</div></div>
------=_Part_9129_716902776.1527864023836--

------=_Part_9128_452794177.1527864023836--