public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH 2/4] dkpg-base: Clarify dependency logic between package recipes
Date: Sat,  1 Sep 2018 16:47:48 +0200	[thread overview]
Message-ID: <45c00ea5d4bd9ed859237d9b0704d72ea144d48b.1535813270.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1535813270.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1535813270.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

No functional change, just reordering and comment enhancement.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/dpkg-base.bbclass | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 84c56af..6299ef8 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -3,6 +3,8 @@
 
 ISAR_CROSS_COMPILE ??= "0"
 
+DEPENDS ?= ""
+
 # Add dependency from the correct buildchroot: host or target
 python __anonymous() {
     mode = d.getVar('ISAR_CROSS_COMPILE', True)
@@ -30,10 +32,6 @@ do_adjust_git[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 inherit patch
 addtask patch after do_adjust_git before do_build
 
-# Add dependency between Isar recipes
-DEPENDS ?= ""
-do_prepare[deptask] = "do_deploy_deb"
-
 def get_package_srcdir(d):
     s = d.getVar("S", True)
     workdir = d.getVar("WORKDIR", True)
@@ -85,6 +83,9 @@ do_prepare() {
 
 addtask prepare after do_patch before do_build
 do_prepare[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
+# If Isar recipes depend on each other, they typically need the package
+# deployed to isar-apt
+do_prepare[deptask] = "do_deploy_deb"
 
 # Placeholder for actual dpkg_runbuild() implementation
 dpkg_runbuild() {
-- 
2.16.4


  parent reply	other threads:[~2018-09-01 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-01 14:47 [PATCH 0/4] dpkg class refactorings, API changelog Jan Kiszka
2018-09-01 14:47 ` [PATCH 1/4] dpkg-base: Relocate dpkg_runbuild and adjust comments Jan Kiszka
2018-09-01 14:47 ` Jan Kiszka [this message]
2018-09-01 14:47 ` [PATCH 3/4] dpkg: Split dependency installation from build preparations Jan Kiszka
2018-09-01 14:47 ` [PATCH 4/4] Add changelog for the recipe API Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45c00ea5d4bd9ed859237d9b0704d72ea144d48b.1535813270.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox