Re: [PATCH v6 3/5] linux-custom: Provide target and host specific kernel kbuild packages

[Jan Kiszka <jan.kiszka@siemens.com>]

On 14.02.24 11:10, Stefan Koch wrote:
> When using a cross build this patch does introduce
> target and host specific kernel kbuild packages that
> ship the "scripts" and "tools" binaries.
> 
> The "-kbuildtarget" and "-native" multiarch bitbake targets are useable to run
> additional target or host specific builds for kbuild scripts and tools.
> 
> Using the "-kbuildtarget" bitbake target enables the build of
> a target specific kbuild package at cross builds.
> So using "linux-kbuild" provides the package for the target platform.
> 
> Using the "-native" bitbake target enables the build of
> a host specific kbuild package at cross builds.
> When cross building using "linux-kbuild-native"
> provides the package for the host platform.
> 
> Only the "host" specific package is built automatically at cross builds.
> 
> This solves this from doc/custom_kernel.inc:
> - The kernel headers package has not supported both native
>   and cross compilation of kernel modules when itself was cross built
> - Future roadmap: Generate kernel headers package for both host
>   and target when using a cross build
> 
> Signed-off-by: Stefan Koch <stefan-koch@siemens.com>
> ---
>  .../linux/classes/kbuildtarget.bbclass        |  8 ++++
>  .../linux/files/debian/control.tmpl           |  6 ++-
>  .../linux/files/debian/isar/build.tmpl        | 13 ++++-
>  .../linux/files/debian/isar/common.tmpl       |  9 ++++
>  .../linux/files/debian/isar/install.tmpl      | 34 +++++++++-----
>  meta/recipes-kernel/linux/linux-custom.inc    | 47 ++++++++++++++++++-
>  6 files changed, 99 insertions(+), 18 deletions(-)
>  create mode 100644 meta/recipes-kernel/linux/classes/kbuildtarget.bbclass
> 
> diff --git a/meta/recipes-kernel/linux/classes/kbuildtarget.bbclass b/meta/recipes-kernel/linux/classes/kbuildtarget.bbclass
> new file mode 100644
> index 00000000..26369861
> --- /dev/null
> +++ b/meta/recipes-kernel/linux/classes/kbuildtarget.bbclass
> @@ -0,0 +1,8 @@

Missing copyright header, please fix (on top).

> +python kbuildtarget_virtclass_handler() {
> +    pn = e.data.getVar('PN')
> +    if pn.endswith('-kbuildtarget'):
> +        e.data.setVar('BPN', pn[:-len('-kbuildtarget')])
> +        e.data.appendVar('OVERRIDES', ':class-kbuildtarget')
> +}
> +addhandler kbuildtarget_virtclass_handler
> +kbuildtarget_virtclass_handler[eventmask] = "bb.event.RecipePreFinalise"

Some newline separators would help with the readability - when at it,
please fix this as well.

Finally, I'm still trying to understand while the -native recipe is
built even in the absence of a kernel module which would need it. This
seems broken.

Jan

-- 
Siemens AG, Technology
Linux Expert Center