Re: [URGENT][PATCH v3 0/2] Correctly determine kernel and initrd versions

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On 10/18/2017 02:08 PM, Alexander Smirnov wrote:
> Hi all,
> On 10/18/2017 01:13 PM, Alexander Smirnov wrote:
>> Hello all,
>>
>> IMPORTANT: lets try to review this series ASAP, becuase Isar build is
>> broken again due to recent update of Raspbian kernel version in apt.
>> Instead of yet-another-version update I'd like to commit proper
>> solution.
>>
>> In current Isar implementation, multiconfig file contains hardcoded
>> version for boot files: kernel and initrd. This is used for both:
>>
>>   - Add respective package to multistrap config.
>>   - Copy boot files to deploy directory.
>>
>> This series drops this hardcoded versions, so now Isar is able to
>> determine version of boot files during building.
>>
>> Changes since v2:
>>   - Avoid races in 'deploy/images' folder creation.
>>
>> Changes since v1:
>>   - Differentiate 'do_copy_boot_files' stamps.
>>   - Update start_vm script accordingly.
>>   - Check if symlinks 'vmlinuz' and 'initrd.img' exist before reading
>>     them. If symlink doesn't exist, this function skips it.
> 
> any feedback on this?

Just about Hennings readlink remark. You might want to try 'readlink -m' 
instead of 'readlink -e'. It appears that the target of your symlink 
didn't exist, so 'readlink -e' returns nothing.

Cheers,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de