public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Kazunori Kobayashi <kazunori.kobayashi@miraclelinux.com>
To: Florian Bezdeka <florian.bezdeka@siemens.com>,
	isar-users@googlegroups.com
Cc: hiraku.toyooka@miraclelinux.com, masami.ichikawa@miraclelinux.com
Subject: Re: [PATCH] dpkg-source: Export proxy settings
Date: Thu, 30 Oct 2025 21:30:41 +0900	[thread overview]
Message-ID: <465063ac-96cf-4649-8618-c63b3e6fdb46@miraclelinux.com> (raw)
In-Reply-To: <44272f9dcdb15fe9cecc11a619289b95d01fac99.camel@siemens.com>

On 10/30/25 19:13, Florian Bezdeka wrote:
> On Thu, 2025-10-30 at 11:36 +0900, Kazunori Kobayashi wrote:
>> On 10/29/25 22:53, Florian Bezdeka wrote:
>>> On Wed, 2025-10-29 at 10:43 +0900, Kazunori Kobayashi wrote:
>>>> I assume Isar considers networking via proxy in such as downloading
>>>> something in do_fetch, resolving dependencies in do_dpkg_build and
>>>> package installation on the target root filesystem in do_rootfs_install.
>>>> We can actually use it in such typical cases with no problem.
>>>>
>>>> This change has effect on a very limited case, where a self-built
>>>> package fetching a source package via the apt:// scheme in SRC_URI is
>>>> specified as a native package (<package>-native) to IMAGE_INSTALL or
>>>> SDK_INSTALL. In this case, the source package is fetched via apt-get in
>>>> schroot in do_fetch_common_source but proxy environment variables are
>>>> not set in the executing shell function.
>>> It seems that I missed that the apt:// fetcher is invoked quite late,
>>> so already inside the schroot environment. That is done that way to use
>>> the apt machinery of the target distribution already.
>> Thank you for instructing me on the existing apt fetcher issue. If
>> possible, I would like to understand how to fix the issue properly.
>> Could you please roughly clarify it on the code base, if you don't mind?
>>
>> I found a different apt fetcher code from do_fetch_common_source in the
>> following place and it seems to set proxy settings before fetching a apt
>> source package inside the schroot environment.
>>
>> https://github.com/ilbers/isar/blob/master/meta/lib/aptsrc_fetcher.py
> This one is the fetcher that gets involved when you have something like
> apt:// in your SRC_URI.
>
>> The apt fetcher code seems duplicate, but do you think invoking this one
>> at the appropriate moment is preferable?
> The task that you modified (correctly) is invoked when building a
> package. It fetches the Debian source package from the (internal)
> repository.
>
> There are two apt-get commands here. The first one is local only, the
> second one will talk to "upstream" / the network as well. This will
> obviously fail if proxies are involved.

I see. I mixed up the apt fetchers for SRC_URI and for being invoked 
when building a package. Thank you.

I have already posted a v2 patch with the commit message modified. I 
would be grateful if you could check it.

Regards,
Kazunori


>
>> Regards,
>> Kazunori
>>> So yes, that seems correct.
>>>
>>> Thanks for the additional information. You could (if you like) send a
>>> v2 with that information part of the commit message. Will help the
>>> maintainers as well.
>>>
>>> Thanks for your contribution!
>>>
>>> Best regards,
>>> Florian
>>
>> -- 
>> Kazunori Kobayashi
>> Cybertrust Japan Co., Ltd.
>> https://www.cybertrust.co.jp/
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups "isar-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
>> To view this discussion visit https://groups.google.com/d/msgid/isar-users/a5d85c10-7dc7-40db-a9d7-4ded45925c3c%40miraclelinux.com.


-- 
Kazunori Kobayashi
Cybertrust Japan Co., Ltd.
https://www.cybertrust.co.jp/

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/465063ac-96cf-4649-8618-c63b3e6fdb46%40miraclelinux.com.

      reply	other threads:[~2025-10-30 12:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  1:35 Kazunori Kobayashi
2025-10-28 11:59 ` 'Florian Bezdeka' via isar-users
2025-10-29  1:43   ` Kazunori Kobayashi
2025-10-29 13:53     ` 'Florian Bezdeka' via isar-users
2025-10-30  2:36       ` Kazunori Kobayashi
2025-10-30  9:37         ` [PATCH v2] " Kazunori Kobayashi
2025-10-30  9:48         ` [PATCH] " Kazunori Kobayashi
2025-10-30 10:13         ` 'Florian Bezdeka' via isar-users
2025-10-30 12:30           ` Kazunori Kobayashi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465063ac-96cf-4649-8618-c63b3e6fdb46@miraclelinux.com \
    --to=kazunori.kobayashi@miraclelinux.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=hiraku.toyooka@miraclelinux.com \
    --cc=isar-users@googlegroups.com \
    --cc=masami.ichikawa@miraclelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox