From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6644847399572340736 X-Received: by 2002:a1c:c91:: with SMTP id 139mr1536945wmm.9.1547798032062; Thu, 17 Jan 2019 23:53:52 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:6812:: with SMTP id w18ls2661492wru.1.gmail; Thu, 17 Jan 2019 23:53:51 -0800 (PST) X-Google-Smtp-Source: ALg8bN6RWudeeO60HPn5Hr+MkDvhIC4xbd6D/ynTDZNadn0J2zqo8PfQJOi9+0O0Q1q2O7NitmGx X-Received: by 2002:a5d:49c4:: with SMTP id t4mr1196497wrs.31.1547798031535; Thu, 17 Jan 2019 23:53:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547798031; cv=none; d=google.com; s=arc-20160816; b=LbOab4yJjvrKwVJns9SgKOcaMy69v18vx75MqQMELFPquJIQvk6DwMoGh/0EQ6E1II CL6dhYz9ftmDou+rnGiPnNTc54m6HdHeKGqmpdBpok5+R+jymg79BoXUgbPPKbuPWWJc kCDDLc2WoASKU6y3QWFr8bA07XA918a9pMFZuJTSl3v1DfFdQhdQNv4FQgnjdvZ1n6hY gLEZjBsAoFB3ZMfbUAypNojk30PoOKcT5XioANijft8akp4lNYHBkLiBuKjY6dm1O3Es nWXMUhTsDc0tjY7vRhNjnnJz/+EzUi0sQLsYATaX4atytzvX7R+t3dkcX3vfErL8X392 HVMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=F465OBiJJN67lkQ65P1zbh4wcPCOzOBg5Ckztg4xxRc=; b=lwwd6dSv3Ds4BTnsGIjJLFS1QGGS6TA4YF3fpT85Tm+aRSVsPVNHry7nyjCM/eMlub zkTn/U4WMr2AFQFmL4kdjm9nYUrSsb9RjqA6PNRzTDkP5ctqEUx6SrfLspr47wku1Fgq RN/nbM7JHk9C+xeZpJ72ZrM4WlV6K+zJ/1dBc9M+NWKQeqZxl9qpSgg2lZRExZ8jHnYr qAcud/UEvxFzIWMw2UgK0kdW1ZxKmMqbWmONU8LLmBesNXqTh4qfujgG6ye3NcpMwvRy AsQpNjfUJDKeLXncW1fT8Gt5gRZQ+x9Stj42XTvZmUgt/F3cGTxKJ6HrXQJKo/uS4ja5 mt3g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id x188si1099188wmb.3.2019.01.17.23.53.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 23:53:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.163] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id x0I7rnDV010270 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 18 Jan 2019 08:53:50 +0100 Subject: Re: [PATCH v2] Fix wrong inline python in isar-image.bbclass To: "Andreas J. Reichel" , isar-users@googlegroups.com References: <20190110150351.27270-1-andreas.reichel.ext@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <467bf340-7d1a-314c-2caa-5ff09a53a926@ilbers.de> Date: Fri, 18 Jan 2019 08:53:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190110150351.27270-1-andreas.reichel.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: wZIqGhI7n8ET On 1/10/19 4:03 PM, Andreas J. Reichel wrote: > From: Andreas Reichel > > The inline python string used a mixture of python > and shell, which failed while parsing recipes with: > > The URL: '${@' is invalid and cannot be interpreted > > Problem is that in > > SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if '${DISTRO_CONFIG_SCRIPT}' else '' }" > > ${DISTRO_CONFIG_SCRIPT} is not interpreted correctly. > Use d.getVar instead. Rebased and applied to the 'next', Thanks, Maxim. > Signed-off-by: Andreas Reichel > --- > meta/classes/isar-image.bbclass | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass > index 754e896..e221ba6 100644 > --- a/meta/classes/isar-image.bbclass > +++ b/meta/classes/isar-image.bbclass > @@ -6,8 +6,14 @@ > inherit image > inherit isar-bootstrap-helper > > +def cfg_script(d): > + cf = d.getVar('DISTRO_CONFIG_SCRIPT', True) or '' > + if cf: > + return 'file://' + cf > + return '' > + > FILESPATH =. "${LAYERDIR_isar}/conf/distro:" > -SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if '${DISTRO_CONFIG_SCRIPT}' else '' }" > +SRC_URI += "${@ cfg_script(d) }" > > DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}" > > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov