From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6685271301067636736 X-Received: by 2002:a17:906:4957:: with SMTP id f23mr12315782ejt.279.1557837749968; Tue, 14 May 2019 05:42:29 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:22d7:: with SMTP id q23ls1040607eja.12.gmail; Tue, 14 May 2019 05:42:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzdBliY2ZIVXGkMc3+c3oCmOWcw2v4lNSYUSiTwFYFL6q2Jh5GRv66981hYuhfzcsHn7Hia X-Received: by 2002:a17:906:6152:: with SMTP id p18mr27401916ejl.245.1557837749514; Tue, 14 May 2019 05:42:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557837749; cv=none; d=google.com; s=arc-20160816; b=N9r+e5P1vyU0NlUh2H4YDWWoVQzqh62mRjo2Im+eJ4FWVv5WEqPFkrCi29NWQn0E1d be37iTGLlO6dlyrWy5+0STmGCZyU4oS4HIPmxEVt+fyHlIu3bf/7TDPqf1pGjXQ/yYWG wyq0iT5VOvz41AzqXiP2jTGItJENbJBhLgOkR8khJwnxQ76L2jLdjPcZJQ8JCyRQJ9v2 tk3JTfx8uEfGo5Rq7cz1zhDdA59UvPPOK2tXnciFWFpP6WLRq9/SpyJEAHfgysHVCKJy +6+0TSvCuM5riMtzP1mop2uGqsCQY0AURgC/9/lhTqa91OhwEHL0ehChwrkK8FXkhXDI BZKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=nLtTpg4jtj88D+TIOU7mKA6yUkI/hA0TLSF4UHodb5s=; b=HAoWQpuTiQEQVVW/OfWk4XlOvEgIeS9IqCEdT5o29O4xsBXpDDFcTbRXEkb5Hqq0oE 2fBl4S/u05nq7KATxWvwRxJstD1UL8GlubPKB2HUIby5RTsPB1g/wLgaKBwSy7L1GdQs 1uCVPuJpzIs2cKk0YNQriRsoAZNc/3bNyitm/35J2vYlpbzoFdvM9M2oUQ6c538K3/Gd WcyFTE+KlqROPtp11n0koVSNoL8IaKV9cstnZo44YT1xiF6JjUZv+Qdp0GTr/tpjPPRv ZHr1RavKlodxIOnvjciTrFqaLPu6ddjpmLb1R7by9KlJSKyoHPA5Nf+FZgf4nUAmH6c9 YtMQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id k38si5552982edd.2.2019.05.14.05.42.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 05:42:29 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.1.29] (115.165-131-109.adsl-dyn.isp.belgacom.be [109.131.165.115] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x4ECgS3L032416 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2019 14:42:29 +0200 Subject: Re: [PATCH] dpkg: warn when S equals WORKDIR To: Henning Schild , isar-users References: <20190429110658.16212-1-henning.schild@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <46a03a33-186e-b106-653e-813f1701f728@ilbers.de> Date: Tue, 14 May 2019 14:42:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190429110658.16212-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: C89dnNGJC1HO On 4/29/19 1:06 PM, Henning Schild wrote: > From: Henning Schild > > This patch does not change any logic, it just introduces a warning. If S > is not a directory inside WORKDIR do_deploy_deb and repo_clean will not > actually find any "*.deb" because they remain inside buildchroot. > Finding debs relative to BUILDROOT instead of S would require mounting > and locking. Intead of doing all of that document the small > limitation/assumption with a warning. Applied to the 'next'. Thanks, Maxim. > Signed-off-by: Henning Schild > --- > meta/classes/dpkg-base.bbclass | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 742b8ad..e31dd8d 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -45,9 +45,12 @@ do_apt_fetch[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" > do_apt_fetch[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > def get_package_srcdir(d): > - s = d.getVar("S", True) > - workdir = d.getVar("WORKDIR", True) > - if s.startswith(workdir): > + s = os.path.abspath(d.getVar("S", True)) > + workdir = os.path.abspath(d.getVar("WORKDIR", True)) > + if os.path.commonpath([s, workdir]) == workdir: > + if s == workdir: > + bb.warn('S is not a subdir of WORKDIR debian package operations' + > + ' will not work for this recipe.') > return s[len(workdir)+1:] > bb.warn('S does not start with WORKDIR') > return s > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov