From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6519532471426482176 X-Received: by 10.28.0.11 with SMTP id 11mr352167wma.28.1517950577481; Tue, 06 Feb 2018 12:56:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.187.9 with SMTP id r9ls23909wrg.4.gmail; Tue, 06 Feb 2018 12:56:16 -0800 (PST) X-Google-Smtp-Source: AH8x224JxGGkkJld976EdS2eHHaIvKMbRPRhGQAqfj3G4RMA3P6AZG4KO6EAFVT9PqGplZfSMcK+ X-Received: by 10.223.157.147 with SMTP id p19mr444477wre.30.1517950576926; Tue, 06 Feb 2018 12:56:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517950576; cv=none; d=google.com; s=arc-20160816; b=qqP+5kSu4BxZLT4wQWMac/q0EyWWGOcPpwWHCp1Ww20HkkqRnAg+Db3vL2x2wcfuU7 9NnKbsqCZUyhT/pvu4eXofcM6OS3+NItR9jawBxSWH2dr0OaDpcPEOOmKEBfgfEKcP2G K3fwnWDdqHWvUAFh0MgP067cAmqFRgw4VjP52+nCYuRGDqXJ7hfJd1A3eN1D6nAonp05 uXIrAJqT5mksXU/cG+bKzzKDYg5zjKYYyLztwNoML6BZ2z5Fx40tqDe1I0UyQwjzhs1t ILoYO03uzUZTCy57/z8Khk1aVcY72TjZFdUkex1ljGmbrLYQuKkjeBwKspvNDUDBQSwE pPqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=9CIDOCAYa6MPqnPJrHuCNfW78WmrhrxDlR4PXcyiYpE=; b=iCHhbBcP+PGnDLDR38FyMj/ShWkrunuSQmzzopitYvGwv5iygqe2QmeopkSfM2T6hr nF9lLHvxs/61vtxMN8VzZWKMwEhFnpnwuFUcr5VXK2Cz/ro78RA0M+1+4v6jzw4MWDKc DDlFrFw5KG+aXXgOg6rWllerZrBfAdLp9z+hHoVF8fdc+D84vN1a+ftMLKDjJ2zGqNIG voXQkQvI35IIBrAWMBhpRedLw0gWRAlrvrUFuF8CWpV3sk11UZWbi6rNhz/ibzD2qMSD Ruccam0RjpugkWcJTWncqGDtauvZyuT2Z+yHE6klYc9xFeZRhJfZLQpCet9mvs9n/PCQ 5HQw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id a12si1413342wmg.4.2018.02.06.12.56.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2018 12:56:16 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w16KuGrV028688 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 6 Feb 2018 21:56:16 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w16KuFAH007751; Tue, 6 Feb 2018 21:56:15 +0100 Subject: Re: [PATCH] isar: Clean mount point on bitbake exit To: Alexander Smirnov , isar-users@googlegroups.com References: <20180206195516.32153-1-asmirnov@ilbers.de> <1e69c65a-3c5d-abdd-ccb5-103e09371d92@siemens.com> From: Jan Kiszka Message-ID: <46bff563-8447-39ec-d59c-97d57e36bc7c@siemens.com> Date: Tue, 6 Feb 2018 21:56:15 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: mGdLxjaAU5qP On 2018-02-06 21:45, Alexander Smirnov wrote: > On 02/06/2018 11:31 PM, Jan Kiszka wrote: >> On 2018-02-06 20:55, Alexander Smirnov wrote: >>> 8<-- >>> >>> That's it! Branch 'asmirnov/devel', please test and enjoy :-) >>> >>> 8<-- >>> >>> Now each multiconfig has registered handler for BuildCompleted event >>> (see >>> class 'isar-event.bbclass'). Moreover, the '/proc/mounts' file contains >>> all the active mounts. In addition, from event handler we could derive >>> all the variables like ${TMPDIR}, ${DISTRO} etc. So it's possible to >>> find all the active mounts for current multiconfig and clean them. >>> >>> NOTE: if build is interrupted by double ^C, some mount points could stay >>> uncleaned. This is caused by remaining processes started by bitbake, for >>> example: >>>   - 'chroot build.sh ...' >>>   - 'multistrap ...' >> >> Can you explain what the race condition is exactly? It seems to work for >> me so far, no forgotten mounts. > > Sometimes after double ^C I see several mounted artifacts in > buildchroot. But I've also noticed, that there are running processes > like 'multistrap' and 'build.sh' running *exactly* in this buildchroot. > > So, simple test, if you press double ^C and run 'ps ax' after, you will > likely see running processes. IIRC the same bitbake behavior I saw with > Yocto, interrupting bitbake doesn't mean to kill the process with > current task. Yes, there is a settling phase, but everything is dead and gone after a couple of seconds, at least here. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux