Re: [PATCH] linux-custom: skip linux-libc-dev deployment on downgrade

[Jan Kiszka <jan.kiszka@siemens.com>]

On 23.01.19 18:30, Henning Schild wrote:
> Am Wed, 23 Jan 2019 18:26:08 +0100
> schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> 
>> On 23.01.19 18:23, [ext] Henning Schild wrote:
>>> Ping
>>>    
>>
>> Looks good to me - what scenarios did you test?
> 
> I know the breakages of buildchroot from layers, and the not deploying
> the kernel downgrade helped fix the issues.
> In this repo i honestly only tested the logic and whether the warning
> will pop up. Tested a qemuamd64 with the cip kernel inside Isar.
> 

OK, but we also have a "should upgrade" kernel recipe in Isar: 
linux-mainline_4.19.0.

One question on second thought:

> +
> +# linux-libc-dev causes dependency problems if we downgrade
> +# remove it after the build so the downgraded version does not get deployed
> +LINUX_LIBC_DEV_V=`dpkg-query --show --showformat '${Version}' linux-libc-dev`
> +if dpkg --compare-versions $LINUX_LIBC_DEV_V gt $PV; then
> +	rm -f linux-libc-dev_${PV}*.deb
> +fi

Isn't this assuming we have linux-libc-dev from Debian installed? Is that always 
valid? Wouldn't it be better to query the Debian repo specifically?

Also: $(...) - `...` is old-style.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux