From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647450695491387392 X-Received: by 2002:a2e:8887:: with SMTP id k7-v6mr296638lji.3.1548265392251; Wed, 23 Jan 2019 09:43:12 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:50c9:: with SMTP id h9ls322083lfm.6.gmail; Wed, 23 Jan 2019 09:43:11 -0800 (PST) X-Google-Smtp-Source: ALg8bN5YiSciv9oElVcAQNyHAYJ9Dnr+/ul0kD3fyseuNvFkANa4KjTAQ+ZbAhjOX2OT64s8sUGe X-Received: by 2002:ac2:4150:: with SMTP id c16mr275589lfi.2.1548265391522; Wed, 23 Jan 2019 09:43:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548265391; cv=none; d=google.com; s=arc-20160816; b=FkyxsvHO9DC4qPi052RUNpuZv0rkTbRowJIDz0Ahh6rddEea5zocA3m3o9NZwakVR0 dURPjGKPEhrG8jd7IycTXN3dMkkdHXGKm7DR0cqjs4JyIkzDX5948uTM27mfLsLjm+gR DQvEUHlXt8qKf1PCV7OPA60EfTyd4ZzVK6o9l4bjf0hx2iomgFd0xM4zMNDD22q+Vqai Z/OQDZFh0W92OSvogWXc01VW2oPE5L3afXXdCT0uKwxlbRbJx/atz+JEmIpcd3W9SXnf eDZ3LWHdZbObJVqM73VJm9wjrLH4sHJUxCYM54dOhNUadbPbgS46iXEGMIhKCXPTbSE6 Hmng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=rhER0g+QYYpie7ZbHZVSdRiJ8sdTm8pWhrPNNWO4qcw=; b=KcEvYNgcT9pBeYHkocewBlibUBHsT0A3fYldPY/Trm06M0G9l0dyLAxznV4L4SdrFC GNvIqttdb4Efn/GgG4GL/fOKX2vgJrnxnuVoywZ3DAullu662F0h2l0V1kYWv+/4cOZD 1gpYW1BlYUV7DJFiIVCLs93WLwP53weUTwg0rYFOEDS6NOBRde7bQv7mq0HBjfXwWH+V jmUpnhYlUhOyQH4WZTXyprIj1az24wMHAMuczuSuHBbsdfFCGBcDK+WM8gUVOdL5OOpB H55bBZbMhaTrqQJUb+QhlRT9nPktZsIC169EkbW7saM8Et8Oq7bmgx2VXU/9WnoxgnC8 D5Ww== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id 205si139541lfb.2.2019.01.23.09.43.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jan 2019 09:43:11 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x0NHhAOK018120 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Jan 2019 18:43:10 +0100 Received: from [139.22.37.91] ([139.22.37.91]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x0NHh9jV024651; Wed, 23 Jan 2019 18:43:10 +0100 Subject: Re: [PATCH] linux-custom: skip linux-libc-dev deployment on downgrade To: Henning Schild Cc: isar-users References: <20190117130342.15743-1-henning.schild@siemens.com> <20190123182303.4795f660@md1za8fc.ad001.siemens.net> <14dc306a-4db0-a8d4-6839-a2369369f372@siemens.com> <20190123183039.6b102065@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <471e7120-1541-5f07-1374-be86fc62d872@siemens.com> Date: Wed, 23 Jan 2019 18:43:08 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20190123183039.6b102065@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Y5YEwd//NhF6 On 23.01.19 18:30, Henning Schild wrote: > Am Wed, 23 Jan 2019 18:26:08 +0100 > schrieb Jan Kiszka : > >> On 23.01.19 18:23, [ext] Henning Schild wrote: >>> Ping >>> >> >> Looks good to me - what scenarios did you test? > > I know the breakages of buildchroot from layers, and the not deploying > the kernel downgrade helped fix the issues. > In this repo i honestly only tested the logic and whether the warning > will pop up. Tested a qemuamd64 with the cip kernel inside Isar. > OK, but we also have a "should upgrade" kernel recipe in Isar: linux-mainline_4.19.0. One question on second thought: > + > +# linux-libc-dev causes dependency problems if we downgrade > +# remove it after the build so the downgraded version does not get deployed > +LINUX_LIBC_DEV_V=`dpkg-query --show --showformat '${Version}' linux-libc-dev` > +if dpkg --compare-versions $LINUX_LIBC_DEV_V gt $PV; then > + rm -f linux-libc-dev_${PV}*.deb > +fi Isn't this assuming we have linux-libc-dev from Debian installed? Is that always valid? Wouldn't it be better to query the Debian repo specifically? Also: $(...) - `...` is old-style. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux