From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6665957031077216256 X-Received: by 2002:a17:906:c9d2:: with SMTP id hk18mr617700ejb.5.1552039452004; Fri, 08 Mar 2019 02:04:12 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:af8d:: with SMTP id mj13ls1771085ejb.4.gmail; Fri, 08 Mar 2019 02:04:11 -0800 (PST) X-Google-Smtp-Source: APXvYqyhjkjCTkaECJTBQ23Mg1MWm+Po1YR16f6oEpkvwg6wW4WmTktVbNBbSr/c+Y3sUehn+Ygk X-Received: by 2002:a17:906:584c:: with SMTP id h12mr2119749ejs.2.1552039451478; Fri, 08 Mar 2019 02:04:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552039451; cv=none; d=google.com; s=arc-20160816; b=x6GoS5D5yTvRNZ9fxLgnCcQquwlvCAHCF9xX80OTBKxjVbM4iveKNvGY6FV5J9HZdT ZKyIp2VTExtU1VOsFr+5rnGdddeavyD1q99IZH4jy9dqukXXmi8LN/wlVLD6X50WYCxM 0rK40qW/51cOyf+VPcFrggtXj4fr77N5YwEgn+NcB8tjjvDAppuWhkjVrXEqHXSIKPe4 h7/AtIinUnOylJUW2oCZHJkHAadLgDDxJtq8NtU3xVpWzIw/pCEIqjuRYLKxSVijL86G 1K48a0Ux7+5c8ltgymqxfdG8GcNWa32wzJGVt0DXyerLdIpSiEU6G9jZNcUmiHHYbdt6 hXSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=HboXxDlNIZpMMPBTW9FGaPqdobLJ8Mhpg1QxSLRvFnc=; b=zKDcvQS9yJjbf2uyL8G3idcllwTxc2q7zPXNJ8rTe2qEHbCepuz2Vtu6OfP3C6MRIa 5vaMZdhwGGoy5HG84+R4ijc+H78Spnsaojg5IXyS9CSA4sC3jBdpXNdlo/gyYZJX4GwY rokSafphyCEIHMpZSZ8gH36NKw2PCBJmarlk/Ioll79eZxa3JS/RFdWCybQqiE4MD//w GWdPrPr0l1L4N+0LTiWBY6PK9HLf40c1KZs4nSZzl1vGWTGEKACdX/OHpL6zH66MBLSW ZjvNBScsF37ZP3htcdycJcfTMhgul7/3f28enDMbkpVxTBzUMYfyGulaiOrKXOaDXYSb mfkQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id a7si405948edb.1.2019.03.08.02.04.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 02:04:11 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x28A4A2V018772 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Mar 2019 11:04:11 +0100 Received: from [167.87.32.168] ([167.87.32.168]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x28A49wx012266; Fri, 8 Mar 2019 11:04:10 +0100 Subject: Re: [PATCH] dpkg: acquire a read (shared) locks while building packages To: Cedric Hombourger , isar-users@googlegroups.com References: <1552039053-1152-1-git-send-email-Cedric_Hombourger@mentor.com> From: Jan Kiszka Message-ID: <473ab398-0c28-00d9-5dd2-8caafb7dbf5f@siemens.com> Date: Fri, 8 Mar 2019 11:04:08 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1552039053-1152-1-git-send-email-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: RCbraG7mAgdV On 08.03.19 10:57, Cedric Hombourger wrote: > As debhelper scripts involved during the actual build process > (dpkg-buildpackage) may access the dpkg database, we need to > make sure it does not get modified in the background by other > build tasks for other packages (such as install_build_deps). > An example of a reader is dh_shlibdeps/dpkg-shlibdeps: it > needs to find packages providing the shared libraries the > package depends on to substitue shlibs variables found in its substitute > control file with package dependencies. Acquire the isar-apt > lock as a shared lock to block writers. Ah... Understood now. > > Signed-off-by: Cedric Hombourger > --- > meta/classes/dpkg.bbclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 24b9fe3..f4e3d7a 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -19,5 +19,6 @@ do_install_builddeps[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > # Build package from sources using build script > dpkg_runbuild() { > E="${@ bb.utils.export_proxies(d)}" > + flock -s "${REPO_ISAR_DIR}/isar.lock" \ > sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} > } > Couldn't we have the same issue with dpkg-base derived classes? The kernel? Or downstream classes? IOW, shouldn't this go to the caller of dpkg_runbuild? Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux