From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6743100217749405696 X-Received: by 2002:aa7:cf11:: with SMTP id a17mr2314221edy.153.1570002864470; Wed, 02 Oct 2019 00:54:24 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:f11b:: with SMTP id w27ls335790edl.1.gmail; Wed, 02 Oct 2019 00:54:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqz/dlNhgtEE8gOmws1o/8B/bdiNVOTGAOVMqVPpvyhSBBTmE6wbdssZdGvIbwYjZS/t4pib X-Received: by 2002:a50:ef02:: with SMTP id m2mr2341954eds.157.1570002864087; Wed, 02 Oct 2019 00:54:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570002864; cv=none; d=google.com; s=arc-20160816; b=W5yIyCyW3ezycNNQ5fGIB2KNovpmoYFEp2jWXz2DRODc9EnUPzI1GncNrDm1JEoOyc cl3Ru3MnQj3kLCTRNQska20kZXrPXoE1ZBOJfKy8x7ETLm2AULRg3YbROn3HdT2rQo7p ihtWsAnYUzA2ZEVVSo0AuOebsdstbUouYy6ngM9oVJd3+Mi/lf5xazIBcs/4O3CE9Z21 MwgkMbC7m4fGttSEAcScKmVRo5mcWbRBJGH7ZAmkoA8cSmDcsIgJQptJc9S8+jzrsZPD Fa7cnIAXgg80opbHUz5cIIdkqVU7b9lCVUNBtBdmMft2xfwINYwmvDvRcrNY0Jv5/xX/ azZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=/bq30XEO4Hz/VBaPNe51Gn/FGeBq31Eg3aRjhnCDwRU=; b=KyBJEMfHA39KkHB/uvP1bMrmC2z/NbaoDMihQtJRF71qKJFzlzEr1UsgtWHh70bEck 3SNvvgglHaf2C4zBYRkqLuAEvD6cFDgfq3sacjE9zJjrEb8/gJdVcTcxzPV7e23Ay5W2 1aOauD08qqfQnEW07LteuF+D6LoUwBxjjjKaKy8dn8VxWU6wMa6mwqbgt3cxtlxJOtV8 fDSYL65zTjS6BOwsmqkGbcq2e7NtbrugmoTh3VFYitUSyPFKbajxI3ugeKHTCUDnDDZq F+RSPsiQ5fn/Jp8uLTTeztdlAVVJTm67PoMSEnioiVEgBFDsDQzJUCBR7AWxmFbfyGh5 CiIA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id y11si1143124edq.1.2019.10.02.00.54.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Oct 2019 00:54:24 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x927sNT4016333 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Oct 2019 09:54:23 +0200 Received: from [167.87.6.48] ([167.87.6.48]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x927sNHl010119; Wed, 2 Oct 2019 09:54:23 +0200 Subject: Re: [PATCH] dpkg-base: Warn about unmounting problems From: Jan Kiszka To: Baurzhan Ismagulov , isar-users@googlegroups.com References: <20191002071241.17792-1-ibr@radix50.net> Message-ID: <4773fdcc-e993-e2f6-004f-06a78b529dac@siemens.com> Date: Wed, 2 Oct 2019 09:54:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: YH1Yib7wwnVA On 02.10.19 09:29, [ext] Jan Kiszka wrote: > On 02.10.19 09:12, Baurzhan Ismagulov wrote: >> From: Baurzhan Ismagulov >> >> If a problem occurs, log umount's error messages and warn the user about >> retrying. >> >> Signed-off-by: Baurzhan Ismagulov >> --- >>   meta/classes/dpkg-base.bbclass | 6 ++++-- >>   1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass >> index 2e8a0d1..42eca62 100644 >> --- a/meta/classes/dpkg-base.bbclass >> +++ b/meta/classes/dpkg-base.bbclass >> @@ -1,5 +1,6 @@ >>   # This software is a part of ISAR. >>   # Copyright (C) 2017-2019 Siemens AG >> +# Copyright (C) 2019 ilbers GmbH >>   # >>   # SPDX-License-Identifier: MIT >> @@ -78,8 +79,9 @@ dpkg_do_mounts() { >>   } >>   dpkg_undo_mounts() { >> -    while ! sudo umount ${BUILDROOT} 2>/dev/null; do >> -        sleep 0.1 >> +    while ! sudo umount ${BUILDROOT}; do >> +        bbwarn "${BUILDROOT}: Couldn't unmount, retrying..." >> +        sleep 1 > > This needlessly extends the waiting time by using a course-grained delay. And > let's only warn warn after a some seconds. To make it clearer: I've seen delays (i.e. failures before this patch), but I haven't measured them. I could imagine, though, that most of them are short races. And then a warning should only be issued when the delays become excessive, maybe 10 seconds. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux