From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6489319872694059008 X-Received: by 10.25.141.204 with SMTP id p195mr114538lfd.8.1510938472131; Fri, 17 Nov 2017 09:07:52 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.101.66 with SMTP id z63ls754103ljb.7.gmail; Fri, 17 Nov 2017 09:07:51 -0800 (PST) X-Google-Smtp-Source: AGs4zMbOqD4XjcCf32px+6toaekA9xBC7rxyfQHdMTmbKPLvg+D/sPJRH1gbWvHaCaBjw/ah1VUW X-Received: by 10.25.168.76 with SMTP id r73mr122496lfe.41.1510938471603; Fri, 17 Nov 2017 09:07:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510938471; cv=none; d=google.com; s=arc-20160816; b=xE+dlj6WiqZca2X2AWdlY3QaGa2OyYV0Ch01SXga6f9/lzxehAQv2bBjw64oW2vYWV t4cGAGqN6dJzDcRaEbzfXcNzl4JHgCuHPCf/nVyWEwh/TPBvXGPESfug9r6cPiKz3IPn h/SXfWlnbxVvyPgfIZChWk9JDU5hpJ93FDdAZdkDrYN6F5xgphYZgIcbTNaWSa1LsEHa bJvcQbMvFBTk0SuNplgFGVI5YuSAL/IXzXBMmfjqie+XGPvDohd6ThEK9HSUGmuXbGF9 Ys2g9vFnqLhcxWXvrZlo5erTJ35keuvSdoxIWo9K0NOK5gUEQ2DGgnaVz3JvW2bfWVNl 8TcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=UKIl3M8xmI1UPgSypzB/IccUfueIBduRfrnMV7olaNo=; b=yAV5RfBy+IncQB38EGfTseVG8Qe5V7mSUaGPAt/noVCuxcDr+D+HYagC+bH9yW002p Q0yFgBvmiNGt3IbSPLNulnL/JWwwDauAFzw76MYJNlN46aBJBZPfyuhWYOHV/3+tiTt4 gUZ0sNZJ5LozdLQ7MFizcaFE/+IcteS7535x/8fF1M7olSDoFiSVRxw689prHiM4KLxc X2smv1TAIH+ZOnK5rlRlY0sxqL/Q20MyMDuZVwfG46k9/Qx3xopCZuIF1g5hO6OqMsfq cTSs4cVYcRsbolrtHPkDcIfjeEK/fTmDIXdY+7Y5N0GmdVEHAqWNmm36LtSrLUmES9dV izhw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id c69si337196ljd.4.2017.11.17.09.07.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Nov 2017 09:07:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id vAHH7loG021982 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 17 Nov 2017 18:07:49 +0100 Subject: Re: [PATCH] isar-image-base: fix owner and group of /proc To: isar-users@googlegroups.com References: <20171117163448.7rzepplfu6npug72@MD1KR9XC.ww002.siemens.net> From: Alexander Smirnov Message-ID: <4777ea65-8495-faa9-9910-0e58bc62dbdc@ilbers.de> Date: Fri, 17 Nov 2017 20:07:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171117163448.7rzepplfu6npug72@MD1KR9XC.ww002.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 9sc9zTqu8ZZP Hi, On 11/17/2017 07:34 PM, Christian Storm wrote: >>>>> Signed-off-by: Christian Storm >>>>> --- >>>>> meta-isar/recipes-core/images/isar-image-base.bb | 2 +- >>>>> meta/recipes-devtools/buildchroot/buildchroot.bb | 2 +- >>>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb >>>>> index c2150b1..a6906c6 100644 >>>>> --- a/meta-isar/recipes-core/images/isar-image-base.bb >>>>> +++ b/meta-isar/recipes-core/images/isar-image-base.bb >>>>> @@ -52,7 +52,7 @@ do_rootfs() { >>>>> -e 's|##ISAR_DISTRO_SUITE##|${DEBDISTRONAME}|g' \ >>>>> "${WORKDIR}/multistrap.conf.in" > "${WORKDIR}/multistrap.conf" >>>>> >>>>> - [ ! -d ${IMAGE_ROOTFS}/proc ] && install -d -m 555 ${IMAGE_ROOTFS}/proc >>>>> + [ ! -d ${IMAGE_ROOTFS}/proc ] && sudo install -d -o 0 -g 0 -m 555 ${IMAGE_ROOTFS}/proc >>>> >>>> What is the requirement for doing so? And what is the benefit? >>> >>> In the resulting image, /proc was created with my build user's ownership >>> != root as it was non-existent. To create the directory belonging to >>> root, sudo is required here... >>> >> >> Thanks, got it! But I don't think it's also required for buildchroot. > > Nope, not strictly required but for cosmetics and symmetry reasons I put > it in there as well. Doesn't do harm either.. > So I'm going to apply the first part of the patch (related to image) to avoid adding new 'sudo' without real usecase. Also in context of dropping 'sudo' from Isar, image generation and buildchroot generation are not so symmetric. buildchroot has less strict requirements (like out of GID/UID support) what makes it possible to use PRoot to completely drop 'sudo' around buildchroot operations. So keeping image and buildchroot generation processes synchronized could bring unnecessary difficulties. Alex