public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file
@ 2024-08-09  6:51 srinuvasan.a via isar-users
  2024-08-09 16:43 ` 'Jan Kiszka' via isar-users
  2024-08-27 15:45 ` Uladzimir Bely
  0 siblings, 2 replies; 14+ messages in thread
From: srinuvasan.a via isar-users @ 2024-08-09  6:51 UTC (permalink / raw)
  To: isar-users; +Cc: jan.kiszka, Srinuvasan A

From: Srinuvasan A <srinuvasan.a@siemens.com>

Now debhelper supports the versions debhelper-compat (= 9) till
debhelper-compat (= 13), hence set appropriate debian helper compatible version
in the debian/control file and remove the debian/compat file.

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 meta/recipes-kernel/linux/files/debian/compat       | 1 -
 meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
 delete mode 100644 meta/recipes-kernel/linux/files/debian/compat

diff --git a/meta/recipes-kernel/linux/files/debian/compat b/meta/recipes-kernel/linux/files/debian/compat
deleted file mode 100644
index f599e28b..00000000
--- a/meta/recipes-kernel/linux/files/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-10
diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl b/meta/recipes-kernel/linux/files/debian/control.tmpl
index 04ad0f4f..ae257b7c 100644
--- a/meta/recipes-kernel/linux/files/debian/control.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
@@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
 Section: kernel
 Priority: optional
 Maintainer: ${MAINTAINER}
-Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
+Build-Depends: debhelper-compat (= 12), bc, kmod, cpio, ${KBUILD_DEPENDS}
 Homepage: http://www.kernel.org/
 
 Package: linux-image-${KERNEL_NAME_PROVIDED}
-- 
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20240809065158.224059-1-srinuvasan.a%40siemens.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file
  2024-08-09  6:51 [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file srinuvasan.a via isar-users
@ 2024-08-09 16:43 ` 'Jan Kiszka' via isar-users
  2024-08-11 14:20   ` Srinuvasan Arjunan
  2024-08-27 15:45 ` Uladzimir Bely
  1 sibling, 1 reply; 14+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2024-08-09 16:43 UTC (permalink / raw)
  To: srinuvasan.a, isar-users

On 09.08.24 08:51, srinuvasan.a@siemens.com wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> Now debhelper supports the versions debhelper-compat (= 9) till

What is "now" in this context? Which Debian releases are your referring
to? Keep in mind that we are still compiling down to buster with these
files. Doubt that this would still work...

> debhelper-compat (= 13), hence set appropriate debian helper compatible version
> in the debian/control file and remove the debian/compat file.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/compat b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..ae257b7c 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= 12), bc, kmod, cpio, ${KBUILD_DEPENDS}
>  Homepage: http://www.kernel.org/
>  
>  Package: linux-image-${KERNEL_NAME_PROVIDED}

Jan

-- 
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/e2f0d76f-a156-43f7-9c33-66495639a38f%40siemens.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file
  2024-08-09 16:43 ` 'Jan Kiszka' via isar-users
@ 2024-08-11 14:20   ` Srinuvasan Arjunan
  0 siblings, 0 replies; 14+ messages in thread
From: Srinuvasan Arjunan @ 2024-08-11 14:20 UTC (permalink / raw)
  To: isar-users


[-- Attachment #1.1: Type: text/plain, Size: 2717 bytes --]



On Friday, August 9, 2024 at 10:13:44 PM UTC+5:30 Jan Kiszka wrote:

On 09.08.24 08:51, srinuv...@siemens.com wrote: 
> From: Srinuvasan A <srinuv...@siemens.com> 
> 
> Now debhelper supports the versions debhelper-compat (= 9) till 

What is "now" in this context? Which Debian releases are your referring 
to? Keep in mind that we are still compiling down to buster with these 
files. Doubt that this would still work...


    yes am aware that one still we are supporting buster Debian release, i 
hope the default compatibility
    version for buster is 12, and already we had some discussion in the 
mailing list, please refer [1].

     Triggered the build for QEMU buster with this changes, it is getting 
passed, need to check any other real H/W buster build
      with compat 12 .

     [1]:  
https://groups.google.com/g/isar-users/c/6obXqgY0CC4/m/_DOppmgEBAAJ 



> debhelper-compat (= 13), hence set appropriate debian helper compatible 
version 
> in the debian/control file and remove the debian/compat file. 
> 
> Signed-off-by: Srinuvasan A <srinuv...@siemens.com> 
> --- 
> meta/recipes-kernel/linux/files/debian/compat | 1 - 
> meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +- 
> 2 files changed, 1 insertion(+), 2 deletions(-) 
> delete mode 100644 meta/recipes-kernel/linux/files/debian/compat 
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/compat 
b/meta/recipes-kernel/linux/files/debian/compat 
> deleted file mode 100644 
> index f599e28b..00000000 
> --- a/meta/recipes-kernel/linux/files/debian/compat 
> +++ /dev/null 
> @@ -1 +0,0 @@ 
> -10 
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl 
b/meta/recipes-kernel/linux/files/debian/control.tmpl 
> index 04ad0f4f..ae257b7c 100644 
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl 
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl 
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED} 
> Section: kernel 
> Priority: optional 
> Maintainer: ${MAINTAINER} 
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS} 
> +Build-Depends: debhelper-compat (= 12), bc, kmod, cpio, 
${KBUILD_DEPENDS} 
> Homepage: http://www.kernel.org/ 
> 
> Package: linux-image-${KERNEL_NAME_PROVIDED} 

Jan 

-- 
Siemens AG, Technology 
Linux Expert Center 

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/cfa40c6d-5fb0-48e8-93b3-a19a33527b28n%40googlegroups.com.

[-- Attachment #1.2: Type: text/html, Size: 3874 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file
  2024-08-09  6:51 [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file srinuvasan.a via isar-users
  2024-08-09 16:43 ` 'Jan Kiszka' via isar-users
@ 2024-08-27 15:45 ` Uladzimir Bely
  2024-08-28  5:04   ` 'Arjunan, Srinu' via isar-users
  2024-09-09  5:51   ` [PATCH v2] " srinuvasan.a via isar-users
  1 sibling, 2 replies; 14+ messages in thread
From: Uladzimir Bely @ 2024-08-27 15:45 UTC (permalink / raw)
  To: srinuvasan.a, isar-users; +Cc: jan.kiszka

On Fri, 2024-08-09 at 12:21 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> Now debhelper supports the versions debhelper-compat (= 9) till
> debhelper-compat (= 13), hence set appropriate debian helper
> compatible version
> in the debian/control file and remove the debian/compat file.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/compat
> b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl
> b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..ae257b7c 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= 12), bc, kmod, cpio,
> ${KBUILD_DEPENDS}
>  Homepage: http://www.kernel.org/
>  
>  Package: linux-image-${KERNEL_NAME_PROVIDED}
> -- 
> 2.34.1
> 

Hello all.

The patch checked in CI and it passes OK, but it's not clear from a
discussion if it is worth applying.

-- 
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/d7e733c5d76c7f478c1929194dd01318f45745d1.camel%40ilbers.de.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file
  2024-08-27 15:45 ` Uladzimir Bely
@ 2024-08-28  5:04   ` 'Arjunan, Srinu' via isar-users
  2024-09-09  5:51   ` [PATCH v2] " srinuvasan.a via isar-users
  1 sibling, 0 replies; 14+ messages in thread
From: 'Arjunan, Srinu' via isar-users @ 2024-08-28  5:04 UTC (permalink / raw)
  To: Uladzimir Bely, isar-users; +Cc: Kiszka, Jan

Thanks Uladzimir, Will update the build status of real target ASAP from my end as well.

-----Original Message-----
From: Uladzimir Bely <ubely@ilbers.de>
Sent: 27 August 2024 21:16
To: Arjunan, Srinu (DI CTO FDS CES LX PBU 2) <srinuvasan.a@siemens.com>; isar-users@googlegroups.com
Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>
Subject: Re: [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file

On Fri, 2024-08-09 at 12:21 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> Now debhelper supports the versions debhelper-compat (= 9) till
> debhelper-compat (= 13), hence set appropriate debian helper
> compatible version in the debian/control file and remove the
> debian/compat file.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
>
> diff --git a/meta/recipes-kernel/linux/files/debian/compat
> b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl
> b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..ae257b7c 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= 12), bc, kmod, cpio,
> ${KBUILD_DEPENDS}
>  Homepage:
> http://www.k/
> ernel.org%2F&data=05%7C02%7Csrinuvasan.a%40siemens.com%7C7fa7950ce18d4
> 474a83408dcc6af4b00%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C63860
> 3703423305649%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=iM4bLGTAYnfF1lOA
> %2FKpouvr3WOzgXjfLhwBxbomy%2BbM%3D&reserved=0
>
>  Package: linux-image-${KERNEL_NAME_PROVIDED}
> --
> 2.34.1
>

Hello all.

The patch checked in CI and it passes OK, but it's not clear from a
discussion if it is worth applying.

--
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/PUZPR06MB57470665617018C417F4A90688952%40PUZPR06MB5747.apcprd06.prod.outlook.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v2] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file
  2024-08-27 15:45 ` Uladzimir Bely
  2024-08-28  5:04   ` 'Arjunan, Srinu' via isar-users
@ 2024-09-09  5:51   ` srinuvasan.a via isar-users
  2024-09-09  5:53     ` 'Arjunan, Srinu' via isar-users
  2024-09-11 11:28     ` Uladzimir Bely
  1 sibling, 2 replies; 14+ messages in thread
From: srinuvasan.a via isar-users @ 2024-09-09  5:51 UTC (permalink / raw)
  To: isar-users; +Cc: jan.kiszka, ubely, srinuvasan

From: srinuvasan <srinuvasan.a@siemens.com>

debhelper supports the versions debhelper-compat (= 9) till
debhelper-compat (= 13), hence set appropriate debian helper compatible version
in the debian/control file and remove the debian/compat file.

Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
---
 meta/recipes-kernel/linux/files/debian/compat       | 1 -
 meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
 delete mode 100644 meta/recipes-kernel/linux/files/debian/compat

diff --git a/meta/recipes-kernel/linux/files/debian/compat b/meta/recipes-kernel/linux/files/debian/compat
deleted file mode 100644
index f599e28b..00000000
--- a/meta/recipes-kernel/linux/files/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-10
diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl b/meta/recipes-kernel/linux/files/debian/control.tmpl
index 04ad0f4f..f4273ea9 100644
--- a/meta/recipes-kernel/linux/files/debian/control.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
@@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
 Section: kernel
 Priority: optional
 Maintainer: ${MAINTAINER}
-Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
+Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod, cpio, ${KBUILD_DEPENDS}
 Homepage: http://www.kernel.org/
 
 Package: linux-image-${KERNEL_NAME_PROVIDED}
-- 
2.39.2

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20240909055139.899124-1-srinuvasan.a%40siemens.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH v2] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file
  2024-09-09  5:51   ` [PATCH v2] " srinuvasan.a via isar-users
@ 2024-09-09  5:53     ` 'Arjunan, Srinu' via isar-users
  2024-09-11 11:28     ` Uladzimir Bely
  1 sibling, 0 replies; 14+ messages in thread
From: 'Arjunan, Srinu' via isar-users @ 2024-09-09  5:53 UTC (permalink / raw)
  To: isar-users; +Cc: Kiszka, Jan, ubely

Hi All,

With this change, tested few buster and bullseye and bookworm builds working fine, thanks

-----Original Message-----
From: Arjunan, Srinu (DI CTO FDS CES LX PBU 2) <srinuvasan.a@siemens.com>
Sent: 09 September 2024 11:22
To: isar-users@googlegroups.com
Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>; ubely@ilbers.de; Arjunan, Srinu (DI CTO FDS CES LX PBU 2) <srinuvasan.a@siemens.com>
Subject: [PATCH v2] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file

From: srinuvasan <srinuvasan.a@siemens.com>

debhelper supports the versions debhelper-compat (= 9) till debhelper-compat (= 13), hence set appropriate debian helper compatible version in the debian/control file and remove the debian/compat file.

Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
---
 meta/recipes-kernel/linux/files/debian/compat       | 1 -
 meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat

diff --git a/meta/recipes-kernel/linux/files/debian/compat b/meta/recipes-kernel/linux/files/debian/compat
deleted file mode 100644
index f599e28b..00000000
--- a/meta/recipes-kernel/linux/files/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-10
diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl b/meta/recipes-kernel/linux/files/debian/control.tmpl
index 04ad0f4f..f4273ea9 100644
--- a/meta/recipes-kernel/linux/files/debian/control.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
@@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
 Section: kernel
 Priority: optional
 Maintainer: ${MAINTAINER}
-Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
+Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod, cpio,
+${KBUILD_DEPENDS}
 Homepage: http://www.kernel.org/

 Package: linux-image-${KERNEL_NAME_PROVIDED}
--
2.39.2

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/PUZPR06MB5747AF090F716A98FBB2EBA988992%40PUZPR06MB5747.apcprd06.prod.outlook.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file
  2024-09-09  5:51   ` [PATCH v2] " srinuvasan.a via isar-users
  2024-09-09  5:53     ` 'Arjunan, Srinu' via isar-users
@ 2024-09-11 11:28     ` Uladzimir Bely
  2024-12-16 11:20       ` [PATCH v3] meta/recipes-kernel: " srinuvasan.a via isar-users
  1 sibling, 1 reply; 14+ messages in thread
From: Uladzimir Bely @ 2024-09-11 11:28 UTC (permalink / raw)
  To: srinuvasan.a, isar-users

On Mon, 2024-09-09 at 11:21 +0530, srinuvasan.a@siemens.com wrote:
> From: srinuvasan <srinuvasan.a@siemens.com>
> 
> debhelper supports the versions debhelper-compat (= 9) till
> debhelper-compat (= 13), hence set appropriate debian helper
> compatible version
> in the debian/control file and remove the debian/compat file.
> 
> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/compat
> b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl
> b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..f4273ea9 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod,

This is not in TEMPLATE_VARS, so build fails with error like:

```
Filtered Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc,
kmod, cpio, build-essential:amd64, libelf-dev:amd64, libncurses-
dev:amd64, libssl-dev:amd64, bison, dwarves, flex, git, rsync, build-
essential:amd64, fakeroot:amd64, crossbuild-essential-armhf:amd64,
libc-dev:armhf, libstdc++-dev:armhf

dpkg-deb: error: parsing file '/<<RESOLVERDIR>>/sbuild-build-depends-
main-dummy/DEBIAN/control' near line 4 package 'sbuild-build-depends-
main-dummy:armhf':

 'Depends' field, reference to 'debhelper-compat': version
'${DEBIAN_COMPAT}': version number does not start with digit
```

> cpio, ${KBUILD_DEPENDS}
>  Homepage: http://www.kernel.org/
>  
>  Package: linux-image-${KERNEL_NAME_PROVIDED}

-- 
Best regards,
Uladzimir.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/47c19961404c3a89b9b691c6bd62d53477515adc.camel%40ilbers.de.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] meta/recipes-kernel: use debhelper-compat to generate compat file
  2024-12-16 11:20       ` [PATCH v3] meta/recipes-kernel: " srinuvasan.a via isar-users
@ 2024-12-16 11:15         ` Srinuvasan Arjunan
  2024-12-20  7:48         ` Uladzimir Bely
  2025-01-31 12:14         ` 'Jan Kiszka' via isar-users
  2 siblings, 0 replies; 14+ messages in thread
From: Srinuvasan Arjunan @ 2024-12-16 11:15 UTC (permalink / raw)
  To: isar-users


[-- Attachment #1.1: Type: text/plain, Size: 4208 bytes --]

Apologies for the delayed response, additionally added compat for 
linux-modules too, thanks!  

On Monday, December 16, 2024 at 4:42:52 PM UTC+5:30 srinuv...@siemens.com 
wrote:

> From: srinuvasan <srinuv...@siemens.com>
>
> debhelper supports the versions debhelper-compat (= 9) till 
> debhelper-compat (= 13),
> hence set appropriate debian helper compatible version in the 
> debian/control file and remove the debian/compat file.
>
> Signed-off-by: srinuvasan <srinuv...@siemens.com>
> ---
> meta/recipes-kernel/linux-module/files/debian/compat | 1 -
> meta/recipes-kernel/linux-module/files/debian/control.tmpl | 2 +-
> meta/recipes-kernel/linux-module/module.inc | 3 ++-
> meta/recipes-kernel/linux/files/debian/compat | 1 -
> meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
> meta/recipes-kernel/linux/linux-custom.inc | 1 +
> 6 files changed, 5 insertions(+), 5 deletions(-)
> delete mode 100644 meta/recipes-kernel/linux-module/files/debian/compat
> delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
>
> diff --git a/meta/recipes-kernel/linux-module/files/debian/compat 
> b/meta/recipes-kernel/linux-module/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux-module/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux-module/files/debian/control.tmpl 
> b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> index 67b08244..3ec419f6 100644
> --- a/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: ${PN}
> Section: kernel
> Priority: optional
> Standards-Version: 3.9.6
> -Build-Depends: ${DEBIAN_BUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), 
> ${DEBIAN_BUILD_DEPENDS}
> Maintainer: ISAR project <isar-...@googlegroups.com>
>
> Package: ${PN}
> diff --git a/meta/recipes-kernel/linux-module/module.inc 
> b/meta/recipes-kernel/linux-module/module.inc
> index 1734816b..3e8e5e7a 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -57,7 +57,8 @@ TEMPLATE_VARS += " \
> SIGNATURE_KEYFILE \
> SIGNATURE_CERTFILE \
> SIGNATURE_HASHFN \
> - PN"
> + PN \
> + DEBIAN_COMPAT"
>
> # Add custom cflags to the kernel build
> KCFLAGS ?= "-fdebug-prefix-map=${CURDIR}=. -fmacro-prefix-map=${CURDIR}=."
> diff --git a/meta/recipes-kernel/linux/files/debian/compat 
> b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl 
> b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..f4273ea9 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
> Section: kernel
> Priority: optional
> Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod, cpio, 
> ${KBUILD_DEPENDS}
> Homepage: http://www.kernel.org/
>
> Package: linux-image-${KERNEL_NAME_PROVIDED}
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc 
> b/meta/recipes-kernel/linux/linux-custom.inc
> index bcdacaa9..e825d29b 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -89,6 +89,7 @@ TEMPLATE_VARS += " \
> HEADERS_INSTALL_EXTRA \
> ISAR_ENABLE_COMPAT_ARCH \
> COMPAT_DISTRO_ARCH \
> + DEBIAN_COMPAT \
> "
>
> inherit dpkg
> -- 
> 2.39.5
>
>

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/c09540d8-7fe6-4e7f-b526-a1b32a21ca0cn%40googlegroups.com.

[-- Attachment #1.2: Type: text/html, Size: 5421 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v3] meta/recipes-kernel: use debhelper-compat to generate compat file
  2024-09-11 11:28     ` Uladzimir Bely
@ 2024-12-16 11:20       ` srinuvasan.a via isar-users
  2024-12-16 11:15         ` Srinuvasan Arjunan
                           ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: srinuvasan.a via isar-users @ 2024-12-16 11:20 UTC (permalink / raw)
  To: isar-users; +Cc: ubely, srinuvasan

From: srinuvasan <srinuvasan.a@siemens.com>

debhelper supports the versions debhelper-compat (= 9) till debhelper-compat (= 13),
hence set appropriate debian helper compatible version in the debian/control file and remove the debian/compat file.

Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
---
 meta/recipes-kernel/linux-module/files/debian/compat       | 1 -
 meta/recipes-kernel/linux-module/files/debian/control.tmpl | 2 +-
 meta/recipes-kernel/linux-module/module.inc                | 3 ++-
 meta/recipes-kernel/linux/files/debian/compat              | 1 -
 meta/recipes-kernel/linux/files/debian/control.tmpl        | 2 +-
 meta/recipes-kernel/linux/linux-custom.inc                 | 1 +
 6 files changed, 5 insertions(+), 5 deletions(-)
 delete mode 100644 meta/recipes-kernel/linux-module/files/debian/compat
 delete mode 100644 meta/recipes-kernel/linux/files/debian/compat

diff --git a/meta/recipes-kernel/linux-module/files/debian/compat b/meta/recipes-kernel/linux-module/files/debian/compat
deleted file mode 100644
index f599e28b..00000000
--- a/meta/recipes-kernel/linux-module/files/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-10
diff --git a/meta/recipes-kernel/linux-module/files/debian/control.tmpl b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
index 67b08244..3ec419f6 100644
--- a/meta/recipes-kernel/linux-module/files/debian/control.tmpl
+++ b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
@@ -2,7 +2,7 @@ Source: ${PN}
 Section: kernel
 Priority: optional
 Standards-Version: 3.9.6
-Build-Depends: ${DEBIAN_BUILD_DEPENDS}
+Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), ${DEBIAN_BUILD_DEPENDS}
 Maintainer: ISAR project <isar-users@googlegroups.com>
 
 Package: ${PN}
diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
index 1734816b..3e8e5e7a 100644
--- a/meta/recipes-kernel/linux-module/module.inc
+++ b/meta/recipes-kernel/linux-module/module.inc
@@ -57,7 +57,8 @@ TEMPLATE_VARS += " \
     SIGNATURE_KEYFILE \
     SIGNATURE_CERTFILE \
     SIGNATURE_HASHFN \
-    PN"
+    PN \
+    DEBIAN_COMPAT"
 
 # Add custom cflags to the kernel build
 KCFLAGS ?= "-fdebug-prefix-map=${CURDIR}=. -fmacro-prefix-map=${CURDIR}=."
diff --git a/meta/recipes-kernel/linux/files/debian/compat b/meta/recipes-kernel/linux/files/debian/compat
deleted file mode 100644
index f599e28b..00000000
--- a/meta/recipes-kernel/linux/files/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-10
diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl b/meta/recipes-kernel/linux/files/debian/control.tmpl
index 04ad0f4f..f4273ea9 100644
--- a/meta/recipes-kernel/linux/files/debian/control.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
@@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
 Section: kernel
 Priority: optional
 Maintainer: ${MAINTAINER}
-Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
+Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod, cpio, ${KBUILD_DEPENDS}
 Homepage: http://www.kernel.org/
 
 Package: linux-image-${KERNEL_NAME_PROVIDED}
diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
index bcdacaa9..e825d29b 100644
--- a/meta/recipes-kernel/linux/linux-custom.inc
+++ b/meta/recipes-kernel/linux/linux-custom.inc
@@ -89,6 +89,7 @@ TEMPLATE_VARS += "                \
     HEADERS_INSTALL_EXTRA         \
     ISAR_ENABLE_COMPAT_ARCH       \
     COMPAT_DISTRO_ARCH            \
+    DEBIAN_COMPAT                 \
 "
 
 inherit dpkg
-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20241216112050.1286204-1-srinuvasan.a%40siemens.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] meta/recipes-kernel: use debhelper-compat to generate compat file
  2024-12-16 11:20       ` [PATCH v3] meta/recipes-kernel: " srinuvasan.a via isar-users
  2024-12-16 11:15         ` Srinuvasan Arjunan
@ 2024-12-20  7:48         ` Uladzimir Bely
  2025-01-31 12:14         ` 'Jan Kiszka' via isar-users
  2 siblings, 0 replies; 14+ messages in thread
From: Uladzimir Bely @ 2024-12-20  7:48 UTC (permalink / raw)
  To: srinuvasan.a, isar-users

On Mon, 2024-12-16 at 16:50 +0530, srinuvasan.a@siemens.com wrote:
> From: srinuvasan <srinuvasan.a@siemens.com>
> 
> debhelper supports the versions debhelper-compat (= 9) till
> debhelper-compat (= 13),
> hence set appropriate debian helper compatible version in the
> debian/control file and remove the debian/compat file.
> 
> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux-module/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux-module/files/debian/control.tmpl | 2 +-
>  meta/recipes-kernel/linux-module/module.inc                | 3 ++-
>  meta/recipes-kernel/linux/files/debian/compat              | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl        | 2 +-
>  meta/recipes-kernel/linux/linux-custom.inc                 | 1 +
>  6 files changed, 5 insertions(+), 5 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux-
> module/files/debian/compat
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
> 
> diff --git a/meta/recipes-kernel/linux-module/files/debian/compat
> b/meta/recipes-kernel/linux-module/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux-module/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux-
> module/files/debian/control.tmpl b/meta/recipes-kernel/linux-
> module/files/debian/control.tmpl
> index 67b08244..3ec419f6 100644
> --- a/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: ${PN}
>  Section: kernel
>  Priority: optional
>  Standards-Version: 3.9.6
> -Build-Depends: ${DEBIAN_BUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}),
> ${DEBIAN_BUILD_DEPENDS}
>  Maintainer: ISAR project <isar-users@googlegroups.com>
>  
>  Package: ${PN}
> diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc
> index 1734816b..3e8e5e7a 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -57,7 +57,8 @@ TEMPLATE_VARS += " \
>      SIGNATURE_KEYFILE \
>      SIGNATURE_CERTFILE \
>      SIGNATURE_HASHFN \
> -    PN"
> +    PN \
> +    DEBIAN_COMPAT"
>  
>  # Add custom cflags to the kernel build
>  KCFLAGS ?= "-fdebug-prefix-map=${CURDIR}=. -fmacro-prefix-
> map=${CURDIR}=."
> diff --git a/meta/recipes-kernel/linux/files/debian/compat
> b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl
> b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..f4273ea9 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod,
> cpio, ${KBUILD_DEPENDS}
>  Homepage: http://www.kernel.org/
>  
>  Package: linux-image-${KERNEL_NAME_PROVIDED}
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
> b/meta/recipes-kernel/linux/linux-custom.inc
> index bcdacaa9..e825d29b 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -89,6 +89,7 @@ TEMPLATE_VARS += "                \
>      HEADERS_INSTALL_EXTRA         \
>      ISAR_ENABLE_COMPAT_ARCH       \
>      COMPAT_DISTRO_ARCH            \
> +    DEBIAN_COMPAT                 \
>  "
>  
>  inherit dpkg

Applied to next, thanks.

-- 
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/228a92826290f0a32e8c1866d98a06d7f977dfe5.camel%40ilbers.de.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] meta/recipes-kernel: use debhelper-compat to generate compat file
  2024-12-16 11:20       ` [PATCH v3] meta/recipes-kernel: " srinuvasan.a via isar-users
  2024-12-16 11:15         ` Srinuvasan Arjunan
  2024-12-20  7:48         ` Uladzimir Bely
@ 2025-01-31 12:14         ` 'Jan Kiszka' via isar-users
  2025-01-31 12:31           ` 'MOESSBAUER, Felix' via isar-users
  2 siblings, 1 reply; 14+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-01-31 12:14 UTC (permalink / raw)
  To: srinuvasan.a, isar-users; +Cc: ubely

On 16.12.24 12:20, srinuvasan.a via isar-users wrote:
> From: srinuvasan <srinuvasan.a@siemens.com>
> 
> debhelper supports the versions debhelper-compat (= 9) till debhelper-compat (= 13),
> hence set appropriate debian helper compatible version in the debian/control file and remove the debian/compat file.
> 
> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux-module/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux-module/files/debian/control.tmpl | 2 +-
>  meta/recipes-kernel/linux-module/module.inc                | 3 ++-
>  meta/recipes-kernel/linux/files/debian/compat              | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl        | 2 +-
>  meta/recipes-kernel/linux/linux-custom.inc                 | 1 +
>  6 files changed, 5 insertions(+), 5 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux-module/files/debian/compat
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
> 
> diff --git a/meta/recipes-kernel/linux-module/files/debian/compat b/meta/recipes-kernel/linux-module/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux-module/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux-module/files/debian/control.tmpl b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> index 67b08244..3ec419f6 100644
> --- a/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: ${PN}
>  Section: kernel
>  Priority: optional
>  Standards-Version: 3.9.6
> -Build-Depends: ${DEBIAN_BUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), ${DEBIAN_BUILD_DEPENDS}
>  Maintainer: ISAR project <isar-users@googlegroups.com>
>  
>  Package: ${PN}
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
> index 1734816b..3e8e5e7a 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -57,7 +57,8 @@ TEMPLATE_VARS += " \
>      SIGNATURE_KEYFILE \
>      SIGNATURE_CERTFILE \
>      SIGNATURE_HASHFN \
> -    PN"
> +    PN \
> +    DEBIAN_COMPAT"
>  
>  # Add custom cflags to the kernel build
>  KCFLAGS ?= "-fdebug-prefix-map=${CURDIR}=. -fmacro-prefix-map=${CURDIR}=."
> diff --git a/meta/recipes-kernel/linux/files/debian/compat b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..f4273ea9 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod, cpio, ${KBUILD_DEPENDS}
>  Homepage: http://www.kernel.org/
>  
>  Package: linux-image-${KERNEL_NAME_PROVIDED}
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
> index bcdacaa9..e825d29b 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -89,6 +89,7 @@ TEMPLATE_VARS += "                \
>      HEADERS_INSTALL_EXTRA         \
>      ISAR_ENABLE_COMPAT_ARCH       \
>      COMPAT_DISTRO_ARCH            \
> +    DEBIAN_COMPAT                 \
>  "
>  
>  inherit dpkg

I /suspect/ (no time right now to dig into details) that this causes
some regression with buster builds. I've just bumped isar in
isar-cip-core, and this error shows up:

https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/9004463238

Does it ring some bell? Maybe this only reveals a sleeping issue, and
actually use the "right" compat version now, but that would still be a
regression.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e638b93f-5c63-4053-a3f6-4cfa502bdd1f%40siemens.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] meta/recipes-kernel: use debhelper-compat to generate compat file
  2025-01-31 12:14         ` 'Jan Kiszka' via isar-users
@ 2025-01-31 12:31           ` 'MOESSBAUER, Felix' via isar-users
  2025-01-31 12:39             ` 'Jan Kiszka' via isar-users
  0 siblings, 1 reply; 14+ messages in thread
From: 'MOESSBAUER, Felix' via isar-users @ 2025-01-31 12:31 UTC (permalink / raw)
  To: Bezdeka, Florian, isar-users, Kiszka, Jan, Arjunan, Srinu; +Cc: ubely

On Fri, 2025-01-31 at 13:14 +0100, 'Jan Kiszka' via isar-users wrote:
> On 16.12.24 12:20, srinuvasan.a via isar-users wrote:
> > From: srinuvasan <srinuvasan.a@siemens.com>
> > 
> > debhelper supports the versions debhelper-compat (= 9) till
> > debhelper-compat (= 13),
> > hence set appropriate debian helper compatible version in the
> > debian/control file and remove the debian/compat file.
> > 
> > Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> > ---
> >  meta/recipes-kernel/linux-module/files/debian/compat       | 1 -
> >  meta/recipes-kernel/linux-module/files/debian/control.tmpl | 2 +-
> >  meta/recipes-kernel/linux-module/module.inc                | 3 ++-
> >  meta/recipes-kernel/linux/files/debian/compat              | 1 -
> >  meta/recipes-kernel/linux/files/debian/control.tmpl        | 2 +-
> >  meta/recipes-kernel/linux/linux-custom.inc                 | 1 +
> >  6 files changed, 5 insertions(+), 5 deletions(-)
> >  delete mode 100644 meta/recipes-kernel/linux-
> > module/files/debian/compat
> >  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
> > 
> > diff --git a/meta/recipes-kernel/linux-module/files/debian/compat
> > b/meta/recipes-kernel/linux-module/files/debian/compat
> > deleted file mode 100644
> > index f599e28b..00000000
> > --- a/meta/recipes-kernel/linux-module/files/debian/compat
> > +++ /dev/null
> > @@ -1 +0,0 @@
> > -10
> > diff --git a/meta/recipes-kernel/linux-
> > module/files/debian/control.tmpl b/meta/recipes-kernel/linux-
> > module/files/debian/control.tmpl
> > index 67b08244..3ec419f6 100644
> > --- a/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> > +++ b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
> > @@ -2,7 +2,7 @@ Source: ${PN}
> >  Section: kernel
> >  Priority: optional
> >  Standards-Version: 3.9.6
> > -Build-Depends: ${DEBIAN_BUILD_DEPENDS}
> > +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}),
> > ${DEBIAN_BUILD_DEPENDS}
> >  Maintainer: ISAR project <isar-users@googlegroups.com>
> >  
> >  Package: ${PN}
> > diff --git a/meta/recipes-kernel/linux-module/module.inc
> > b/meta/recipes-kernel/linux-module/module.inc
> > index 1734816b..3e8e5e7a 100644
> > --- a/meta/recipes-kernel/linux-module/module.inc
> > +++ b/meta/recipes-kernel/linux-module/module.inc
> > @@ -57,7 +57,8 @@ TEMPLATE_VARS += " \
> >      SIGNATURE_KEYFILE \
> >      SIGNATURE_CERTFILE \
> >      SIGNATURE_HASHFN \
> > -    PN"
> > +    PN \
> > +    DEBIAN_COMPAT"
> >  
> >  # Add custom cflags to the kernel build
> >  KCFLAGS ?= "-fdebug-prefix-map=${CURDIR}=. -fmacro-prefix-
> > map=${CURDIR}=."
> > diff --git a/meta/recipes-kernel/linux/files/debian/compat
> > b/meta/recipes-kernel/linux/files/debian/compat
> > deleted file mode 100644
> > index f599e28b..00000000
> > --- a/meta/recipes-kernel/linux/files/debian/compat
> > +++ /dev/null
> > @@ -1 +0,0 @@
> > -10
> > diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl
> > b/meta/recipes-kernel/linux/files/debian/control.tmpl
> > index 04ad0f4f..f4273ea9 100644
> > --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> > +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> > @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
> >  Section: kernel
> >  Priority: optional
> >  Maintainer: ${MAINTAINER}
> > -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> > +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod,
> > cpio, ${KBUILD_DEPENDS}
> >  Homepage: http://www.kernel.org/
> >  
> >  Package: linux-image-${KERNEL_NAME_PROVIDED}
> > diff --git a/meta/recipes-kernel/linux/linux-custom.inc
> > b/meta/recipes-kernel/linux/linux-custom.inc
> > index bcdacaa9..e825d29b 100644
> > --- a/meta/recipes-kernel/linux/linux-custom.inc
> > +++ b/meta/recipes-kernel/linux/linux-custom.inc
> > @@ -89,6 +89,7 @@ TEMPLATE_VARS += "                \
> >      HEADERS_INSTALL_EXTRA         \
> >      ISAR_ENABLE_COMPAT_ARCH       \
> >      COMPAT_DISTRO_ARCH            \
> > +    DEBIAN_COMPAT                 \
> >  "
> >  
> >  inherit dpkg
> 
> I /suspect/ (no time right now to dig into details) that this causes
> some regression with buster builds. I've just bumped isar in
> isar-cip-core, and this error shows up:
> 
> https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/9004463238
> 
> Does it ring some bell? Maybe this only reveals a sleeping issue, and
> actually use the "right" compat version now, but that would still be
> a
> regression.

Hi, I remember Florian Bezdeka reported on issues w.r.t. compat level
changes, but on bookworm:arm64 [1].

What I noticed is that this patch changes the compat level: Prior to
the patch we had debian/compat = 10, now we use compat level 12 for
buster. By that we now automatically enable dh_dwz (which was disabled
before 12). For details, see [2]. We now basically have the following
options (choose at least one):

- set the compat-level for the linux-module to 10 on buster
- make the build compatible with dh_dwz
- disable dh_dwz in the rules files or via DEB_BUILD_OPTIONS=nostrip on
buster (which might also have side effects)

[1] https://groups.google.com/g/isar-users/c/6obXqgY0CC4/m/k6EU-N69AwAJ
[2]
https://manpages.debian.org/testing/debhelper/debhelper-compat-upgrade-checklist.7.en.html

Felix

> 
> Jan
> 
> -- 
> Siemens AG, Foundational Technologies
> Linux Expert Center
> 

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany


-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/cf857d8da6a2900d7814371ad1ea2e0d93bd522b.camel%40siemens.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] meta/recipes-kernel: use debhelper-compat to generate compat file
  2025-01-31 12:31           ` 'MOESSBAUER, Felix' via isar-users
@ 2025-01-31 12:39             ` 'Jan Kiszka' via isar-users
  0 siblings, 0 replies; 14+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-01-31 12:39 UTC (permalink / raw)
  To: Moessbauer, Felix (FT RPD CED OES-DE),
	Bezdeka, Florian (FT RPD CED OES-DE),
	isar-users, Arjunan, Srinu (FT FDS CES LX PBU 2)
  Cc: ubely

On 31.01.25 13:31, Moessbauer, Felix (FT RPD CED OES-DE) wrote:
> On Fri, 2025-01-31 at 13:14 +0100, 'Jan Kiszka' via isar-users wrote:
>> On 16.12.24 12:20, srinuvasan.a via isar-users wrote:
>>> From: srinuvasan <srinuvasan.a@siemens.com>
>>>
>>> debhelper supports the versions debhelper-compat (= 9) till
>>> debhelper-compat (= 13),
>>> hence set appropriate debian helper compatible version in the
>>> debian/control file and remove the debian/compat file.
>>>
>>> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
>>> ---
>>>  meta/recipes-kernel/linux-module/files/debian/compat       | 1 -
>>>  meta/recipes-kernel/linux-module/files/debian/control.tmpl | 2 +-
>>>  meta/recipes-kernel/linux-module/module.inc                | 3 ++-
>>>  meta/recipes-kernel/linux/files/debian/compat              | 1 -
>>>  meta/recipes-kernel/linux/files/debian/control.tmpl        | 2 +-
>>>  meta/recipes-kernel/linux/linux-custom.inc                 | 1 +
>>>  6 files changed, 5 insertions(+), 5 deletions(-)
>>>  delete mode 100644 meta/recipes-kernel/linux-
>>> module/files/debian/compat
>>>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
>>>
>>> diff --git a/meta/recipes-kernel/linux-module/files/debian/compat
>>> b/meta/recipes-kernel/linux-module/files/debian/compat
>>> deleted file mode 100644
>>> index f599e28b..00000000
>>> --- a/meta/recipes-kernel/linux-module/files/debian/compat
>>> +++ /dev/null
>>> @@ -1 +0,0 @@
>>> -10
>>> diff --git a/meta/recipes-kernel/linux-
>>> module/files/debian/control.tmpl b/meta/recipes-kernel/linux-
>>> module/files/debian/control.tmpl
>>> index 67b08244..3ec419f6 100644
>>> --- a/meta/recipes-kernel/linux-module/files/debian/control.tmpl
>>> +++ b/meta/recipes-kernel/linux-module/files/debian/control.tmpl
>>> @@ -2,7 +2,7 @@ Source: ${PN}
>>>  Section: kernel
>>>  Priority: optional
>>>  Standards-Version: 3.9.6
>>> -Build-Depends: ${DEBIAN_BUILD_DEPENDS}
>>> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}),
>>> ${DEBIAN_BUILD_DEPENDS}
>>>  Maintainer: ISAR project <isar-users@googlegroups.com>
>>>  
>>>  Package: ${PN}
>>> diff --git a/meta/recipes-kernel/linux-module/module.inc
>>> b/meta/recipes-kernel/linux-module/module.inc
>>> index 1734816b..3e8e5e7a 100644
>>> --- a/meta/recipes-kernel/linux-module/module.inc
>>> +++ b/meta/recipes-kernel/linux-module/module.inc
>>> @@ -57,7 +57,8 @@ TEMPLATE_VARS += " \
>>>      SIGNATURE_KEYFILE \
>>>      SIGNATURE_CERTFILE \
>>>      SIGNATURE_HASHFN \
>>> -    PN"
>>> +    PN \
>>> +    DEBIAN_COMPAT"
>>>  
>>>  # Add custom cflags to the kernel build
>>>  KCFLAGS ?= "-fdebug-prefix-map=${CURDIR}=. -fmacro-prefix-
>>> map=${CURDIR}=."
>>> diff --git a/meta/recipes-kernel/linux/files/debian/compat
>>> b/meta/recipes-kernel/linux/files/debian/compat
>>> deleted file mode 100644
>>> index f599e28b..00000000
>>> --- a/meta/recipes-kernel/linux/files/debian/compat
>>> +++ /dev/null
>>> @@ -1 +0,0 @@
>>> -10
>>> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl
>>> b/meta/recipes-kernel/linux/files/debian/control.tmpl
>>> index 04ad0f4f..f4273ea9 100644
>>> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
>>> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
>>> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>>>  Section: kernel
>>>  Priority: optional
>>>  Maintainer: ${MAINTAINER}
>>> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
>>> +Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}), bc, kmod,
>>> cpio, ${KBUILD_DEPENDS}
>>>  Homepage: http://www.kernel.org/
>>>  
>>>  Package: linux-image-${KERNEL_NAME_PROVIDED}
>>> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
>>> b/meta/recipes-kernel/linux/linux-custom.inc
>>> index bcdacaa9..e825d29b 100644
>>> --- a/meta/recipes-kernel/linux/linux-custom.inc
>>> +++ b/meta/recipes-kernel/linux/linux-custom.inc
>>> @@ -89,6 +89,7 @@ TEMPLATE_VARS += "                \
>>>      HEADERS_INSTALL_EXTRA         \
>>>      ISAR_ENABLE_COMPAT_ARCH       \
>>>      COMPAT_DISTRO_ARCH            \
>>> +    DEBIAN_COMPAT                 \
>>>  "
>>>  
>>>  inherit dpkg
>>
>> I /suspect/ (no time right now to dig into details) that this causes
>> some regression with buster builds. I've just bumped isar in
>> isar-cip-core, and this error shows up:
>>
>> https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/9004463238
>>
>> Does it ring some bell? Maybe this only reveals a sleeping issue, and
>> actually use the "right" compat version now, but that would still be
>> a
>> regression.
> 
> Hi, I remember Florian Bezdeka reported on issues w.r.t. compat level
> changes, but on bookworm:arm64 [1].
> 
> What I noticed is that this patch changes the compat level: Prior to
> the patch we had debian/compat = 10, now we use compat level 12 for
> buster. By that we now automatically enable dh_dwz (which was disabled
> before 12). For details, see [2]. We now basically have the following
> options (choose at least one):
> 
> - set the compat-level for the linux-module to 10 on buster

I tend to prefer this option, given that buster is already LTS, and we
don't want to bring in other, maybe more subtle surprises.

Jan

> - make the build compatible with dh_dwz
> - disable dh_dwz in the rules files or via DEB_BUILD_OPTIONS=nostrip on
> buster (which might also have side effects)
> 
> [1] https://groups.google.com/g/isar-users/c/6obXqgY0CC4/m/k6EU-N69AwAJ
> [2]
> https://manpages.debian.org/testing/debhelper/debhelper-compat-upgrade-checklist.7.en.html
> 
> Felix
> 
>>
>> Jan
>>
>> -- 
>> Siemens AG, Foundational Technologies
>> Linux Expert Center
>>
> 


-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/67cf570c-8189-492e-bbb7-6bec7841ca87%40siemens.com.

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2025-01-31 12:39 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-09  6:51 [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file srinuvasan.a via isar-users
2024-08-09 16:43 ` 'Jan Kiszka' via isar-users
2024-08-11 14:20   ` Srinuvasan Arjunan
2024-08-27 15:45 ` Uladzimir Bely
2024-08-28  5:04   ` 'Arjunan, Srinu' via isar-users
2024-09-09  5:51   ` [PATCH v2] " srinuvasan.a via isar-users
2024-09-09  5:53     ` 'Arjunan, Srinu' via isar-users
2024-09-11 11:28     ` Uladzimir Bely
2024-12-16 11:20       ` [PATCH v3] meta/recipes-kernel: " srinuvasan.a via isar-users
2024-12-16 11:15         ` Srinuvasan Arjunan
2024-12-20  7:48         ` Uladzimir Bely
2025-01-31 12:14         ` 'Jan Kiszka' via isar-users
2025-01-31 12:31           ` 'MOESSBAUER, Felix' via isar-users
2025-01-31 12:39             ` 'Jan Kiszka' via isar-users

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox